dfinity / nns-dapp

The Dapp of the Internet Computer's Network Nervous System.

NNS Dapp

---

NNS Dapp offers a user-friendly platform for interacting with the Network Nervous System (NNS) and any SNS of the Internet Computer. With this decentralized application, you can easily perform the following actions:

• Send and receive tokens (ICP, ckBTC, CHAT etc.)
• Stake and manage neurons
• Vote on the governance of the Internet Computer and SNSes
• Participate in decentralization swaps
• Create and top up canisters

Links

Some useful links:

• HACKING provides guidance for local development and offers helpful resources for developers.
• BUILD.md contains information about build reproducibility, tools, and pipelines.
• The SNS aggregator is a back-end canister that provides fast, certified data about Service Nervous Systems (SNS).

Getting Help

Here are some ways you can reach out for help or share your best ideas to improve the dapp:

• Issue Tracker: Create a new ticket if you encounter a bug using NNS Dapp, or if an issue arises when you try to run or build the code.
• DFINITY Forum: The forum is a great place to look for information.
• Support: Create a support request if you'd like to get a personalized help.

nns-dapp's Issues

Redundant "Load more proposals"

The NNS frontend dapp, voting tab, displays a link to "load more proposals" even when there are no additional proposals to load.

BUG: Outdated message and behaviour

When creating a new canister with the NNS UI, it shows this

But this is incorrect. 0.1T cycles are charged now for creating a new canister. And hence the minimum should also be reduced.

We can see that the created canister received 1.9T cycles

Expected behaviour:

• Reduce minimum amount to 1.1T or whatever is currently prescribed
• Update the message accordingly

Instructions for following

The following instructions say: "Following allows you to delegate your votes to another neuron holder. You still earn rewards if you delegate your voting rights. You can change your following at any time."
Could you clarify what happens when you follow multiple neurons? Could you clarify that you only get voting rights if that neuron votes.
E.g. "Following allows you to delegate your votes to another neuron. You vote the same as that neuron votes, so you still get voting rewards as long as that neuron votes. You can change your following at any time. (There is also an opportunity to follow a group of neurons, see https://wiki.internetcomputer.org/wiki/Maximizing_Voting_and_NNS_Rewards for more information.)"

DFX_NETWORK=local ./config.sh error

I followed the local development instructions, and in the step "DFX_NETWORK=local ./config.sh", it prints:

do I make a wrong operation anywhere?

Review CSS preprocessor

We should review the CSS preprocessor and the way we imports CSS. This might requires some changes in gix-cmp bundles.

That way we can maybe also migrate from svelte-preprocess to @sveltejs/vite-plugin-svelte.

Stacktrace:

vite v5.0.10 building for production...
transforming (1) .svelte-kit/generated/client-optimized/app.js08:49:48 [vite-plugin-svelte] /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/routes/+layout.svelte svelte.preprocess depends on more than 10 external files which can cause slow builds and poor DX, try to reduce them. Found: /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/colors.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/variables.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/mixins/_media.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/fonts.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/mixins/_fonts.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/theme.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/layout.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/mixins/_display.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/mixins/_layout.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/button.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/mixins/_effect.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/link.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/tag.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/modal.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/grid.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/utility-classes.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/mixins/_content.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/blockquote.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/scrollbar.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/menu.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/selection.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/global/text.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/themes/dark.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/node_modules/@dfinity/gix-components/dist/styles/themes/light.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/themes/legacy.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/themes/global.scss, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/themes/variables.scss

build: inherited rollup breaks build with web worker

Issue

While upgrading our dependencies in #2250 I noticed that we had to pin Rollup - inherited through Vite - to version v3.15.0 otherwise we cannot build the app as it fails building the web workers.

I created a sample repo and forwarded the issue to Vite 👉 vitejs/vite#12745

Feature request - Hide assets with zero balances

I propose implementing a feature that allows users to hide assets with zero balances.

Feature Details

1. Introduce a toggle switch or a settings option that enables users to hide assets with zero balances.
2. Ensure that the user's preference for hiding zero balance assets persists across sessions.

Clear description and separate section for Manage Neuron Topic

For ICDevs.org we'd like for it to be easy for users to "dedicate" their neurons to us in a way that they maintain ownership of the underlying ICP but we are able to harvest the maturity for community and code development tasks that benefit the Internet computer. Current instruction can be found at https://icdevs.org/donations.html and as you can see it is a poor user experience. It would be nice to have a specific section in the NNS that explains what this functionality does and how to use it. This was in the NNS previously...I know because I gave dfinity control of my neurons on accident because it was just lumped in with the other topics. It would be great to have it back in a proper context.

Prevent crashing when using NNS dapp on mobile devices

When using the the NNS dapp on my iPhone 12 pro, and navigate to the voting page, it crashes when scrolling down. I found a quick workaround to prevent this, maybe this quick-fix can be implemented in the live version?

To prevent it from crashing I scroll down slowly (in the hope it doesn’t crash) and then click on the proposal status and only leave “open” selected. Then is doesn’t crash anymore. Is it possible to use this selection by default?

I think it's this piece of code;

nns-dapp/frontend/dart/lib/ui/proposals/governance_tab_widget.dart

Line 47 in e0c2161

final defaultStatuses = [

Please improve error messages

All error messages I've seen are laconic. E.g., I deliberately tried merging maturity in an erroneous way and got "No compatible device found".
May I suggest a review of all error messages with a view towards helping the user to resolve the issues they encounter when hitting an error. E.g., for the above error, perhaps it would be a link to relevant documentation or a list of compatible devices.

Manage neurons error

I have a neuron which still follows some 'manage neuron'. When I try to change following I get this error message:
Sorry, there was an unexpected error. Please try again later. Account with principal aaaa-bbbbb-ccccc-ddddd-eeeee-fffff-ggggg-hhhhh-iiiii-jjjjj-kkk not found!

I don't think that's a useful error message. Will trying again ever resolve the issue or are we just waisting the user's time? What is the user supposed to do or where can they learn what the problem is? Will users in general know what this principal is and where to find it?

Got allows a redirect to a UNIX socket

The latest possible version that can be installed is 11.8.2 because of the following conflicting dependencies:

[email protected] requires [email protected]
[email protected] requires [email protected] via [email protected]

The earliest fixed version is 11.8.5.

Voting tab should be refined

Hi everyone,

We should use a different type of layout for this critical screen, maybe a list with filters. There is to much proposals to present them with cards and a font so big.
Could we add a "find by id" feature too ?

Sincerly

Clicking a link causes Web page to disappear

When I click at:

• ICP Wallet
• Sign with Internet identity
• GitHub
  all the text on the Web page disappears (only background remains).

So, https://nns.ic0.app/ is fully unusable.

Canister Details Disappear while user tries to interact with the `Change Controllers` button

Here is a screen capture of this happening:
https://streamja.com/JGGJJ

Workaround of positioning the cursor above where the button would be to click on it before it disappears is a workaround that seems to work well enough for now.

I had this happen on any browser I can think of on OSX and Linux. Haven't tested on Windows but no reason to believe it would be different.

Additional installation instructions needed for macOS

In addition to needing to install the Rustlang toolchain, the build step requires the following dependencies:

$ brew install gnu-tar
$ brew install xz
$ brew install openssl

BUG: In the latest update, after merging maturity, the merge button still stays clickable

Expectation: Should get disabled

If we click merge in this state, we get an error that looks like this

Fix dapp routing

Hi everyone,

I wanted to vote on the roadmap proposals but I found it very painful because the medium article links to https://dashboard.internetcomputer.org/proposal/XXXXX and there is a button to vote on NNS which doesn't redirect to the proposal because routing is not working properly.
When you click on "vote on NNS" button you're redirected to https://nns.ic0.app/#/proposal/XXXXX which immediately redirects to /#/accounts.
Also when you click on a tab you always stay on /#/accounts.
With so much proposals to vote on, the nns dapp needs to be simplified and fix this issue to enable a maximum of participation.

Sincerly

The loading image is blocking the user from validating the information they’re looking for…

FEATURE REQUEST: Provide a mechanism to transfer cycles from wallet canisters in the NNS "Canisters" interface

An updated interface could even let us filter by canister type or have separate tabs for application vs wallet canisters.

And then wallet canisters could have an additional "Transfer" button

Do not save ic-delegation and ic-identity to local storage

The login flow should be similar to the identity app. It does not save those cookies. If a browser is compromised, the logging of those cookies would allow the attacker to take over.

Disable horizontal scrolling

Hi everyone,

Could we disable the horizontal scrolling on the dapp ? I don't find it really important and I find myself switching tabs without wanting it while scrolling through the "voting tab" (i'm using a macbook trackpad).

Sincerly

Gap in proposal records

When I select all types of proposals the records are consecutive in the beginning, but then start having gaps. There is for instance a gap between 56187 Executed to 56138 Open, 56137 Open, 56134 Executed.
I find this puzzling, I was expecting a consecutive list (perhaps down to some cutoff, right now it goes all the way down to 340 Adopted)

Using nns-dapp and quill with the same seed will generate different principal_id

The principal_id generated locally through the seed is inconsistent with the principal_id displayed on the nns dapp:

Take the following two pieces of code as an example:

seed：1947400 story goddess birth execute canoe sense poverty orchard feel mule indoor credit bulb arrest primary giggle turtle order tell glimpse grid act motion february

nns generated： jwfy3-6d6bo-ri5le-apblk-7tmrd-h7sj5-srhi4-4wntx-4daz6-missz-yqe
local generated： nrw4v-2qe5h-dor7z-mm7x4-hfa5f-tfls6-avaja-aysww-c6bwg-g25mq-jqe

local code

import { Ed25519KeyIdentity } from '@dfinity/identity';
import { mnemonicToSeedSync } from "bip39";
import {
    pub_key_to_address,
} from '@dfinity/rosetta-client';
let crypto;

const HARDENED = 0x80000000;

function toBigEndianArray(n) {
    const byteArray = new Uint8Array([0, 0, 0, 0]);
    for (let i = byteArray.length - 1; i >= 0; i--) {
        const byte = n & 0xff;
        byteArray[i] = byte;
        n = (n - byte) / 256;
    }
    return byteArray;
}

async function derive(
    parentKey,
    parentChaincode,
    i,
) {
    // From the spec: Data = 0x00 || ser256(kpar) || ser32(i)
    const data = new Uint8Array([0, ...parentKey, ...toBigEndianArray(i)]);
    const key = await crypto.subtle.importKey(
        'raw',
        parentChaincode,
        {
            name: 'HMAC',
            hash: { name: 'SHA-512' },
        },
        false,
        ['sign'],
    );

    const h = await crypto.subtle.sign('HMAC', key, data.buffer);
    const slipSeed = new Uint8Array(h.slice(0, 32));
    const chainCode = new Uint8Array(h.slice(32));
    return [slipSeed, chainCode];
}

async function generateMasterKey(
    seed,
) {
    const data = new TextEncoder().encode('ed25519 seed');
    const key = await crypto.subtle.importKey(
        'raw',
        data,
        {
            name: 'HMAC',
            hash: { name: 'SHA-512' },
        },
        false,
        ['sign'],
    );
    const h = await crypto.subtle.sign('HMAC', key, seed);
    const slipSeed = new Uint8Array(h.slice(0, 32));
    const chainCode = new Uint8Array(h.slice(32));
    return [slipSeed, chainCode];
}

export async function fromSeedWithSlip0010(
    masterSeed,
    derivationPath,
) {
    let [slipSeed, chainCode] = await generateMasterKey(masterSeed);

    for (let i = 0; i < derivationPath.length; i++) {
        [slipSeed, chainCode] = await derive(
            slipSeed,
            chainCode,
            derivationPath[i] | HARDENED,
        );
    }

    return Ed25519KeyIdentity.generate(slipSeed);
}

async function main() {
    try {
        crypto = await import('node:crypto');
    } catch (err) {
        console.log('crypto support is disabled!');
    }
    crypto.subtle
    const mem = "story goddess birth execute canoe sense poverty orchard feel mule indoor credit bulb arrest primary giggle turtle order tell glimpse grid act motion february"
    const seed = mnemonicToSeedSync(mem);
    const id = await fromSeedWithSlip0010(seed, [44, 223, 0, 0, 0]);
    console.log(id.getPublicKey().toDer())
    // console.log(pub_key_to_address(id.getPublicKey()))
}

main()

nns-dapp code

import { Ed25519KeyIdentity } from '@dfinity/identity';
import { mnemonicToSeedSync } from "bip39";
let crypto;

const HARDENED = 0x80000000;

function toBigEndianArray(n) {
    const byteArray = new Uint8Array([0, 0, 0, 0]);
    for (let i = byteArray.length - 1; i >= 0; i--) {
        const byte = n & 0xff;
        byteArray[i] = byte;
        n = (n - byte) / 256;
    }
    return byteArray;
}

async function derive(
    parentKey,
    parentChaincode,
    i,
) {
    // From the spec: Data = 0x00 || ser256(kpar) || ser32(i)
    const data = new Uint8Array([0, ...parentKey, ...toBigEndianArray(i)]);
    const key = await crypto.subtle.importKey(
        'raw',
        parentChaincode,
        {
            name: 'HMAC',
            hash: { name: 'SHA-512' },
        },
        false,
        ['sign'],
    );

    const h = await crypto.subtle.sign('HMAC', key, data.buffer);
    const slipSeed = new Uint8Array(h.slice(0, 32));
    const chainCode = new Uint8Array(h.slice(32));
    return [slipSeed, chainCode];
}

async function generateMasterKey(
    seed,
) {
    const data = new TextEncoder().encode('ed25519 seed');
    const key = await crypto.subtle.importKey(
        'raw',
        data,
        {
            name: 'HMAC',
            hash: { name: 'SHA-512' },
        },
        false,
        ['sign'],
    );
    const h = await crypto.subtle.sign('HMAC', key, seed);
    const slipSeed = new Uint8Array(h.slice(0, 32));
    const chainCode = new Uint8Array(h.slice(32));
    return [slipSeed, chainCode];
}

export async function fromSeedWithSlip0010(
    masterSeed,
    derivationPath,
) {
    let [slipSeed, chainCode] = await generateMasterKey(masterSeed);

    for (let i = 0; i < derivationPath.length; i++) {
        [slipSeed, chainCode] = await derive(
            slipSeed,
            chainCode,
            derivationPath[i] | HARDENED,
        );
    }

    return Ed25519KeyIdentity.generate(slipSeed);
}

async function main() {
    try {
        crypto = await import('node:crypto');
    } catch (err) {
        console.log('crypto support is disabled!');
    }
    crypto.subtle
    const mem = "story goddess birth execute canoe sense poverty orchard feel mule indoor credit bulb arrest primary giggle turtle order tell glimpse grid act motion february"
    const seed = mnemonicToSeedSync(mem);
    const id = await fromSeedWithSlip0010(seed, [44, 223, 0, 0, 0]);
    console.log(id.getPrincipal().toString())
}

main()

[Bug?] After adding a new device, logging back into the nns dapp gives a fetch error

Device: iOS 16.2 (20C65)
Browser: Safari

Description: After adding a new device through internet identity, navigating to the nns dapp at nns.ic0.app throws the following error on initial page load.

FEATURE REQUEST: Mechanism to label canisters that are listed in the "Canisters" tab

Since a lot of individuals (myself included) use the NNS UI to manage cycle balances and topups for canisters, it quickly becomes unwieldy to try and identify which canister is for what project using just the canister principal IDs.
A mechanism to add some sort of identifying label to each canister listed in the canisters tab would help greatly in organizing canisters by what project they belong to.

In the NNS UI, we should make sure that the information asked from the NNS canisters is authentic, especially the accounts and the proposals

Please see this Jira ticket for a more detailed description of the problem and for what I think is a summary of possible solutions that I have seen in the various slack discussions about this issue

Stake neuron fails on Safari

The spinner appears but no 'call' request is made to the back end so this is definitely an issue somewhere on the front end.

Info about proposals

In the current design the dapp displays title, proposer id and proposal id.
I think it should display topic, since otherwise a proposal may be given a misleading title may lead me to believe it is for a different topic (and maybe I don't follow anybody for that category).
(And personally, proposer id and proposal id is not useful)

Improve dynamic chunking

We might want to resolve this bundling warning:

[plugin:vite:reporter]
(!) /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/stores/sns.store.ts is dynamically imported by /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/services/neurons.services.ts but also statically imported by /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/components/launchpad/Projects.svelte, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/components/launchpad/Proposals.svelte, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/derived/sns/sns-projects.derived.ts, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/derived/sns/sns-token-symbol-selected.store.ts, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/derived/sns/sns-total-supply-token-amount.derived.ts, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/pages/ProjectDetail.svelte, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/services/$public/sns.services.ts, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/services/sns-finalization.services.ts, /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/services/sns.services.ts, dynamic import will not move module into another chunk.

[plugin:vite:reporter]
(!) /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/identities/ledger.identity.ts is dynamically imported by /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/proxy/icp-ledger.services.proxy.ts but also statically imported by /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/services/icp-ledger.services.ts, dynamic import will not move module into another chunk.

[plugin:vite:reporter]
(!) /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/services/icp-ledger.services.ts is dynamically imported by /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/proxy/icp-ledger.services.proxy.ts but also statically imported by /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/services/neurons.services.ts, dynamic import will not move module into another chunk.

Proposed improvement to voting on the Proposals pane

As of today, when I have lots of open proposals that I want to manually vote on, it is a rather arduous procedure:

1. Visit the "Voting" pane.
2. Click on the "Hide ineligible" checkbox.
3. Click on the first visible proposal, wait for it to load (several seconds).
4. Scroll down to the bottom.
5. Click Accept or Reject.
6. Click that yes, I'm sure.
7. Wait several seconds.
8. Press the little "Back" button in the upper left of the window.
9. Repeat.

My suggestion is to change this page entirely, or allow for an "advanced" voting mode. It would work like this:

1. "Hide ineligible" is the default.
2. Every proposal has a disclosure triangle next to it to reveal the whole summary on that same page. This way, I don't have to click anything to read further.
3. Every proposal has a radio button next to it: yes/no. This allows me to bulk select yes or no for every eligible, open proposal.
4. At the bottom is a single button "Submit votes", that does not prompt for confirmation. Or maybe it does, but I can mark a checkbox to remove the confirmation in future. It then proceeds to submit my votes, proposal by proposal.

This would allow me to very quickly vote on dozens of proposals without every leaving the proposals page, and without having to wait for network acknowledgement of the vote for each proposal before moving on to vote on the next.

Sub account transactions not showing

The 'TransactionSyncService.syncAccount' function in 'transaction_sync_service.dart' is only ever called with the default account so we are never loading transactions for sub accounts.

Voting records display votes and at the same time say neurons were ineligible

For some proposals, e.g., 55152, the voting record in the NNS dapp shows how my neurons voted, and at the same time say the same neurons were ineligible to vote due to dissolve delay < 6 months.

Cannot execute transaction using Chrome and Ledger

Hi guys,

Today, I wanted to send my ICP tokens using https://nns.ic0.app to my new Ledger Live account.
I have set up a number of tokens and approved the transaction in Ledger device. From Ledger side, everything looks fine, but in the browser I got an error: "Sorry, there was an error trying to execute the transaction".
Could you help me?

Chrome: Version 119.0.6045.159 (Official Build) (arm64)

Preload transaction URL

It would be great to be able to open the NNS via a URL with a query string that would preload a transaction. It would be nice to prefill the to address, amount of ICP, and memo field. Then the user would be able to select the account they want to send from and confirm the transaction. This will help with usability.

Example
http://nns.ic0.app/?mode=transfer&to=kdfjljdljalkjdfkldjfjdjfdlj&amount=124.568&memo=45

This query string should survive Internet Identity verification.

Nns Dapp wants to connect to HID Device

Reporting this error from mparikh on forum:
"So I was trying out an innocuous feature on Nns Dapp – Add Hotkey.

After adding and removing an Hotkey, I was trying the Add HotKey function again on Chrome in Ubuntu 20.04.

At that point, I got these two pops.

I have never connected the ledger wallet to the nns dapp. What gives?
I am unable to reproduce this behavior."

Not able to trace this in context of call stack.

Improvements on the Neurons tab of the nns wallet

Hey guys so I have some requests/feedback for the neurons tab of the nns wallet dapp.

1. It would be super super awesome to switch from these pill like things to a table format. This way you can know how many neurons you have easily. At the moment I need to count by hand and that does not work with many neurons.
2. Provide an overall sum of the entire stake. There is no way to currently know how much ICP the user has staked across all neurons. This would help immensely.
3. Show that staking amount in the ICP tab so one can have a full view of the ICP in their accounts.
4. Allow toggle between staking end date and amount of dissolve delay.
   
   Would be nice to show an end date there.
5. When the neurons tab becomes a table allow sorting it by dissolve delay, stake, maturity etc. This will be immensely helpful to manage one's neurons.
6. Allow translation of maturity to ICP you can claim in the maturity tab
   
7. Show the neuron's age bonus.

Improve accuracy of calculation for total voting power

Problem: It appears that stake, age bonus, dissolve delay bonus, and voting power are all displayed with 2 decimal places. However, the actual calculation is based on a lot more decimal places. Hence, a manual calculation based on the parameters on display does not equal to the voting power that is displayed. In the example below, the manually calculated value is 6342.49 and the displayed value is 6324.62, which is a discrepancy of 23.94 votes. This was enough for the end user who provided this screen capture to question the accuracy of the calculations.

Solution: If the voting power result that is displayed is going to have 6 significant figures as shown in the screen capture, then the age bonus and the dissolve delay bonus need to be shown with 6 significant figures as well. Alternatively, if age bonus and dissolve delay bonus are going to be displayed with 3 significant digits, then the voting power result should also have only 3 significant figures. From a more practical perspective, you could display 4 decimal places for age bonus and dissolve delay bonus. Then the rounding discrepancies would only be evident in the largest neurons.

Ability to merge neurons

I noticed there's a new button to split neurons.

If there could be an analogous button to merge neurons, that would make neuron management much easier for users. Especially because a bunch of neurons were probably spawned by users prior to the release of the "merge maturity" feature a couple months ago.

Runtime error - unreachable code on IOS mobile

I encountered the following error while logging into the NNS dapp on safari mobile.

Timestamp: Fri, 16 Jun 2023 14:52:09 GMT

Request: {
"method": "GET",
"url": "https://nns.ic0.app/",
"origin": "https://nns.ic0.app"
}

CVE-2022-29078 - Template injection in ejs

Bumps ejs from 3.1.6 to 3.1.8.

Release notes

Sourced from ejs's releases.

v3.1.8

Version 3.1.8

v3.1.7

Version 3.1.7

Commits

• 5126ff5 Version 3.1.8
• 7d5a1c6 Merge branch 'main' of github.com:mde/ejs into main
• 551949d Minor mitigation
• 66f7471 Merge pull request #664 from netcode/patch-1
• 820855a Version 3.1.7
• 076dcb6 Don't use template literal
• faf8b84 Skip test -- error message vary depending on JS runtime
• c028c34 Update packages
• 839ad20 Update SECURITY.md
• c040180 Update README.md
• Additional commits viewable in compare view

imhunterandwill resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @imhunterandrebase.

---

imhunterand commands and options

You can trigger imhunterand actions by commenting on this PR:

You can disable automated security fix PRs for this repo from the Security Alerts page.