GithubHelp home page GithubHelp logo

Comments (3)

dgm9704 avatar dgm9704 commented on August 26, 2024

Thank you for getting in touch! I will take a look at this as soon as I can, probably tomorrow.

from xoxo.

dgm9704 avatar dgm9704 commented on August 26, 2024

Okay, you're not wrong.
When comparing facts, it seems logical that the contexts should be taken into account.
Unfortunately the comparison can't be done with just contextRef alone,
since there can be two contexts in the same report with different id but same scenario, or two contexts in different reports with same id but different scenarios.
So the comparison would need to also include the "deep" comparison of the contexts, and this cause performance issues.
This could be shortcircuited eg. same report + same contextRef = same context, etc.
So the comparison needs a bit more logic than is obvious at the surface level.
(Which is probably why I left it out in the first place)
I tried something quick and dirty just to get some feel for the worst case performance hit, BUT that resulted in a test failing, which means I have a possible bug to sort out first.
So, I recognize the issue and am working on it, but it might take some time.

from xoxo.

dgm9704 avatar dgm9704 commented on August 26, 2024

Ok, I think I found the bug and a fix for it.
But the bad news is that the simplest addition that includes contexts when comparing facts,
slows the comparisons to a crawl, increasing time taken to something like 50 times more,
which is too much for any decent size report.
I will work on the short circuiting, and maybe some memoization, and probably some other
enhancements that hopefully would make this feasible.
And I will need to think about the relationship of facts in different reports also.

from xoxo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.