dhs / rat Goto Github PK

Based on controller name.

On a fresh install, if the admin puts his email in the invite form before admin/setup, login and signup behave oddly.

The app name displays both in the header bar, and next to the page title. Is this necessary?

For authentication and such. Could be done after controller is constructed but before routing in Application::initialise().
User authentication should be a lib file.
Create a list of filters (referencing lib files) to run and when. Check before routing each time whether to run function.

Maybe useful for first-run setup?

Form errors, 404s, application level errors. Catch in Application.php

Alias system to allow neater URLs.

link_to() function should generate alias URLs where possible.

• List methods should only query the database for the ids then use get method
• Hardcode fields to return in get methods (no more SELECT *)

link_to($controller, $view, $id)

/themes/default/css/ -> public/css/
/js/ -> public/js/

Update .htaccess accordingly.

Are any static images used?

redirect_to is currently tacked on the end of quite a few forms action urls

See js/rat.js.

Could probably be consolidated into one function?

Move constructor logic to lib/filters.php

Remove user_id parameter from calls.

Move methods like Comment::list_item to Item::comments.
Change unnecessary static methods to instance methods.
Update refs.

Tab indenting to the current level on all blank lines

Beta mode - only allow beta signup.
Private block all pages except for logged in users and those in public_pages array.

http://twitter.github.com/bootstrap/

Scan models folder for available files then loop and include each one.

If statements without curly braces were a bad call on my part as they're liable to break if people try to extend them.

Done:

• Comments
• Likes
• Pages
• Sessions

Todo:

• Admin
• Ajax (follow and unfollow)
• Invites
• Items
• Reset (add into users)
• Settings (add into users)
• Search (fix results)
• Signup (add into users)

Pages should have their own database table and content should be loaded from there rather than view files.

Classes of helper functions loaded by each controller.

Separation of config file into app config and server config should help.

Proposal for plugins 2.0: single file containing views, models, controllers and custom SQL to run.
Also custom routes, possibly in app config.

Error, notice and success messages set in the session.

Also content.

Finished User

Should now use url_for instead of link_to(NULL). No backwards compatibility.

Remove calls to include 'foo.php' from each controller.