dieulot / instantclick-website

InstantClick’s website

👉🏻  dieulot.fr

instantclick-website's Issues

instant click issue

https://seoblock.myshopify.com/pages/faqs
I integrated instant click on my site and the iframes aren't there, and the accordions don't work

Adding "data-no-instant" with jQuery?

I have a situation where I cannot easily add data-no-instant directly to the markup and instead need to add it with Javascript.

If I wrap the InstantClick.init(); in a document ready jquery function, then when I add the attributes to the elements on page load it works OK. However, once I navigate away from the page to another page and then back to the original page (homepage in this case). The data-no-instant is still present on the elements- but they no longer work and InstantClick still tries to preload the page.

Also, why is it setup so that data-no-instant isn't a proper attribute? The plugin should look for data-no-instant=true or data-no-instant=data-no-instant.

displayed url deosn't follow redirected url

If the response is redirection, the URL in path bar doesn't follow to the redirected url.

Preload external links on iframe?

Hello, I have simple website with 2 frames, sidebar and content.

Sidebar has many links to external websites and when I click on those links I usually see white screen for 5 secs before sites starts to load. I don't want that. So here is a questions:

1. Does instantclick supports external links to preload?
2. How it supports "base target="main"/" in HEAD section? When I intalled it, I could get to open my links on content iframe, it always opening links in sidebar.

New Feature: Add ability to have more than 'a' elements trigger the load of page

Perhaps you could add in the ability to have more than 'a' elements trigger the instant click, this could allow more customisation to a potential page, such as 'div' elements replacing 'a' elements.

Scenario:
I was trying to use a table with links to position links, when I came upon a problem, getting the child a element to fill the parent, which was a 'td', I spent ages trying to find a way to do that, so I wanted to be able to use more than just a elements for instant click, I tried to find a way, but I am not that good with JavaScript, so could not. I have found a way, after trawling many forums and pages,

thre is a problem while working with bootstrap model

you can check by yourself
http://oceangreen.ml/admin/
please visit this site
then do login with
email : [email protected]
password : test1234

then visit the state section under the home link, the edit button in-front of each state name has a bootstrap model. first time when i click the button model open but the background opacity goes high to 100%,
or sometime when we click the button the model just blink up.

i wann use instantclick along with bootstrap features, what should be the solution

Interested in having an Apache version, or should I fork?

Apache instead of NGINX, should that be in this base or should I fork? Other thoughts?

Some typos

Leaving these in an issue as per contributing guidelines, let me know if you'd like a PR

• /: "scales to appropriate size" should be "scales to the appropriate size"
• /download: "Read those articles" should be "Read these articles"
• /how-it-works: "InstantClick shows his" should be something like "InstantClick shows its own"
• /blacklisting & /assets-changes: "add it a ... attribute" should be "add a ... attribute" or "give it a ... attribute"

page scroll on click

not sure if this is an issue with the page or the library, but it looks like the page scrolls to the top before the new page loads in the latest version of Safari: https://files.anfedorov.com/instantclick.mov

Click event can be fired without touch start

Since the action of click doesn't require user's touch on the button or link, the 'Click − Touchstart' expression will not work well under such circumstance that user touch outside the button or link (but very close). It will lead to the result that 'Click − Touchstart' time become longer and longer because the star time is never resetted.

I don't know how to fix this. If you don't think it's a problem you can closet this issue

4.0

Would love to see 4.0 or onward if you plan on restarting on anytime soon. There are many features that would be great to have, like ajax forms and bug fixes.

Error after loading first page: Uncaught TypeError: Cannot read property 'style' of undefined

Installed it, initialized it like the instructions say, and it works but if I laod in the loading-indicator.js file it doesn't work properly. The first link I click in my navigation does everything correctly: bar shows up (but doesn't go fullwidth to indicate 100% for some reason) and the next page loads very fast. I click any other link in the navigation and it throws the error: Uncaught TypeError: Cannot read property 'style' of undefined and the loading bar slowly fills up to 99% and stops and doesn't load the link.

In my footer: <script data-no-instant>InstantClick.init();</script>

EDIT: Was loading the main script in the header and not the footer.