dimabory / ecoji-js Goto Github PK

I keep getting the error "Invalid rune provided", but only for 🀄... Any idea how to fix this?

Also, separate issue quick fix, I am using binary data now after reading the issue about it, but it should be an option to set the encoding type for that part. There's no reason it should by default only decode binary data.... There should be a pass-inargument for that for both decode and encode. I tried to make a fork which implemented it but weirdly couldnt load the library any longer. So I ended up just converting all my data to binary data (difficult to find functions for it since Javascript didn't support binary data at all until only a few years ago).

https://github.com/dimabory/ecoji-js/network/alerts

Is your feature request related to a problem? Please describe.
validate-commit-msg is DEPRECATED now

Describe the solution you'd like
Replace dep with https://github.com/conventional-changelog/commitlint

• badges
• table of contents
• introduction
• installation
• usage
• license

Would be great to have the browser compatible build (the best is ES5 support).

While working on #3 I was running some test. I tried running the following commands (using commit b51529a) and there were lots of differences.

~/git/ecoji-js$ head -c 100 /dev/urandom > test.dat
~/git/ecoji-js$ cat test.dat | ecoji -w 0  | xxd > ecoji-go-xxd.txt
~/git/ecoji-js$ cat test.dat | node ./bin/cli.js  | xxd > ecoji-js-xxd.txt
~/git/ecoji-js$ diff ecoji-go-xxd.txt ecoji-js-xxd.txt 

If I convert the random binary data to base64, then there are no diffs except for a new line diff.

~/git/ecoji-js$ cat test.dat | base64 -w 0 | node ./bin/cli.js  | xxd > ecoji-js-xxd.txt
~/git/ecoji-js$ cat test.dat | base64 -w 0 | ecoji -w 0  | xxd > ecoji-go-xxd.txt
~/git/ecoji-js$ diff ecoji-js-xxd.txt ecoji-go-xxd.txt 
28c28
< 000001b0: f09f 8f81 e298 95e2 9895 e298 950a       ..............
---
> 000001b0: f09f 8f81 e298 95e2 9895 e298 95         .............

So I suspect there is something going on with binary data. This may be because string is used in the source instead of byte array. I don't know javascript well enough to say. If this is a limitation of javascript, a disclaimer in the readme might help.

---> https://github.com/keith-turner/ecoji