distributedproofreaders / pphtml Goto Github PK

The classes x-ebookmaker and x-ebookmaker-drop are added/used by ebookmaker, but they currently may generate "used but not defined" warnings/errors (see #4 ) from pphtml

There is an argument for assuming these two classes will be handled by ebookmaker so the user does not need to be alarmed by "used but not defined" or "defined but not used" warnings about them, which could also obscure genuine warnings.

lhamilton
9:34 AM
Hi Robert -- Here's what I got from Roger - I’m glad to hear that Robert is willing to update pphtml. If he does, I have a feature request. The WWers are struggling with HTML4 uploads from DP that have phantom columns. If the users used HTML5 then the validator would catch it, but the HTML4 validator doesn’t. Unfortunately, Eric’s code downstream from the WWers does catch it, putting the burden of discovery back on the WWers. And finding where the phantom columns are is difficult. I’d sure like to see pphtml catch that.

So there’s no confusion about what a phantom column is:

Heading
milk	cheese

The first line tells the browser to expect one per row. Then there are two tags in the next row. This is an error in HTML5 but the HTML4 validator lets it go unreported.

It is not an error if a class name is used on an element, but that class is not used as a selector in the CSS.
It may be a mistake, e.g. a typo, so I think it is correct to "warn" about it, but it should not be a "FAIL"

I think the relevant line of code is this one where the word "FAIL" should be changed to "warn"

PG are updating their preferred <title> format to
<title>Alice's Adventures in Wonderland | Project Gutenberg</title>

pphtml's title check/message will need updating too.

Quentin Campbell:

Describe the bug
PPHTML (both DP Workbench and GG versions) incorrectly flags as being 'undefined' CSS entries that use the ::first-letter selector.

The output from the online DP Workbench version of PPHTML says:

defined CSS:
... drop-cap-a ...
used CSS:
drop-cap-a drop-cap-b drop-cap-c
not defined but used:
drop-cap-b drop-cap-c
To Reproduce

1. Open Guiguts
2. Create an HTML file with the following CSS and HTML
   CSS :

p.drop-cap-a { color: transparent; margin-left: -1.4em; }
p.drop-cap-b:first-letter { color: transparent; margin-left: -1.4em; }
p.drop-cap-c::first-letter { color: transparent; margin-left: -1.4em; }
HTML:

QQ

QQ

QQ

1. Open the HTML menu ... 2. Scroll down to 'PPhtml' and click 3. See error in the report that is produced Expected behavior That PPhtml report should not claim that classes 'drop-cap-b' and 'drop-cap-c' are undefined.

Environment

• Guiguts version: 1.6-test2
• OS and version: Windows 10
• Perl version:
• Perl distribution:
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.