divio / aldryn-people

People and Organizations

Deprecated

This project is no longer supported.

Divio will undertake no further development or maintenance of this project. If you are interested in continuing to develop it, use the fork functionality from GitHub. We are not able to transfer ownership of the repository to another party.

Aldryn People for django CMS

Aldryn People allows you to:

• add people and groups of people to your website
• display them on CMS pages
• download vCards

Please see the Aldryn People documentation, which includes information on installation and getting started.

It also contains documentation for content editors and end-users.

Contributing

Aldryn People is a an open-source project. We'll be delighted to receive your feedback in the form of issues and pull requests. Before submitting your pull request, please review our guidelines for Aldryn Addons.

We're grateful to all contributors who have helped create and maintain this package.

Contributors are listed at contributions page.

Requirements

• Python 2.7, 3.4, 3.5, 3.6
• django CMS 3.4.5, 3.5, 3.6
• Django 1.11, 2.0, 2.1

aldryn-people's Issues

Python 3 supported already?

The docs state that Python 3 isn't supported because of a dependency on vobject.
But that is removed a long time ago in this PR.

Is there any other reason why Python 3 isn't supported?

don't break if person has no slug

People don't require a slug. The view already handles this correctly by trying to get the object by slug or id.

But in the template you need to be able to reverse the url for both cases.

so something like {% url 'detail' person.slug_or_id %} should be possible.

allow putting people in multiple groups

proposed implementation:

• A sortedm2m on Person to Group called groups.
• In admin only show the sortedm2m field. Hide the group, but keep the group field on the model (this is the "primary" group). Always save the first selected item from the sortedm2m as the primary group (backwards compatibility and easier queries for the primary group).

Several Usability Updates

• People List, the user should be able to edit a team member within the plugins list, not only within the admin
• Rename "Comment" to "Description"
• Check that everything works as expected

correct namespaces in templates

in templates when reversing the urls, they are used without a namespace:
{% url 'detail' person.id %}

This is way too broad, since any app might define a url named detail.
It should be pointing to the app namespace {% url 'aldryn_people:detail' person.id %}.

Some additional reading :-) http://stackoverflow.com/questions/2030225/how-to-get-current-app-for-using-with-reverse-in-multi-deployable-reusable-djang/13249060#13249060

add cms toolbar integration

design decision needed: where/when do we display the menu item? (there is no person detail view or typical apphook)

When selecting "grouped" do not show entries that have no group

or make group mandatory (departement)

Unicode Fail if Umlauts in title

Hi there,

I encountered unicode errors while trying to download a vcard of someone with umlauts in their title/function.

I am running the current version of django-cms with python 2.7.

However 2 little changes fixed this issue.

Social connections

We should add fields for the several social networks and IM-Messengers, e.g.

• linkedin
• xing
• twitter
• facebook
• skype
• Google+

Information about group is shown only in "People" list plugin

Information about group is shown only in "People" list plugin, but not on group detailed page or page with "People" application

.

.

email field for group

Sometimes, groups have their own email (e.g. [email protected], [email protected]...). It would be nice if Group had a field for this

allow ordering of People in PeoplePlugin

maybe with this: https://pypi.python.org/pypi/django-sortedm2m

Nice format phone numbers

like [phone] or 079 820 55 44

use plugin urls for vcard download

once django-cms/django-cms#1237 is merged, the apphook for the vcard download can be replaced with this.

Language switching needs a tidy-up

• When switching between languages, you can lose entered data without warning - django CMS warns you "Are you sure you want to change tabs without saving the page first?"
• the language switch tabs are differently-styled from django CMS's
• the name and slug fields are not translated but appear in all language tabs, whereas the function field in-between them is translated - but there's nothing to indicate these different behaviours

Maybe names should be translatable - after all a name in Hebrew or Arabic is not the same as in English or German.

Allow people to be in more than one group / department

Missing installed app in documentation

Documentation states you only need to add:
INSTALLED_APPS = [
…

'aldryn_people',
'hvad',
'sortedm2m',
…

]
To your installed apps. However 'filer' needs to be added as well. e.g

INSTALLED_APPS = [
…

'aldryn_people',
'hvad',
'sortedm2m',
'filer',
…

]

latest migration is missing

When I use your model (i.e. People) in a different app and want to create migrations (./manage makemigrations another_people_app) this migration creates the missing migration for aldryn_people as well.

If I then want to deploy to Aldryn I get an error from the system:

django.db.migrations.graph.NodeNotFoundError: Migration aldryn_people_person_plugin.0001_initial dependencies reference nonexistent parent node ('aldryn_people', '0018_auto_20160725_1342')

Of course this is kind of easy to fix by referring to an older migration file but it has happened quite often with Aldryn / djangocms apps and it's annoying, because it breaks an automatic process (as the content of the migration files is created automatically).

django-phonenumber-field outdated?

setup.py contains:

# DO NOT REMOVE THE FOLLOWING, IT IS REQUIRED FOR EXISTING MIGRATIONS
'django-phonenumber-field>=0.7.2,<2.0.0',

This will install a old version of django-phonenumber-field: v1.3.0 and current version is v3.0.1, see: https://pypi.org/project/django-phonenumber-field/#history

And it runs into: jazzband/pip-tools#625 (comment)

Legacy templates don't work, are incomplete

Merge Address, Postal Code and City

Does not make sense to have all these fields, rather use one field "Address" or rename it to "Street" and make it a smaller field.

Cleanups and renamings

might be renamed to aldryn-team

rename groups to "Departements" as this makes more sense for a website rather than "Companies"

(1146, "Table 'mysite.reversion_revision' doesn't exist")

The error
(1146, "Table 'mysite.reversion_revision' doesn't exist")

while trying to add group or person I receive this error

Add Image per people

The user should be able to add a portrait/image for each team member

Selecting people in the people list plugin broken?

I am trying to select only some people in the people list plugin (djangocms edit mode), however multiple choices get reduced to one choice upon saving.

Also, I am unable to sort people.

There are no errors in the javascript console.

Cannot add a new group properly when there are none to start with

When there are no, existing groups, attempting to create a group with the ➕ in the Person change form doesn't work. Well, technically, it works (the group is created), but the pop-up window turns blank and doesn't refresh the Person change form.

On investigation, there is a JS error in the popup as shown here:

It is not clear why, but there seems to be an interaction between sortedm2m's and Django's own JS that only happens when there are no existing objects in the m2m widget.

A better way of associating People with Users is needed

This is very user-unfriendly:

u'aldryn_people' is not a registered namespace error after deleting page with application

if delete page with aldryn_people namespace, all pages where People list were used - fails (if at least one person created)

Expected: Information message sgould be shown instead of plugin for admin user only as it works for other addons
https://gist.github.com/kkovrizhenko/e48c14d263811d1b384d

Aldryn Haystack: Error updating aldryn_people

it seems there is an incompatibility with django-haystack using the elastic search beta on Aldryn:

When I run ./manage.py rebuild_index on the docker container (with the production env vars set in .env-local). I am using Aldryn with Docker for Mac.

I run django-parler version: 1.6.5

POST https://search-aldryn-whatdigital-es-7tayzqk3v7g44dz7avjkq5kfje.eu-central-1.es.amazonaws.com:443/local_en/_refresh [status:200 request:0.053s]
Indexing 29 People
Error updating aldryn_people using de 
Traceback (most recent call last):
  File "/virtualenv/lib/python3.5/site-packages/haystack/management/commands/update_index.py", line 188, in handle_label
    self.update_backend(label, using)
  File "/virtualenv/lib/python3.5/site-packages/haystack/management/commands/update_index.py", line 233, in update_backend
    do_update(backend, index, qs, start, end, total, verbosity=self.verbosity, commit=self.commit)
  File "/virtualenv/lib/python3.5/site-packages/haystack/management/commands/update_index.py", line 96, in do_update
    backend.update(index, current_qs, commit=commit)
  File "/virtualenv/lib/python3.5/site-packages/haystack/backends/elasticsearch_backend.py", line 166, in update
    prepped_data = index.full_prepare(obj)
  File "/virtualenv/lib/python3.5/site-packages/haystack/indexes.py", line 212, in full_prepare
    self.prepared_data = self.prepare(obj)
  File "/virtualenv/lib/python3.5/site-packages/aldryn_search/base.py", line 42, in prepare
    self.prepared_data['text'] = self.get_search_data(obj, current_language, request)
  File "/virtualenv/lib/python3.5/site-packages/aldryn_people/search_indexes.py", line 34, in get_search_data
    return strip_tags(self.get_description(obj)).strip()
  File "/virtualenv/lib/python3.5/site-packages/aldryn_people/search_indexes.py", line 21, in get_description
    return obj.description
  File "/virtualenv/lib/python3.5/site-packages/parler/fields.py", line 92, in __get__
    translation = instance._get_translated_model(use_fallback=True, meta=meta)
  File "/virtualenv/lib/python3.5/site-packages/parler/models.py", line 471, in _get_translated_model
    lang_dict = get_language_settings(language_code)
  File "/virtualenv/lib/python3.5/site-packages/parler/utils/i18n.py", line 80, in get_language_settings
    return appsettings.PARLER_LANGUAGES.get_language(language_code, site_id)
  File "/virtualenv/lib/python3.5/site-packages/parler/utils/conf.py", line 114, in get_language
    if lang_dict['code'].split('-')[0] == language_code.split('-')[0]:
AttributeError: 'NoneType' object has no attribute 'split'
Traceback (most recent call last):
  File "manage.py", line 7, in <module>
    startup.manage(path=os.path.dirname(os.path.abspath(__file__)))
  File "/virtualenv/lib/python3.5/site-packages/aldryn_django/startup.py", line 11, in manage
    utility.execute()
  File "/virtualenv/lib/python3.5/site-packages/django/core/management/__init__.py", line 346, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/virtualenv/lib/python3.5/site-packages/django/core/management/base.py", line 394, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/virtualenv/lib/python3.5/site-packages/django/core/management/base.py", line 445, in execute
    output = self.handle(*args, **options)
  File "/virtualenv/lib/python3.5/site-packages/haystack/management/commands/rebuild_index.py", line 26, in handle
    call_command('update_index', **options)
  File "/virtualenv/lib/python3.5/site-packages/django/core/management/__init__.py", line 120, in call_command
    return command.execute(*args, **defaults)
  File "/virtualenv/lib/python3.5/site-packages/django/core/management/base.py", line 445, in execute
    output = self.handle(*args, **options)
  File "/virtualenv/lib/python3.5/site-packages/haystack/management/commands/update_index.py", line 183, in handle
    return super(Command, self).handle(*items, **options)
  File "/virtualenv/lib/python3.5/site-packages/django/core/management/base.py", line 623, in handle
    label_output = self.handle_label(label, **options)
  File "/virtualenv/lib/python3.5/site-packages/haystack/management/commands/update_index.py", line 188, in handle_label
    self.update_backend(label, using)
  File "/virtualenv/lib/python3.5/site-packages/haystack/management/commands/update_index.py", line 233, in update_backend
    do_update(backend, index, qs, start, end, total, verbosity=self.verbosity, commit=self.commit)
  File "/virtualenv/lib/python3.5/site-packages/haystack/management/commands/update_index.py", line 96, in do_update
    backend.update(index, current_qs, commit=commit)
  File "/virtualenv/lib/python3.5/site-packages/haystack/backends/elasticsearch_backend.py", line 166, in update
    prepped_data = index.full_prepare(obj)
  File "/virtualenv/lib/python3.5/site-packages/haystack/indexes.py", line 212, in full_prepare
    self.prepared_data = self.prepare(obj)
  File "/virtualenv/lib/python3.5/site-packages/aldryn_search/base.py", line 42, in prepare
    self.prepared_data['text'] = self.get_search_data(obj, current_language, request)
  File "/virtualenv/lib/python3.5/site-packages/aldryn_people/search_indexes.py", line 34, in get_search_data
    return strip_tags(self.get_description(obj)).strip()
  File "/virtualenv/lib/python3.5/site-packages/aldryn_people/search_indexes.py", line 21, in get_description
    return obj.description
  File "/virtualenv/lib/python3.5/site-packages/parler/fields.py", line 92, in __get__
    translation = instance._get_translated_model(use_fallback=True, meta=meta)
  File "/virtualenv/lib/python3.5/site-packages/parler/models.py", line 471, in _get_translated_model
    lang_dict = get_language_settings(language_code)
  File "/virtualenv/lib/python3.5/site-packages/parler/utils/i18n.py", line 80, in get_language_settings
    return appsettings.PARLER_LANGUAGES.get_language(language_code, site_id)
  File "/virtualenv/lib/python3.5/site-packages/parler/utils/conf.py", line 114, in get_language
    if lang_dict['code'].split('-')[0] == language_code.split('-')[0]:
AttributeError: 'NoneType' object has no attribute 'split'

Person should have a placeholder for additional content on the details page

Currently, the detailed view of a person shows exactly the same information as the overview. IMHO, it would be a good idea to add a placeholder to the Person model, such that additional content (text, images, whatever) can be added to the detailed view of a person, similar to a news entry in aldryn-newsblog.

I think this is quite a typical use case, see for example this "people" page of a university institute. The overview shows some well-structured data (name, e-mail, phone number) and if you click on a person, the detailed view shows additional text.

Group Company

Depending on the added people, the person.group should be grouped per loop like:

Group

• People
• People
• People

Group

• People
  ...

The html is uncommented currently.

vcard download fails if person is not translated to current language

http://dpaste.com/1324380/

TemplateDoesNotExist at admin/aldryn_common/widgets/sortedm2m_widget.html

When I click "Add People", I get the following error. See ticket: divio/aldryn-common#14

System check failed

When I execute "python manage.py check", I got following error:

CommandError: System check identified some issues:

ERRORS:
aldryn_people.Person.visual: (fields.E300) Field defines a relation with model 'Image', which is either not installed, or is abstract.

OS: Ubuntu 14.04LTS 64bit
Python: 2.7.6
Django: 1.7.4
Django-cms: 3.0.10
aldryn-people: 0.4.6

Python3 support pip install fails

Hi!

I'm having the following log problem while installing aldryn-newsblog on python3.4 for django cms (3.0.12),
is there any support available for this?

Thanks

Downloading/unpacking vobject (from aldryn-people>=0.4.6->aldryn-newsblog)
  Downloading vobject-0.6.6.tar.gz (53kB): 53kB downloaded
  Running setup.py (path:/Users/davidetruffo/Projects/venvs/mentor/build/vobject/setup.py) egg_info for package vobject
    Traceback (most recent call last):
      File "<string>", line 17, in <module>
      File "/Users/davidetruffo/Projects/venvs/mentor/build/vobject/setup.py", line 31, in <module>
        from ez_setup import use_setuptools
      File "/Users/davidetruffo/Projects/venvs/mentor/build/vobject/ez_setup/__init__.py", line 94
        except pkg_resources.VersionConflict, e:
                                            ^
    SyntaxError: invalid syntax
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

  File "<string>", line 17, in <module>

  File "/Users/davidetruffo/Projects/venvs/mentor/build/vobject/setup.py", line 31, in <module>

    from ez_setup import use_setuptools

  File "/Users/davidetruffo/Projects/venvs/mentor/build/vobject/ez_setup/__init__.py", line 94

    except pkg_resources.VersionConflict, e:

                                        ^

SyntaxError: invalid syntax

fix testsuite for aldryn-boilerplates

find out why these build are failing: https://travis-ci.org/aldryn/aldryn-people/jobs/53900404
seems to be problems checking out from github.

Add checkbox "select all" and groups

• Select all within the admin
• Display Groups in addition to the names within the admin or "filter by groups"