Comments (2)
Thanks for your report! The current introspection in derive_order_key
is indeed pretty ad-hoc - since sqlalchemy's internals have a reasonably strong type heirarchy, a lot of those hasattr
checks can probably be replaced by isinstance
checks.
I'll try to find some time to fix this soon, but we're also very happy to accept pull requests: if you wanted to add a minimal test in test_paging.py that fails due to this bug, that would be a great starting point.
from sqlakeyset.
Hey @acarapetis, thanks so much for tackling this and sorry for not having the time to contribute the test myself. Waiting eagerly for this to get merged :)
from sqlakeyset.
Related Issues (20)
- PyPI publication pipeline is broken
- Tuple/ROW comparison not supported in Oracle and SQL Server HOT 4
- Support SQLAlchemy 2.0-style ORM queries HOT 11
- Custom binding logic issue HOT 2
- Support multiple engines in one Session
- ORM Query is called 3 times.
- Get the total number of pages and / or records returned by query HOT 2
- First queries are unbounded HOT 1
- When paging backwards, page.paging.items() seems to misalign bookmarks and values HOT 6
- Add type hints HOT 2
- Sorting by literal_column produces invalid SQL and fails HOT 2
- ImportError: cannot import name 'LegacyRow' from 'sqlalchemy.engine.row' HOT 2
- Question: Converting Page to Pydantic Model HOT 2
- FeatureRequest: get_pages/select_pages HOT 1
- asyncpg uuid support HOT 1
- asyncio paging returns tuples of length 1 HOT 1
- Breaks on sqlalchemy & flask-sqlalchemy on a simple model HOT 3
- SQLAlchemy 2 wrong type for column desc HOT 4
- Breaks when using sqlalchemy session HOT 2
- `row._mapping` is broken after pagination HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sqlakeyset.