GithubHelp home page GithubHelp logo

Comments (2)

acarapetis avatar acarapetis commented on August 27, 2024

Thanks for your report! The current introspection in derive_order_key is indeed pretty ad-hoc - since sqlalchemy's internals have a reasonably strong type heirarchy, a lot of those hasattr checks can probably be replaced by isinstance checks.

I'll try to find some time to fix this soon, but we're also very happy to accept pull requests: if you wanted to add a minimal test in test_paging.py that fails due to this bug, that would be a great starting point.

from sqlakeyset.

koirikivi avatar koirikivi commented on August 27, 2024

Hey @acarapetis, thanks so much for tackling this and sorry for not having the time to contribute the test myself. Waiting eagerly for this to get merged :)

from sqlakeyset.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.