djun-kim / statistics--rserveclient Goto Github PK

The ExtUtils::ModuleMaker packaging uses some magic to automatically set a VERSION number, used by CPAN. The default setup extracts the value of this from a source file.

This value was not updated for release-CPAN-0.02.

Moreover, it is painful to auto-update this variable in a release script.

We require v5.12 in our code. However, it seems 5.12 is not so common in the wild. Ubuntu Server 10.04 LTS runs 5.10.1, for example.

We use the 'given' statement, which is new as of 5.10.1, so that seems like a minimum to specify. Are there other features that require a more recent version?

Evaluating list(1, 'a') will currently put the parser into an infinite loop.

The class inherits from Vector, but uses xtype XT_STR, which is a scalar.

First of all, getErrorMessage() is not implemented, so throwing an Exception doesn't really work.

Second, I can't really see this approach working for a number of applications. I think error handling needs to be rethought.

Tests requiring an Rserve server should be configured to not run by default. There should be a way to configure the target Rserve server for testing.

The example given in the synopsis doesn't work:

use Statistics::RserveClient;

my $cnx = new Statistics::RserveClient::Connection($server);
my @result = $cnx->evalString("x='Hello, world!'; x");

It fails with error message:

Can't locate object method "new" via package "Statistics::RserveClient::Connection" (perhaps you forgot to load "Statistics::RserveClient::Connection"?) at ./rs.pl line 6.

The first line should read:

use Statistics::RserveClient::Connection;

as given in the Usage section.

When something goes wrong, it seems the getErrorMessage method can't be found.

Can't locate object method "getErrorMessage" via package "Statistics::RserveClient::Exception=HASH(0xe110ccc)
   Died within Statistics::RserveClient::Connection::new called at line 50 of (eval 2241)
   from within main::rserve_start called at line 44 of (eval 2042)
" (perhaps you forgot to load "Statistics::RserveClient::Exception=HASH(0xe110ccc)
   Died within Statistics::RserveClient::Connection::new called at line 50 of (eval 2241)
   from within main::rserve_start called at line 44 of (eval 2042)
"?) at /usr/lib/perl5/site_perl/5.8.8/Statistics/RserveClient/Connection.pm line 248

To replicate this, you can change the R host to something invalid or non-existing in RservClient.pl and it will fail the connection and throw out this message.

I'd like to use the Module::Starter::PBP utilities to start this, but these look a bit broken at the moment.

Failed unit test:

lib$ prove -r ../t/Rserve/testEvalDataTypes.t 
../t/Rserve/testEvalDataTypes.t .. 1/12 
#   Failed test 'scalar TRUE value'
#   at ../t/Rserve/testEvalDataTypes.t line 19.
#     Structures begin differing at:
#          $got->[0] = 'TRUE'
#     $expected->[0] = '1'
# TRUE

#   Failed test 'scalar FALSE value'
#   at ../t/Rserve/testEvalDataTypes.t line 24.
#     Structures begin differing at:
#          $got->[0] = 'FALSE'
#     $expected->[0] = '0'
# FALSE

#   Failed test 'boolean array'
#   at ../t/Rserve/testEvalDataTypes.t line 29.
#     Structures begin differing at:
#          $got->[0] = 'TRUE'
#     $expected->[0] = '1'
# TRUEFALSE
# Looks like you failed 3 tests of 12.

For example, the hostname or address, port, etc. of the Rserve server needs to be specified and is currently hardcoded.

I'm getting the following error just by use-ing Statistics::RserveClient::Connection:

can't open debug log: No such file or directory

I'm running under Windows (not by choice), and the problem appears to be that you're not defining a platform-independent debug log file in RserveClient.pm:135:

use constant DebugLogfile => "/tmp/rserve-debug.log";

The present name is a bit awkward, excessively descriptive on one hand and not clear on the other. This should be done before other developers (if any are interested) become involved.

Exception handling and error reporting needs to be re-done in some sensible, perl-ish way.