GithubHelp home page GithubHelp logo

Comments (2)

cornerfarmer avatar cornerfarmer commented on June 6, 2024

Hey @AndreyYashkin,

thanks a lot for the issue and the PR! I currently dont fully understand the use-case of the new functionality. However, at the same time, the new feature adds quite a bit of complexity to the material setter/getter and my fear is that this might lead to non-intuitive behavior.

I do understand that you would like to change the material of objects with linked data.
So what speaks against the following workflow:

-> Every time a user sets a material via obj.set_material() the respective material slot gets set to OBJECT

This makes sure that the material is always set only for the specific object instance.
If the user wants to set a material across multiple objects, the user needs to call obj.set_material() inside a for obj in objs loop. But I dont think that is much of a problem.

What do you think about this solution? In my eyes this would be beneficial as it reduces the complexity quite a bit.

from blenderproc.

AndreyYashkin avatar AndreyYashkin commented on June 6, 2024

Sorry for the late response.

  1. From my perspective warping Blender functionality does not lead to any non-intuitive behavior. In contrast, you may try the same operations inside Blender without coding and get the same result. In my PR I added only additional functionality to get actual visible material which is not obvious to get using code in one case, while inside Blender you can see it with your eyes.
  2. Every time a user sets a material via obj.set_material() the respective material slot gets set to OBJECT

Well, I think that it can work too.

from blenderproc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.