dmilicic / android-clean-sample-app Goto Github PK

I want to make a case that MainActivity and other acitvities actually handle things they aren't supposed to in an MVP scenario. For example in the cost deleted case the main activity actually performs a refresh by calling the presenter. I would argue that its up to the presenter to actually decide that a deletion would require a full refresh, or is the idea here that its up to the view to decide how to actually implement this change and it decides to go with a full reload?

just wanted to know that how you have been managed the network failure case.
In the case when io exception will throw(insert() in CostRepositoryImpl.class) even in that case after method return from repository and control comes to interactor, it will notify with "Saved1" toast to presenter hence the ui.

First of all thank you very much for your great work, @dmilicic.

I have been learning your sample app carefully and by now I've found a little inaccuracy in there.

Within domain/interactors/base/AbstractInteractor.java you mentioned that abstract run() is declared public for only easy testing. But actually if this method wasn't declared as a public, it would have been impossible to call it within domain/executor/impl/ThreadExecutor.java.

Hope, it makes sense for beginners, at least.

Regards,
Ivan

Hi dimilicic,
you did a great work! After cloned your repository I found a little issue in the "SyncAdapter" class.
Retrofit changed ".isSuccess()" to ".isSuccessful()" so at the first attempt gradle failed.
Now all works!

Thanks
Regards
Giosk

Hi @dmilicic i am a graphic designer, i want to help others in graphic design.
After i reviewed your project. you have no logo on this project, therefore I want to contribute to this project by creating a new logo/icon. what do you think ? you want it ?

I test the app, when save it can save in local database but not remote, show error:
"Unfortunately, My Costs has stopped " but it still run, and not find any error log