dmitry-ivanov / dark-sky-api

PHP Library for the Dark Sky API.

dark-sky-api's Issues

Use a formatter on the forecastUrl() function for the round() lat/lng.

Versions:

• Package Version: ^1.1
• PHP Version: 7.3.6

Description:

Hey! :)
I got a problem using the library, my PHP locale information was set to fr_FR, and it's making the round() function replace the lat and lng dots with commas. That leads to broke the featured request with a 400 Poorly formatted request :

https://api.darksky.net/forecast/[KEY]/45,509,-73,588

Using the number_format function can fix this problem.

$latitude = number_format(round($parameters->getLatitude(), 3), 3);
$longitude = number_format(round($parameters->getLongitude(), 3), 3);

This is located in src/Http/Request/UrlGenerator.php.

Steps to reproduce:

setlocale(LC_NUMERIC, 'fr_FR'); before execute the forecast function.

Installation stand alone

Hi,

Sorry, I am not familiar with namespaces, normally use includes, but it does not matter what I do, I cannot get your class to work with our api key, can you help?

I want stand alone, could you suggest the correct folder structure to store, and how to call it?

Really really appreciated as your class looks the best type.

Regards

Rob

How to register the alias? please...