The minetest-u_skinsdb from dmonty2

minetest-u_skinsdb's People

Contributors

Stargazers

Watchers

minetest-u_skinsdb's Issues

missing jq in readme

I miss a hint that generate_previews.sh needs jq to be installed.

for ubuntu it would be sudo apt-get install jq

Support for "Numeric author" in skindb

There are some "numeric" authors in skindb that produces the error

Page: 58
Traceback (most recent call last):
  File "update_from_db2.py", line 43, in <module>
    addpage(p+2)
  File "update_from_db2.py", line 35, in addpage
    f.write('name = "'+s["name"]+'",\n')
TypeError: Can't convert 'int' object to str implicitly

So we need the change like the next one

--- a/update_from_db2.py
+++ b/update_from_db2.py
@@ -32,9 +32,9 @@ def addpage(page):
                f.write(base64.b64decode(s["img"]))
                f.close()
                f = open(metadir+"character_"+str(i)+".txt",'w')
-               f.write('name = "'+s["name"]+'",\n')
-               f.write('author = "'+s["author"]+'",\n')
-               f.write('comment = "'+s["license"]+'",\n')
+               f.write('name = "'+str(s["name"])+'",\n')
+               f.write('author = "'+str(s["author"])+'",\n')
+               f.write('comment = "'+str(s["license"])+'",\n')
                f.close()
                i = i + 1
 addpage(1)

The second change that was needed is to change the path in the ".previews/skin_previews.blend" from "../skins/textures" to "../u_skins/textures"

By the way, please update the textures folder in git. Not everyone has python and blender installed. After running the update scripts I get up to 773 skins (previous it was 139 from git). So it will be nice to get all the skins directly after mod installation.

PS: thank you for the great work!

Recommend Projects