docker / github-actions Goto Github PK

I don't see how you can use docker run in the readme, would be great to have a docker run that took env: and volumes and stuff. I need to use docker run because I'm using buildkit, and an exception is being thrown in docker compose.

I tried to login using this Action, as explained in the README (https://github.com/docker/github-actions#commands):

  - run: |
      docker pull docker/github-actions
      INPUT_USERNAME="umarcor" INPUT_PASSWORD="${{ secrets.GITHUB_TOKEN }}" INPUT_REGISTRY="docker.pkg.github.com" docker run docker/github-actions login

But the image seems not to exist:

# docker pull docker/github-actions
Using default tag: latest
Error response from daemon: manifest for docker/github-actions:latest not found: manifest unknown: manifest unknown

Thanks for the work on this. Are there any plans to add outputs to the action?

Before diving in to a PR, I wanted to see if it was being worked on or whether there are valid reasons not to add support.

Info: https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-output-parameter

Hi

Question: Do you use same credential for both?
https://www.docker.com/blog/first-docker-github-action-is-here/

Cheers

If there is an equals symbol in the branch name, the build-push-action fails to build with

Building image [myorg/myrepo:initial-home=page-tweaks myorg/myrepo:sha-5d13f16]
invalid argument "myorg/myrepo:initial-home=page-tweaks" for "-t, --tag" flag: invalid reference format
See 'docker build --help'.
Error: exit status 125
Usage:
exit status 125
  github-actions build-push [flags]
Flags:
  -h, --help   help for build-push

Should there be some special casing for this inline with how there's special casing for slashes in branch names?

Thanks

As other Actions by GitHub or Microsoft, the one using this codebase seems to not handle credentials securely: https://github.com/docker/github-actions/runs/609042636?check_suite_focus=true#step:5:18. It would be desirable to have an official action which handles login properly.

Refs actions/starter-workflows#96 docker/build-push-action#53

I assume it supports BuildKit by using ENV like you do in your GitHub Actions YAML

Based on this I can see this builder is based on the Docker builder but there's no documentation for it.

Does this action officially support BuildKit?

I see that https://github.com/docker/build-push-action uses this as the base for its commands.

I'm always looking for ways to reduce boilerplate in my github actions. In this case the full image URL. There's an open issue for having this as an output.

So given the conditions:
Trigger is push/tag. Say 1.4. And the repo being hello-world. The output generated for the below:

username: ${{ github.actor }}
password: ${{ github.token }}
registry: docker.pkg.github.com
repository: ${{ github.repository }}/hello-world
tag_with_ref: true

Should be able to get a full URL to the image:

docker.pkg.github.com/kyler-hyuna/hello-world/hello-world:1.4