doggershusky / silverstripe-fa-picker Goto Github PK

As far as I can tell, it is currently not possible to include custom icons without disabling built in FA icons using:
disable_builtin_fontawesome: true

I would like an option to use built-in icons alongside any custom category, adding another tab in the picker field with a custom name, so you could choose between FA and custom icons side by side.

Is there any way to do this now, or is it possible to implement the feature?
I am willing to examine the code and submit a pull request myself, in case this feature is desired by anyone else.

Hello, can you make the texts translatable in the backend?

e.g. Filter, All, Solid, Regular, Brands

This may seem like a silly question, but with the free version of font-awesome I cannot for the life of me get the brand icons to display.

When I used this module with font awesome 5 I was able to get them to display but not with version 6 and that is with me trying to use the default set and trying to use 6.5.1 with the following config:

FontawesomeIcons:
  icon_yml_location: 'app/fontawesome/icon-families.yml'
  free_css_cdn_version: '6.5.1'

Can you update to FA 6?

I am currently using version 3 for its silverstripe 5 support

When I attempt to run a dev/build?flush=1 I get the following error:

[Emergency] Uncaught ArgumentCountError: Too few arguments to function BucklesHusky\FontAwesomeIconPicker\Tasks\FontAwesomeUpdater::generateFontAwesomeIconCache(),
0 passed in /.../buckleshusky/fontawesomeiconpicker/src/Extensions/FontAwesomeUpdater.php on line 18 and exactly 1 expected

This can be fixed by updating the TasksFontAwesomeUpdater::generateFontAwesomeIconCache() call in FontAwesomeUpdater.php line 18 from:

TasksFontAwesomeUpdater::generateFontAwesomeIconCache();

To:

$path = Config::inst()->get('FontawesomeIcons', 'icon_yml_location') ? Config::inst()->get('FontawesomeIcons', 'icon_yml_location') : false;
TasksFontAwesomeUpdater::generateFontAwesomeIconCache($path);

Or if you make the getIconYMLLocation() method public instead of private you could use:

$path = TasksFontAwesomeUpdater::getIconYMLLocation();
TasksFontAwesomeUpdater::generateFontAwesomeIconCache($path);