dohomi / dd_googlesitemap_dmf Goto Github PK

Hi,

this extension use loadTCA in class.tx_ddgooglesitemap_dmf.php which causes an error in typo3 7.6. Removing this solves in my case the compatibility to this LTS-version.

Zwirni

The format of the field constraints => conflicts seems to be invalid in the ext_emconf.php.
Typo3 in typo3/sysext/em/classes/tools/class.tx_em_tools.php seems to expect an array.

Exception thrown:
Fatal error: Cannot unset string offsets in /var/www/sca/typo3_src/typo3/sysext/em/classes/tools/class.tx_em_tools.php on line 382 Call Stack: 0.0002 641728 1. {main}() /var/www/sca/typo3_src/typo3/ajax.php:0 0.7369 32507152 2. t3lib_div::callUserFunction() /var/www/sca/typo3_src/typo3/ajax.php:73 0.7373 32576496 3. call_user_func_array() /var/www/sca/typo3_src/t3lib/class.t3lib_div.php:4784 0.7373 32576640 4. t3lib_extjs_ExtDirectRouter->route() /var/www/sca/typo3_src/t3lib/class.t3lib_div.php:0 0.7381 32724656 5. t3lib_extjs_ExtDirectRouter->processRpc() /var/www/sca/typo3_src/t3lib/extjs/class.t3lib_extjs_extdirectrouter.php:106 0.7608 35554424 6. call_user_func_array() /var/www/sca/typo3_src/t3lib/extjs/class.t3lib_extjs_extdirectrouter.php:183 0.7608 35554480 7. tx_em_Connection_ExtDirectServer->getExtensionList() /var/www/sca/typo3_src/t3lib/extjs/class.t3lib_extjs_extdirectrouter.php:0 0.8171 42235656 8. tx_em_Extensions_List->getInstalledExtensions() /var/www/sca/typo3_src/typo3/sysext/em/classes/connection/class.tx_em_connection_extdirectserver.php:116 0.9757 43763080 9. tx_em_Extensions_List->getFlatInstExtList() /var/www/sca/typo3_src/typo3/sysext/em/classes/extensions/class.tx_em_extensions_list.php:94 0.9930 43915952 10. tx_em_Extensions_List->singleExtInfo() /var/www/sca/typo3_src/typo3/sysext/em/classes/extensions/class.tx_em_extensions_list.php:168 0.9930 43916464 11. tx_em_Tools::includeEMCONF() /var/www/sca/typo3_src/typo3/sysext/em/classes/extensions/class.tx_em_extensions_list.php:187 0.9932 43926688 12. tx_em_Tools::fixEMCONF() /var/www/sca/typo3_src/typo3/sysext/em/classes/tools/class.tx_em_tools.php:312 0.9932 43931144 13. tx_em_Tools::depToString() /var/www/sca/typo3_src/typo3/sysext/em/classes/tools/class.tx_em_tools.php:267

Proposed patch:
diff --git a/ext_emconf.php b/ext_emconf.php
index 11f214c..9591a80 100755
--- a/ext_emconf.php
+++ b/ext_emconf.php
@@ -37,7 +37,7 @@ $EM_CONF[$_EXTKEY] = array (
'dd_googlesitemap' => '*',
'typo3' => '4.5.0-6.1.99',
),

• 'conflicts' => '',
• 'conflicts' => array(),
  'suggests' =>
  array (
  ),

I get the following error after installing the extension:

Fatal error: Class 'tx_ddgooglesitemap_ttnews' not found in /srv/www/www.foo.bar/public_html/typo3conf/ext/dd_googlesitemap_dmf/class.tx_ddgooglesitemap_dmf.php on line 43

actually, i want to run it with tx_news and don't use tt_news. the manual says, that tx_news works out of the box?

any advice? thanks

There is a problem when you want to filter by category and the extension uses the new sys_category_record_mm table (like the new tx_news). Here you need to exchange uid_local and uid_foreign. Because the categories belong to sys_category the uid_local is the uid of the category and the uid_foreign is the uid of the news.

I tried to change line 96 of class.tx_ddgooglesitemap_dmf.php like this, and it works for me:

        $sqlMMCondition = $sqlMMTable = '';
        if ($mmTable != '' && count($catMMList) > 0 && $catMMList[0] > 0) {
            $sqlMMTable = ',' . $mmTable;
            //$sqlMMCondition = ' AND ' . $table . '.uid = ' . $mmTable . '.uid_local AND ' . $mmTable . '.uid_foreign IN (' . implode(',', $catMMList) . ')';
            $sqlMMCondition = ' AND ' . $table . '.uid = ' . $mmTable . '.uid_foreign AND ' . $mmTable . '.uid_local IN (' . implode(',', $catMMList) . ')';
        }

Maybe a setting that can exchange local and foreign would be a good Idea.
I use: sqlMMTable = sys_category_record_mm
and: catMMList = 2

The extension seems not to work under 6.2.10.

Even with

?eID=dd_googlesitemap&sitemap=dmf&selector=news&pidList=4604&singlePid=4605

the Result is always:

It appears that there are no extension entries. If your storage sysfolder is outside of the rootline, you may want to use the dd_googlesitemap.skipRootlineCheck=1 TS setup option. Beware: it is insecure and may cause certain undesired effects! Better move your pid sysfolder inside the rootline!

Configuration

plugin.dd_googlesitemap_dmf {
skipRootlineCheck=1
news {
sqlMainTable = tx_news_domain_model_news
sqlCatColumn =
sqlMMTable = sys_category_record_mm
sqlOrder = tstamp DESC
sqlLastUpdated = tstamp
sqlTitle = title
sqlKeywords = keywords
frequency =
linkParams = tx_news_pi1[news]
pidList = 4604
singlePid = 4605
catList =
catMMList =
disableLanguageCheck = 1
}
crawler {
1 = http://url/?eID=dd_googlesitemap
2 = http://url/?eID=dd_googlesitemap&sitemap=dmf&selector=news
}
}

Any Ideas?

I' getting this error:
Fatal error: Class 'tx_ddgooglesitemap_ttnews' not found in /html/typo3/typo3conf/ext/dd_googlesitemap_dmf/class.tx_ddgooglesitemap_dmf.php on line 43

which is useless trash.
Just for your interest. ;)

I have list and details view of news on my site.
On FE my URLs are cool. For example, details view has url:
https://www.mydomain.de/serie/triumphtm/

But in sitemap.xml same page has other url:
https://www.mydomain.de/serie/detail/News/triumphtm/

Why?
TYPO3 (v.7.6.15), RealUrl (v2.1.7), dd_googlesitemap_dmf (v2.0.0)

The Extension seems to work fine with 6.2 ... maybe only the extensions dependings must be changed.

The version in the extension manager is just for typo3 up to 6.1.x. Is there plan for an update?

BTW: Great extensionExtension :-)

The sitemaps for news do not work in TYPO3 4.5, because the TYPO3 autoloader does not find the tx_ddgooglesitemap_dmf class. The ext_autoload.php file is never called.

I guess this is because of the folder name.

My dirty hack which solves the problem: extending the \typo3conf\ext\dd_googlesitemap\ext_autoload.php file by

'tx_ddgooglesitemap_dmf' =>t3lib_extMgm::extPath('dd_googlesitemap_dmf') . 'class.tx_ddgooglesitemap_dmf.php',

The article at http://cweiske.de/tagebuch/typo3-autoloader.htm suggests that the autoloader tries to find the ext_autoload.php by the class name which is needed. Since the class is called "tx_ddgooglesitemap_dmf" (without underscore after dd) and the folder is called "dd_googlesitemap_dmf" (with underscore after dd), TYPO3 seems to be confused.

Not sure if this is your issue or a general problem with TYPO3 4.5 autoloader. Maybe the issue helps others who run into the same problem.