doki-theme / doki-theme-visualstudio Goto Github PK

Wrong color of NuGet Package Manager Console

When a dark theme is selected, the console is light

and when the theme is light the console is dark

This was only tested with the Cinnamon theme, I'm not sure if it applies to the other themes

I just recently noticed that is very problematic to debug stuff in VS with the theme applied, as it makes a lot of icons and information white instead of their respective colors. For Example:

• White instead of Red
  • Stop Button
  • Hot Reload Button
  • Breakpoints
  • Breakpoint Hit
• White instead of Green
  • Continue/Start Button

The ones listed above are very important, as the color kinda determines what they do when taking a quick look (green for start, red for stop or pause).

I have https://marketplace.visualstudio.com/items?itemName=MichaelKissBG8.Supercharger22 installed, which add a code map on the left of the code editor https://supercharger.tools/index.html#sectionCodeMAP

With dark themes, on initial load, the code map looks like this
, the background doesn't extend to the code map, which is not too nice, but at least usable, and much better than after a while when the code map looks like this

The text seems to default to black. Weirdly enough this happens even with themes not provided by Doki Theme, such as the default Black

With doki theme disabled, the text on the code map is correctly displayed

If there's no way to tell the code map to respect the dark light setting because it's generated by another extension, is there a way to at least disable the background overwriting altogether for non-code editor windows?

There are light themes that need to be added to the plugin. The plugin isn't complete with out them, but it is good enough for now.

Wallpaper does not work if wallpaper opacity set between "-0.9" and "0"

VS 2022 community 17.3.3

Exception message is Cannot find resource named 'VS.Cider.InputTextColor'. Resource names are case sensitive.

To reproduce, make a new wpf project, select the grid in the designer and open it's properties window.
Happens to me on VS22 preview 7

There are some themes that have more than one background/sticker. I would be nice to be able to toggle between each of these backgrounds if available.

All themes with more than one background:

It may be similar to #56, I'm using the latest version of Visual Studio 2022 and the extension

Missing hover item highlight in search menu

Default Dark theme

Doki-Theme

Hey folks, I'm from the Visual Studio team and our performance telemetry has caught an issue in this extension where it is causing Visual Studio unresponsivess by consuming large number of thread pool threads in the wild.

Over the past 90 days, we've captured 14 instances of this, with an average of 37 threads, but upwards of 269 threads.

In one of the dumps we captured, I see that the following stack is consuming 269 threads trying to retrieve UserLocalDataPath.

 	ntdll.dll!ZwWaitForMultipleObjects() Line 907	Unknown
 	KERNELBASE.dll!WaitForMultipleObjectsEx(unsigned long nCount, void * const * lpHandles, int bWaitAll, unsigned long dwMilliseconds, int bAlertable) Line 1551	C
 	[Managed to Native Transition]	
 	mscorlib.dll!System.Threading.ManualResetEventSlim.Wait(int millisecondsTimeout, System.Threading.CancellationToken cancellationToken)	Unknown
 	mscorlib.dll!System.Threading.Tasks.Task.SpinThenBlockingWait(int millisecondsTimeout, System.Threading.CancellationToken cancellationToken)	Unknown
 	mscorlib.dll!System.Threading.Tasks.Task.InternalWait(int millisecondsTimeout, System.Threading.CancellationToken cancellationToken)	Unknown
 	mscorlib.dll!System.Threading.Tasks.Task<System.__Canon>.GetResultCore(bool waitCompletionNotification)	Unknown
 	[Frames below may be incorrect and/or missing, no binaries loaded for Microsoft.VisualStudio.Shell.UI.Internal.dll]	
 	[Native to Managed Transition]	
 	msenv.dll!CThreadAwareServiceProvider::QueryService(__VSTASKRUNCONTEXT taskPriority, const _GUID & guidService, const _GUID & riid, void * * ppv) Line 553	C++
 	msenv.dll!CThreadAwareServiceProvider::QueryService(const _GUID & guidService, const _GUID & riid, void * * ppv) Line 342	C++
 	[Managed to Native Transition]	
 	Microsoft.VisualStudio.Shell.Framework.dll!Microsoft.VisualStudio.Shell.ServiceProvider.QueryService(System.Guid guid, System.Type serviceType, bool setShellErrorInfo, out object service) Line 238	C#
 	Microsoft.VisualStudio.Shell.Framework.dll!Microsoft.VisualStudio.Shell.ServiceProvider.QueryService(System.Type serviceType, bool setShellErrorInfo, out object service) Line 144	C#
 	Microsoft.VisualStudio.Shell.Framework.dll!Microsoft.VisualStudio.Shell.ServiceProvider.GetService(System.Type serviceType, bool setShellErrorInfo) Line 110	C#
 	Microsoft.VisualStudio.Shell.15.0.dll!Microsoft.VisualStudio.Shell.Package.GetService(System.Type serviceType) Line 1046	C#
 	Microsoft.VisualStudio.Shell.15.0.dll!Microsoft.VisualStudio.Shell.AsyncPackage.GetService(System.Type serviceType) Line 1196	C#
 	Microsoft.VisualStudio.Shell.15.0.dll!Microsoft.VisualStudio.Shell.Package.GetRegistryRoot() Line 926	C#
 	Microsoft.VisualStudio.Shell.15.0.dll!Microsoft.VisualStudio.Shell.Package.UserLocalDataPath.get() Line 172	C#
 	doki-theme-visualstudio.dll!doki_theme_visualstudio.LocalStorageService.GetAssetDirectory()	Unknown
 	doki-theme-visualstudio.dll!doki_theme_visualstudio.AssetManager.ConstructLocalAssetPath(doki_theme_visualstudio.AssetCategory assetCategory, string assetPath)	Unknown
 	doki-theme-visualstudio.dll!doki_theme_visualstudio.AssetManager.ResolveAssetAsync(doki_theme_visualstudio.AssetCategory assetCategory, string assetPath, string assetSource, System.Func<string, string, System.Threading.Tasks.Task<string>> resolveAsset)	Unknown
 	doki-theme-visualstudio.dll!doki_theme_visualstudio.AssetManager.CachedResolveAsync(doki_theme_visualstudio.AssetCategory assetCategory, string assetPath, string assetSource)	Unknown
 	doki-theme-visualstudio.dll!doki_theme_visualstudio.AssetManager.ResolveAssetUrlAsync(doki_theme_visualstudio.AssetCategory assetCategory, string assetPath)	Unknown
	doki-theme-visualstudio.dll!doki_theme_visualstudio.AssetManager.ResolveAssetUrl.AnonymousMethod__0()	Unknown

To resolve this, please capture UserLocalDataPath once on the UI thread in https://github.com/doki-theme/doki-theme-visualstudio/blob/main/doki-theme-visualstudio/doki_theme_visualstudioPackage.cs#L54, and then pass that through to the components that need it.

When I run Visual Studio with a theme, I'm running into an issue where there is no theme applied on the background of the title in the "tabs" pane. To reproduce, set your tab layout to place tabs on the left or right.

Expected Behavior: I expect the default background color to be applied to the background of the "Tabs" pane title region.

Picture showing problem:

(Shown on Raphtalia theme)

The code in StickerAdornment does not listen to the IWpfTextView Closed event and thus it leaks every WPF text view it attaches due to lambda capture of the StickerAdornment's this pointer and said lambda being rooted by ThemeManager.Instance.DokiThemeChanged.

Should probably get around to re-issuing that asset.

• Also add the screen shot too.

Question 1:
The scrollbar border color doesn't match the theme color, can it be improved?

Question 2:


Tab background color becomes white

Question 3:
All theme background colors and foreground colors are not suitable for markdown file editing and preview.

Windows10
Visual Studio 2022 17.6.5
Doki 88.1.4

All current themes have this problem.

is there any way to fix this issue?

Hello! I'm really loving this extension, specifically the darkness theme, today I was using it in some of my personal projects and found that the text color for the commit message is black and illegible, like in the screenshot below.


I'm not sure what the property change should be but if I find it, I'll post it below. I'm thinking more of a white color or at least the gray color when the text box is empty would be neat.

Hello,

Is it possible to modify existing theme's colors?
The contrast on one of the themes I enjoy using is a bit too high for me and it makes the test difficult to see.
When I try to adjust the background color under tools - options - fonts and colors I change the color to something more suitable for
me, but sadly it doesn't work for me. The original colors stay in place. I imagine I'd have to override the color at the file level?

If not possible I understand, I just didn't find any documentation about how to customize colors so figured I'd ask.

Missing tab highlight in NuGet Package Manager

Default Dark theme

Doki-Theme

I don't know how to properly explain this, but when you Ctrl+Click something in Visual Studio, it will be opened but to the right side of the list of open files.

For this type of open files, the tab color will be dark enough to make the filename unreadable.

Here is an example, where the text "EntityMetadata.cs" is unreadable due to the tab color (if you couldn't find it, is to the left of the Solution Explorer at the top).

I am actually using Visual Studio now. Finna post things that I find that should be consistent.

The theme converter for visual studio has a bunch of nice things in it. Including various UI styling (right now dark themes have light design ui stuff 🤢 ).

Would be nice to take the conversion base and roll with that.

Hi,

first of all i love your Plugin, i just stumbled across it, and saw the the little Avatar of Nagatoro is buggy.
I send u a shot of it so u can see the issue!

Best Regards

Torben-Gullak

Popup window border color does not match theme background color

Windows10
Visual Studio 2022 17.6.5
Doki 88.1.4

All current themes have this problem.

Umm... is there any way to change the wallpaper colour without changing the wallpaper character. I really like the "Nakano Ichika" theme, but it's too light...

Unfortunately, I have problems with the scale of both and they climb out of the eran and get clipped :(
Perhaps this is due to the screen size of 15.6 or its 1080P resolution. If you can fix it it would be great.

I would really like to use some of the themes but your extension is highly outdated so it isn't possible to use them, so please update it. Thank you.

I was wondering if is possible to update the extension to add support for VS 2022.

Hi, I love this themes, but i can't install newly version of visual studio at office,
so... I just want to know, any possible to update for Visual studio 2017 Express in future?

thanks a lot!!

The default output log has fine coloring for dark and light themes.








But the Unreal Engine Log only has a visible color on a light theme. When using a dark theme the text is almost invisible.








I assume this is a theme problem that can be fixed because if I use the dark theme built into Visual Studio the text is fine.

Hi!
First of all, I must say that love this themes for Visual Studio. But after the last update, the stickers just don't look right. Looks with poor quality. I try increasing the zoom, because, changing the zoom, change the looks of the sticker, but have to set the zoom around 266% for the sticker to look good, but when change the font to the minimun size, the sticker gets all broken again.

Add a screen, to show how to look with zoom at 100%

And zoom at 259%

Thanks again for your great work!!! <3 <3 <3

Our Visual Studio performance telemetry has caught an issue where LocalAssetService.HasBeenCheckedToday is entering an infinite loop on the following path. When we caught this issue, it was consuming 6 CPU cores of CPU constantly.

doki-theme-visualstudio.dll!doki_theme_visualstudio.LocalAssetService+<HasAssetChangedAsync>d__.MoveNext
doki-theme-visualstudio.dll!doki_theme_visualstudio.LocalAssetService.IsDifferentFromRemoteAsync
mscorlib.dll!System.Runtime.CompilerServices.AsyncTaskMethodBuilder`[System.Boolean].Start
doki-theme-visualstudio.dll!doki_theme_visualstudio.LocalAssetService+<IsDifferentFromRemoteAsync>d__.MoveNext
doki-theme-visualstudio.dll!doki_theme_visualstudio.LocalAssetService.HasBeenCheckedToday
mscorlib!System.Collections.Generic.Dictionary`[System.__Canon,System.DateTime].FindEntry

This is because LocalAssetService can end up reading and writing to the underlying Dictionary<TKey, TValue> from multiple threads at the same time. This can cause curruption of the internal data structures of the dictionary, causing it to enter infinite loop.

Fix is simple, please replace this dictionary with a ConcurrentDictionary<TKey, TValue>.

It happened two times in a row, they have the visibility check and opacity up, i have to install it back and sometimes doesn't want to work, i'm using Visual Studio Community 2019, i'm not using any custom plugin for themes or backgrounds.

I love this a lot! But i don't know how to fix this problem.

Hope there's a fix to this 👍

Hello! I've found some problems with some themes, particularly the darkness theme and probably other dark themes with blackish background, for example the notifications are almost unreadeable at best, the gif below showcases this issue. I think this is kind of a major problem. I've tried other dark themes for example the Emilia Dark, and it doesn't look that bad in that theme.

Another problem I've found has to do with the status bar, because when building the project it changes color, I think it changes to the default color but I'm not sure. The gif below showcases this issue. I think this is probably a bug, because the Mai Dark theme doesn't have this problem but the Emilia dark does.

Cheers man, I'm really loving this themes!

If you place a window such as powershell underneath the editor, the wallpaper will be cut off.
before

after i added powershell windows underneath the editor

It would be nice if the wallpaper could be uninterrupted, like doki-theme-vscode, and the powershell window could be transparent so that you could see the wallpaper, but I don't know how to make that happen.

To reproduce, make a new wpf project from template, the default view with the XAML tab on the bottom is not themed and very hard to read for light themes.

I learned a lot of stuff building this plugin. Time to document so I can help other not ride the same struggle bus I rode.

i installed the plugin, then uninstalled ClaudiaIDE since i had it, i changed to "Rias Crimson" theme and the colors work, but no sticker or wallpaper even though they are set to "true" in the doki settings, i tried manually linking them by finding the pictures and setting the path manually but that does not seem to work either.

Me setting paths manually:
https://imgur.com/a/aIxlEvg

As described in title. Unable to get it to work on visual studios 2022 professional 17.0. The general theme colours and icons are updated. But the sticker, wallpaper and opacity does not take effect.

It works on Visual Studios 2022 Community version on another machine.
The Professional version is running in offline environment. Did something gets downloaded during the installation of the extension?

I've tried the open new file. It only works for the community version.

If you open a SQL file in Visual Studio, the editor has a black background, which makes it unreadable with light themes. Example with Satsuki Light theme: