GithubHelp home page GithubHelp logo

Comments (3)

Klap-in avatar Klap-in commented on July 20, 2024

With quick look back in the history, I do not see were the ip-addresses were visible. Sure you do not confuse another plugin?

I removed ip-adresses now completely in #333, because it was implemented messy and it mixes with the user-id field.

The data format used for storing the comments is serialized PHP array. The best is to use php functions to open, unserialize, modify the user, serialize and store again.

//some code suggestion based on save() in action.php (NOT TESTED).
$pageid = '....';
// get discussion meta file name
$file = metaFN($pageid, '.comments');
$data = unserialize(io_readFile($file, false));

$cid = '...comment id....';

$data['comments'][$cid]['user']['name'] = ...
$data['comments'][$cid]['user']['mail'] = ...
//etc...

$date = time();
$data['comments'][$cid]['date']['modified'] = $date;
$type = 'ec'; // edit comment

// save the comment metadata file
io_saveFile($file, serialize($data));
//$this->addLogEntry($date, $pageid, $type, '', $cid);

So you recommend still storing regardless privacy considerations.

  • Were should it be accessible? How do you like to use it? Could you help explaining to make it specific?

At the moment the ip-adresses are still stored temporary in the comment-changelog, which hold a number of recent changes. But that changelog is not accessible via the interface so far i know.

from plugin-discussion.

chtiland avatar chtiland commented on July 20, 2024

Hello @Klap-in

I don't confused with another plugin, because that the one I choose on my first installation and never used another one (nor external one).
I think IP was displayed in admin section of discussion, but it was available in 2013 (some old hidden posts I kept) 😄

I care about privacy, but I decided to valid each post in discussions, less spams.
But sometimes, some posts or replies (injuries...) in discussions needs more than just deleting them and that's where IP of author is required (block IP or pursuits).

In fact, it would be nice to have IP only for admin, but, for privacy reason, best way would to keep this IP for "hidden" post and when clicking on "Show", IP can be removed (not more required).

Of course, if this feature is implemented, I would add a specific message to prevent and explain how, when and why their IP will be temporarily stored.

Thanks for tip to modify json, I didn't even think about php serialization... I probably was too tired 😋

About the comment-changelog, where this file is stored ? I found none in my meta folders, only json comments.

Thanks,
Fabrice

from plugin-discussion.

Klap-in avatar Klap-in commented on July 20, 2024

Changelog with number of changes (number of changes kept is set with the recent Configuration setting) is stored in $conf['metadir'].'/_comments.changes'

from plugin-discussion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.