Reply is not shown about plugin-discussion

[pblahman]

Thank you for the suggestion. Yes, I will "try" on my test system first. If nothing "ugly" happens I will do the same on my production system. Why both systems? The test system is PHP 8.2. Production is PHP 7.4.

…

On Thu, Feb 29, 2024 at 1:37 AM tomnbw ***@***.***> wrote: Hello, I'd like to bring to your attention a bug that has emerged after the recent update of the Discussion plugin. Following the update, replies to comments are no longer visible on the page. While these replies can still be seen in the pending comments section for review, they aren't being publicly displayed. This issue has arisen recently and wasn't present in another wiki where the Discussion plugin was installed quite some time ago. Interestingly, after reinstalling the Discussion plugin, the same issue occurred in the other wiki as well. Additionally, I have a small request. Could you kindly consider either removing the ability for regular users to edit, hide, or delete their own comments, or making these permissions optional? Your assistance is greatly appreciated, and I extend my gratitude for your efforts. Best regards — Reply to this email directly, view it on GitHub <#349 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE2PV6DMVCU65LJ3YA5GJZ3YV3NFBAVCNFSM6AAAAABDVFRYLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZQGU3DSMZVHA> . You are receiving this because you commented.Message ID: ***@***.***>

-- *Regards: Phillip Lahman*

[pblahman]

Hmmm... It appears the granularity of permissions for "*edit hide or delete comments*" is not "easy to see or understand" in the "*discussion*" configuration files. I need to look at the discussion source on github to see if there is some sort of "what is going on here" as relates to your suggestion. Here is my configuration file.... <?php /* * Dokuwiki's Main Configuration File - Local Settings * Auto-generated by config plugin * Run for user: phillip * Date: Mon, 26 Feb 2024 18:29:27 +0000 */ $conf['title'] = 'Computer Club Wiki'; $conf['license'] = 'gnufdl'; $conf['recent_days'] = 14; $conf['breadcrumbs'] = 12; $conf['fullpath'] = 1; $conf['tocminheads'] = '2'; $conf['maxtoclevel'] = '5'; $conf['maxseclevel'] = '4'; $conf['sneaky_index'] = 1; $conf['useacl'] = 1; $conf['superuser'] = ***@***.***,Phillip'; $conf['manager'] = ***@***.***'; $conf['disableactions'] = 'register'; $conf['remoteuser'] = 'Phillip'; $conf['cachetime'] = 60*5; $conf['subscribers'] = 1; $conf['notify'] = ***@***.***'; $conf['registernotify'] = ***@***.******@***.***'; $conf['mailfrom'] = ***@***.***'; $conf['mailreturnpath'] = ***@***.***'; $conf['htmlmail'] = 0; $conf['sitemap'] = 1; $conf['rss_linkto'] = 'rev'; $conf['gzip_output'] = 1; $conf['send404'] = 1; $conf['proxy']['user'] = 'phillip'; $conf['proxy']['pass'] = '<b>cGhpbElzUGFyYW5vaWQh'; $conf['plugin']['captcha']['mode'] = 'text'; $conf['plugin']['captcha']['loginprotect'] = '1'; $conf['plugin']['captcha']['lettercount'] = 7; $conf['plugin']['captcha']['width'] = 200; $conf['plugin']['ckgedit']['create_folder'] = 'y'; $conf['plugin']['ckgedit']['scayt_auto'] = 'on'; $conf['plugin']['ckgedit']['alt_toolbar'] = ''; $conf['plugin']['ckgedit']['rel_links'] = 1; $conf['plugin']['discussion']['automatic'] = 1; $conf['plugin']['discussion']['excluded_ns'] = '/(playground)/'; $conf['plugin']['discussion']['urlfield'] = 1; $conf['plugin']['discussion']['addressfield'] = 1; $conf['plugin']['discussion']['adminimport'] = 1; $conf['plugin']['discussion']['newestfirst'] = 1; $conf['plugin']['discussion']['moderate'] = 1; $conf['plugin']['discussion']['userealname'] = 0; $conf['plugin']['discussion']['threads_formposition'] = 'top'; $conf['plugin']['discussion']['visibilityButton'] = 1; $conf['plugin']['discussion']['moderatorgroups'] = ***@***.***'; $conf['plugin']['discussion']['moderatorsnotify'] = 1; $conf['plugin']['groupmail']['default'] = ***@***.***'; $conf['plugin']['groupmail']['allow_email'] = 1; $conf['plugin']['include']['depth'] = 4; $conf['plugin']['move']['allowrename'] = ***@***.***'; $conf['plugin']['pagelist']['showdiff'] = 1; $conf['plugin']['pagelist']['showcomments'] = 1; $conf['plugin']['pagelist']['sort'] = 1; $conf['plugin']['qc']['single_author_only'] = 1; $conf['plugin']['scrape']['allowedre'] = 'https?://*'; $conf['htmlok'] = '1';

…

On Thu, Feb 29, 2024 at 1:37 AM tomnbw ***@***.***> wrote: Hello, I'd like to bring to your attention a bug that has emerged after the recent update of the Discussion plugin. Following the update, replies to comments are no longer visible on the page. While these replies can still be seen in the pending comments section for review, they aren't being publicly displayed. This issue has arisen recently and wasn't present in another wiki where the Discussion plugin was installed quite some time ago. Interestingly, after reinstalling the Discussion plugin, the same issue occurred in the other wiki as well. Additionally, I have a small request. Could you kindly consider either removing the ability for regular users to edit, hide, or delete their own comments, or making these permissions optional? Your assistance is greatly appreciated, and I extend my gratitude for your efforts. Best regards — Reply to this email directly, view it on GitHub <#349 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE2PV6DMVCU65LJ3YA5GJZ3YV3NFBAVCNFSM6AAAAABDVFRYLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZQGU3DSMZVHA> . You are receiving this because you commented.Message ID: ***@***.***>

-- *Regards: Phillip Lahman*

[luffah]

@Basskrapfen there is a simple editing error in action.php:956 .

The condition is inverted.

        if (empty($comment['replies'])) {
            return;
        }

[pblahman]

I also have this issue with PHP 7.4 or PHP 8.2 and Release 2024-02-06a "Kaos". However deprecation log indicates lots of this:
2024-02-25 09:11:12ptln() is deprecated. It was called from admin_plugin_discussion::html() in /home/sctxcompclubora/sctxcompclub.net/lib/plugins/discussion/admin.php:74 echo should be used instead!
I have been "looking" for ptln documentation. Which "might" give me a clue about how to change ptln to echo.

[tomnbw]

Hello,

I'd like to bring to your attention a bug that has emerged after the recent update of the Discussion plugin. Following the update, replies to comments are no longer visible on the page. While these replies can still be seen in the pending comments section for review, they aren't being publicly displayed. This issue has arisen recently and wasn't present in another wiki where the Discussion plugin was installed quite some time ago. Interestingly, after reinstalling the Discussion plugin, the same issue occurred in the other wiki as well.

Additionally, I have a small request. Could you kindly consider either removing the ability for regular users to edit, hide, or delete their own comments, or making these permissions optional? Your assistance is greatly appreciated, and I extend my gratitude for your efforts.

Best regards

[tomnbw]

Hi,

when I reply to a discussion post, the reply is not shown on the page. On the admin (moderation) page, the reply is visible though.

Any ideas how I could fix this?

DokuWiki version is "Jack Jackrum", threads are enabled, installed plugin is "2021-12-31" which is the latest which is available via the extension manager.

I couldn't find any messages/errors in the dokuwiki log file.

Thanks a lot!

Excuse me, have you found a solution to the problem with the report?

[KanenasPL]

Same here.

vs.
https://2051.tepewu.pl/2051:formy_i_narzedzia:pieniadz_i_gospodarka:ekonomia_karmy

[Basskrapfen]

Hi,
when I reply to a discussion post, the reply is not shown on the page. On the admin (moderation) page, the reply is visible though.
Any ideas how I could fix this?
DokuWiki version is "Jack Jackrum", threads are enabled, installed plugin is "2021-12-31" which is the latest which is available via the extension manager.
I couldn't find any messages/errors in the dokuwiki log file.
Thanks a lot!

Excuse me, have you found a solution to the problem with the report?

Sorry, I couldn't find any solution or workaround yet.

[wlfram]

are there any news on this topic?

[sataix]

luffah is right, this immediately fixed the issue on my instance of DokuWiki. For ones who experience the same issue: change action.php:956 from if (!empty($comment['replies'])) to if (empty($comment['replies'])).

[mosely1]

Confirmed this works. Unsure how it will affect future updates to the plugin. I'd make a pull request, but it seems they are not accepted. Simple fix, in case you need it.