GithubHelp home page GithubHelp logo

Comments (4)

FabienLavocat avatar FabienLavocat commented on June 19, 2024

Could you try something like:

if (participant.status === ('CONNECTED' as ParticipantStatus)) {

}

from comms-sdk-react-native.

dannyBies avatar dannyBies commented on June 19, 2024

That would work but you'd loose type-safety that way, as this would be valid.

if (participant.type !== ("NONEXISTENTVALUE" as ParticipantStatus)) {
}

Just for the record, this isn't a big issue for us as we can use the string literal.

if (participant.status === 'CONNECTED') {
}

The issue is that it conflicts with one of our eslint-rules that we have configured https://typescript-eslint.io/rules/no-unsafe-enum-comparison/ .

It also removes some of the type-safety that would normally come with using an enum in our linting setup
image

from comms-sdk-react-native.

graduad avatar graduad commented on June 19, 2024

We are working on this, and we hope to provide a solution in a coming beta version.

from comms-sdk-react-native.

graduad avatar graduad commented on June 19, 2024

Should be fixed in 3.8.1-beta.3 which is released now. Please note that for beta.3 enums and models need to be imported from the models "module". Eg. import { ParticipantStatus } from '@dolbyio/comms-sdk-react-native/models'.

from comms-sdk-react-native.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.