dolbyio / comms-sdk-react-native Goto Github PK

On iOS the leave conference does not work. Not always reproducible.

No Stream or Participant Events are being received when someone shares their screen (sharing screen via a web browser).

Add following events to the notification service:

• conference status

Only Android work. RN and iOS to be done in separate ticket.

The "react-native-comms-sdk.podspec" sepcifies a dependency of s.dependency "VoxeetSDK", '~> 3.7'. This will accept any versions up to but not including 4.0. I think the intention is to lock the React Native and native SDKs' minor versions, but not the patch versions. Thus the correct string will have to be ~> 3.7.0.

Please see: https://guides.cocoapods.org/using/the-podfile.html

Hi

When do you think you will be supporting the Mixed Listener mode to use RTS stream?

Specifically the additional type parameter for the ListenOptions as per the JS SDK.

please read it carefully for react native read it carefully then go for closed and support

Only Android work. RN and iOS to be done in separate ticket.

It has been noticed that when a participant is sharing video from their camera, but then changes to a different video device, several events are being received, with one of the intermediate events containing no video streams. This means that there is a short gap between the old and new video streams.

• #194
• #195
• #196
• #197
• #198

Some Stream Removed events have a blank ID which means we don't know which Stream to remove from the app.

Please see #74

Add following events to the notification service:

• active participants

Only RN and Android work. iOS to be done in separate ticket.

whilst testing #156 I found another issue with the screenshare.

When you join a call as a listener while the call is ongoing and screenshare is on we encountered this error:

Error: Unable set remote SDP for Peer: 70198506-3b32-3efe-aa9b-f80b54200574 :: Failed to set remote offer sdp: Failed to set remote video description send parameters for m-section with mid='screenshare'.
Error: Unable set remote SDP for Peer: 70198506-3b32-3efe-aa9b-f80b54200574 :: Failed to set remote offer sdp: Failed to set remote video description send parameters for m-section with mid='screenshare'.

A couple of conferences where we reproduced this issue:

ID: 259844d3-2271-40de-9435-fcb5afc801b9
Alias: Stage|9fcbfcfa-2933-4010-87dd-04d4609f5970|6410ec1e-aab8-43d7-b16d-920df262c161

ID: 4833935a-e938-4ec8-b037-6600caf1461c
Alias: Stage|9fcbfcfa-2933-4010-87dd-04d4609f5970|43729424-51cd-4feb-a023-9419669fc56f

[!] CocoaPods could not find compatible versions for pod "VoxeetSDK":
In Podfile:
react-native-comms-sdk (from ../comms-sdk-react-native-latest) was resolved to 3.8.0-beta.1, which depends on
VoxeetSDK (~> 3.8.0)

Specs satisfying the VoxeetSDK (~> 3.8.0) dependency were found, but they required a higher minimum deployment target.

If the test app does not contain the ability to show 2 simultaneous screen shares, this needs to be implemented.

Please investigate how it is possible to test two concurrent screen shares.

Add following events to the notification service:

• conference status

Only RN and iOS work. Android to be done in separate ticket.

Please see #76

isOpen returns a Boolean instead of a boolean, the primitive type should always be returned as otherwise you need to call valueOf to unwrap the actual value. This was probably a typo as this seems to be the only instance where Boolean is used instead of boolean.

Current code:

const isOpen = await CommsAPI.session.isOpen();
if (isOpen.valueOf()) {}

Expected code:

const isOpen = await CommsAPI.session.isOpen();
if (isOpen) {}

Use the native (Android and iOS) 3.10 SDKs

I am using the following packages in an Expo managed project:

• "@dolbyio/comms-sdk-react-native": "^3.7.0-beta.1",
• "@millicast/sdk": "^0.1.35",
• "react-native-webrtc": "^106.0.0-beta.7",,

When trying to create an expo - EAS build I get a lot of Duplicate class errors:

I need to use both SDK's in my app, is this supported? If yes, what tweaks to the native code do I need to make to get this working?

Add following events to the notification service:

• active participants

Only iOS work. RN and Android to be done in separate ticket.

Active Participant Event is missing avatarUrl after setting it with SessionService.updateParticipantInfo.

On Participant object returned by Active Participant Event we get an info object which is missing avatarUrl but we can see the set url in other events.

From our testing it looks like it's not included in a response from the backend.
It's possible to reproduce on iOS and Android.

Please see #75

https://github.com/DolbyIO/comms-sdk-react-native/blob/develop/ios/Services/ConferenceService/ConferenceServiceModule.swift#L582

There is no option to set broadcast:false for non replaykit or in app screenshare

Please see #78

Update the Dolby.io React Native SDK to use the 3.8 native SDKs.

Tasks:

• Update the Android part of Dolby.io React Native SDK
• Update the iOS part of Dolby.io React Native SDK

Add a button in join conference screen named audio preview. Also create an empty modal screen which should be launched by the button.

Stopping video sometimes causes us to get Stream Removed, but other times we seem to just get Participant Updated.

Add following events to the notification service:

• participant joined
• participant left

Only Android work. RN and iOS to be done in separate ticket.

Add following events to the notification service:

• conference crated
• conference ended

Only RN and Android work. iOS to be done in separate ticket.

Add following events to the notification service:

• participant joined
• participant left

Only RN and iOS work. Android to be done in separate ticket.

Can anyone share a push notification-related document file? there was a great help to us.

@kdrob-dolby @mhelf-dolby @ppolus-dolby @ppolus-dolby

Network requests do not show up in flipper which makes it difficult to debug issues. I believe this is due to this SDK calling the android/ios specific SDKs to make network requests.

Is there any way to view these requests and responses without going into android/ios specific tooling?

• Expose SessionService.updateParticipantInfo()
• And UI to the test app

When trying to import any enum you get the following error:

This happens for every enum defined in a .d.ts file that you try to import.

Add following events to the notification service:

• conference crated
• conference ended

Only iOS work. RN and Android to be done in separate ticket.

Please see #84

When we add a new listener how we can check or know the new user is came?? so please tell me the way because these two type of notifications are not available in react native if these are available then we can identify using these notifications

With the SDK 3.7 release bundle we need to update the React Native SDK to use the SDK 3.7.

I'm trying to integrate this SDK but am running into an issue when trying to unsubscribe from an event handler.
When I navigate to one of my screens I can successfully view the incoming video. However when going to the previous screen I get an error when calling the UnsubscribeFunction. This results in the event handler functions not being disposed which means if you keep going back and forth between screens you will have multiple event handlers active while there should only be one.

I can consistenly reproduce this with the following code, you don't need to have called any other Dolby function:

useEffect(() => {
    logger.debug("~~~~~~~~ subscribing to onStreamsChange");
    const unsubscribe = CommsAPI.conference.onStreamsChange((data, type) => {
      logger.debug("~~~~~~~~ onStreamsChange", type);
    });

    return () => {
      logger.debug("~~~~~~~~ unsubscribing from onStreamsChange");
      try {
        unsubscribe();
        logger.debug("~~~~~~~~ unsubscribing from onStreamsChange");
      } catch (e) {
        logger.error("~~~~~~~~ error unsubscribing", e);
      }
    };
  }, []);

Note: it happens for any onX handler, not just onStreamsChange

Logs after toggling between screens a few times:

Full logs for completeness sake:

The values in the ParticipantType enum seem to be incorrect.
When I log (await CommsAPI.conference.current()).participants whilst in a conference. I get back the following data:

The enum indicates it is "user" while it should be "USER". I have not verified this but I think this might be the case for some of the other enums as well.

It's also possible to receive the type "UNKNOWN" which should be added to the enum.

Is support for Expo managed flow (via dev client plugins ) in the plans?

We see that the Participant Status changes to LEFT but no Stream Removed event is received.

There are events to listen to in order to get the recording status like RecordingStatusUpdatedEvent on android and similar on other platforms. But React Native SDK doesn't provide a similar callback. Having this callback will enable the developer to show the recording status to the participants.

Only RN and iOS work. Android to be done in separate ticket.