GithubHelp home page GithubHelp logo

Comments (3)

gmaniac avatar gmaniac commented on June 14, 2024

As long as we can maintain previous version I think this might be a cool feature. Let me know if you need help with anything.

from restify-oauth2.

charwking avatar charwking commented on June 14, 2024

After thinking about this some, I don't think utilizing an includeTokenEndpoint options flag is going to be the best approach. The requiredHooks passed to makeSetup are going to change based on whether the flag is there. (i.e. it doesn't make sense to require a grantToken hook if the the user doesn't want the token endpoint setup.) And the code in makeSetup would need multiple new if-checks to handle the includeTokenEndpoint flag.

Instead, I was thinking about adding some new top-level functions to the library:

// Adds logic to authenticate tokens
restifyOAuth2.ccAuthenticator(server, options);

// Adds logic (and endpoint) to grant tokens
restifyOAuth2.ccGrantor(server, options);

// Adds both, just like current version, but uses above two functions to make it happen
restifyOAuth2.cc(server, options);

A similar approach would be taken for ropc. Does this sound okay? Would you like one single PR, or several smaller ones?

from restify-oauth2.

gmaniac avatar gmaniac commented on June 14, 2024

This looks good, a single PR would be fine. Let me know if you have any questions.

from restify-oauth2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.