GithubHelp home page GithubHelp logo

Comments (9)

gmaniac avatar gmaniac commented on June 14, 2024

if your branch is public post a link I will pull down that and give it a look

from restify-oauth2.

awdrius avatar awdrius commented on June 14, 2024

Sure. Here it goes: https://github.com/awdrius/restify-oauth2

from restify-oauth2.

gmaniac avatar gmaniac commented on June 14, 2024

Sorry for the delay.

I am a little confused as to what you are trying to do exactly. Could you give me a use case please?

Could you give an example of your request that you are getting a login dialog box from chrome with?

from restify-oauth2.

awdrius avatar awdrius commented on June 14, 2024

Hey, no worries, we are all busy.

I'm using your library to authenticate API calls from a JS script. I do that automatically upon user entering the website. If auth call fails - Chrome popups a standard login popup to enter username and password. I do not want that as handling failed logins is a part of JS functionality.

The best description of the issue can be read here:
http://stackoverflow.com/questions/86105/how-can-i-supress-the-browsers-authentication-dialog

from restify-oauth2.

gmaniac avatar gmaniac commented on June 14, 2024

I will add this in, I was thinking of adding it as an option like tokenExpiration. When it is left blank it will be false and act as it does now. If you pass true it will prepend X- onto Basic which should suppress the popup.

Let me know what you think.

I was going off of this issue as well: #27

from restify-oauth2.

awdrius avatar awdrius commented on June 14, 2024

Hey, sorry for the late reply, under tons of work to do here.

I haven't investigated the X- suffix cross-browser behavior. It would not surprise me that the auth header forces cred. dialog on Chrome only. I think I noticed that there is a trend towards it from my app log files.

I'll pull the latest changes/fixes on one of the test servers and will let you know how it went.

from restify-oauth2.

awdrius avatar awdrius commented on June 14, 2024

I checked it and X-Basic workaround would work well here. It's up to you how you want to handle it.

Btw, just wanted to thank you guys for creating an easy to use OAuth2 library.

from restify-oauth2.

gmaniac avatar gmaniac commented on June 14, 2024

All the thanks goes to @domenic he created this package, I am just helping maintain.

I am currently working on making this package compatible with restify 4.x I am fixing some tests and then I can add these feature in. Probably be within the next two weeks unless you would like to submit a pull request?

from restify-oauth2.

awdrius avatar awdrius commented on June 14, 2024

I'll see if I can help but I'm not certain I can be that fast (-.

from restify-oauth2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.