dorsetdigital / silverstripe-cdnrewrite Goto Github PK

The code to detect the CMS (taken from the subsites module) currently starts by getting a local config variable for admin paths. This config option doesn't exist in our code, so it's redundant. We just check the url_base in the admin controller.

Remove this redundant code and clean-up.

Currently the admin page detection is fairly crude. The subsites module seems to have a bit more of an elegant solution: https://github.com/silverstripe/silverstripe-subsites/blob/032ea731543c640f009ae364fbc337e3745849f8/src/Middleware/InitStateMiddleware.php#L62

Update the code!

When determining whether a request is in the CMS, the middleware currently reads the AdminRootController.url_base config value directly.

If the admin URL has been changed via Director rules, but the url_base option in AdminRootController hasn't also been set, the getIsAdmin() function will end up with the wrong URL.

AdminRootController::admin_url() is available which checks the Director rules before falling back to the config option. Would this be a better method of checking the admin routes?

When enabled, the module should inject DNS prefetch tags into the head:

eg: <link rel="dns-prefetch" href="//www.domain1.com">

Hi,

In Silverstripe 4.7.0 it's required to wrap strings starting with % in quotes (in the yaml files). See: https://docs.silverstripe.org/en/4/changelogs/4.7.0/#support-for-symfony-4-components

Can you update this in the yaml file?

Hi,
Great module for using a cdn! 1 suggestion:

When a page is still in concept the cdn cannot pull the images yet. So when you view the page in stage mode you miss the images as the url's are already rewritten to the cdn url.

SS4.4 introduced a developer-configurable resources directory, which is going to cause issues with the fixed rewriting currently being used.