dotkernel / dot-controller

DotKernel controller like middleware component

DotKernel 3 Official Documentation Repository

Documentation ( version 1.0 , based on Zend namespace and Zend Expressive )

Roadmap April 2020

TARGET:

• frontend release v 3.x
• admin release v 3.x
• API release v 3.x

NEW APPLICATIONS

• api-mail ? service to send emails only
• PINGU queue system, based on Redis + swoole + Mezzio + deployed as a standalone service

Package versioning:

1. version 1.x related to Zend Framework and Expressive [deprecated]
2. version 2.x related to Mezzio and Laminas, without modification of the flow. No new functions, only compatibility [deprecated]
3. version 3.x related to the new Mezzio and Laminas architecture , in preparation for DK3 version 3

Documentation on each package please !!!!

Requirements for V 3:

• bump require version of PHP to 7.4
• doctrine 2.7.x ( latest)
• twig 3.x (latest)
• update documentation to reflect changes ( readme.md)

How to:

• create the branch 3.0 from 2.0 !!!
• make default branch 3.0 ( not master anymore )
• enjoy

Package list: see the checllist https://github.com/dotkernel/dotkernel/blob/master/checklist-v3-packages.md

dot-controller's Issues

Shouldn't indexAction() be mandatory in `AbstractController` class?

In Dot\Controller\AbstractActionController::dispatch() the index action is the default action. If it doesn't exist next middleware will be called will generate a 404 error.

Dot\Controller\AbstractController::getMethodFromAction() will return indexAction for no action given.

Wouldn't it be better to add the indexAction() method ?

It helps the developer see his middleware was routed.

dot-controller

green badge

https://insight.symfony.com/projects/c4aac671-40d7-4590-b1fa-b3e46a1e3f43

Update url plugin generate method

Update generate method of the url plugin to match the UrlHelper's generate method

Bump to PHP 8.3

Documentation

fix php versions required

must be

"php": "^7.4 || ~8.0.0 || ~8.1.0",

Return type and type hint invalid

Dot\Controller\Factory\ControllerEventListenersInitializer::__invoke(): Argument 2 ($instance)
This must be type "mixed" because as is now (?AbstractController) accept only null and AbstractController but through this pass multiple types.

Dot\Controller\AbstractController::dispatchEvent(string $name, array $data = [], object|string|null $target = null): Dot\Controller\Event\ControllerEvent|Laminas\EventManager\ResponseCollection

The return type of this must be the common class (extended one) "Event" (from dot-event) because in this way you lock the package to be able to use only ControllerEvent from this package.

Codecov actions & badge, psr/http-message bump to 1.1 || ^2.0

Bump to PHP 8.3

PHP 8 compatibility

This component can't be installed with composer on PHP 8.

Code quality

Controllers - missing plugins problem

When forgetting to register a controller in the service manager, Zend Expressive will instantiate the controller using the new. This leads to improper controller setup, as the plugin manager or plugins won't be injected. This is because the controller initializer responsible for that is called only for controllers instantiated via the service manager.

This is all good, but the error message about the invalid controller plugins is misleading as this problem is a cause of the problem described above.

This is worth an improvement if possible, regarding the displayed error, to be less confusing and to point the developer to the actual problem