dove6 / piklib_patcher Goto Github PK

Usage tests have shown that there is no real indicator for users that a fatal error has occurred.

1. The fatal error pop-up provides a "Back" button which closes it. Users can then attempt to use the site normally. Such design has no sense. "Refresh" and "Notify me" buttons should be provided instead.
2. Although no callback is registered in the case of start-up fatal error, the default behavior of input controls may be confusing.
   • "Choose a file" button still opens a file browser and allows for file selection.
   • A drag'n'dropped file is opened by browser using the file:// protocol (tested on Chrome 93.0.4577.82, Firefox 89.0.2). For binary executable files (and other non-displayable file types) this is followed by a file saving dialog. The behavior looks just as if the file has been patched and is ready for downloading. Therefore a pass-through drag'n'drop callback should be registered to prevent the case.

The automatic patcher has ceased working due to Sheets v3 API becoming obsolete on August 2, 2021.
It requires either switching to v4 API or using more professional storage like a database.

Users should be directed to https://github.com/Dove6/PiKlib_patcher/issues/new and https://github.com/Dove6/PiKlib_patcher/fork if they want to report a problem or provide a patch themselves.

E-mail may be left as a backup.

An additional screen with big "Done" and some buttons (like "Patch another library", "Change patch selection") would prove more readable.

Patches data is currently stored as a plain-text JavaScript object. It's smelly as hell and doesn't preserve any information on relations between its compound structures.