dovrosenberg / foundry-simple-weather Goto Github PK

Would be nice to know which weather is coming to say to the player "you see in the distance an dark cloud formation come ..." ;)
So he can prepere and planing routes/rest

I'm finding that when simple weather is active, the area that the weather expansion tab takes up is unusable on the Foundry canvas, even when it's not open. For instance if I have the calendar next to a token, I cannot select the token, or when the calendar is next to the Foundry right tools, I cannot select any buttons, scenes or actors in the space where the weather expansion would be.

After closing SW window via [x], it is closed forever. A button in the note pin menu (left side) would be great (or any other option).

Is your feature request related to a problem? Please describe.

No

Describe the solution you'd like

I'd like it so that when the weather changes, it triggers a FX Master weather effect that matches, if FX Master is detected

Describe alternatives you've considered

I think maybe other modules have it? Otherwise I'd probably setup a macro.

Additional context
Add any other context or screenshots about the feature request here.

If i use smalltime, simple calendar and simple weather in my foundry world, I get the widget for changing time drawn twice, but only one is useable. The simple weather window is shown correctly (I don't use the attached mode right now).

If i have a new world (the other one has PF2e Kingmaker installed), everything seems to be drawn correctly.

Do you have an idea, how to fix the behaviour in our kingmaker world, so it works as intended? The new world works, so it shouldn't be a general problem, but I don't want to move everything over onto a new one :-|
Especially as it seems that it works for my players, but not for me:

• hosted and accessed with Windows 11
• Edge
• Foundry 11.315
• Logged in as a GM in both instances, tested as player on kingmaker with no visible issues

Right now Simple Weather applies FX for weather to all scenes, screwing landing pages, Lock Pan/Zoom image scenes, and more. A per Scene support to turn on and off weather the same SimpleTime can turn on and off time and darkness control on each scene would greatly improve this mod.

Having the date and time a second time open on the screen while working with Simple Calendar is just taking space on the screen.

Somehow, when I was trying to position Simple Weather at the top left of my screen I accidentally hit right click at the same time, and the box shot off to the left at high speed. Moving the canvas as far as it will go in any direction doesn't find it. A button to reset position would be wonderful. I have been unable to reproduce this on my local Foundry, it happened on a Forge hosted system (Dragonbane). I haven't wanted to try to reproduce it on any other game, as then I won't have Simple Weather for those games either! So I'm suffering with Weather Control for now on Dragonbane, but would love Simple Weather back.

OK to reproduce this: Local Foundry, simply right click on the Calendar box. After that all games will not show the Calendar box. Forge hosted, right click while dragging. This will only make it disappear on the game that you did this on.

• OS: Windows 11
• Browser Chrome and Edge
• Version Foundry V11 Build 313

Note: I have tried uninstalling/reinstalling, uninstalling and then pulling my Foundry version into the Forge as a custom module, but no matter what it remembers the position, wherever that is.

Is your feature request related to a problem? Please describe.
Not all localized strings are present in all language files - primarily as a result of new features being added after localization was done.

Describe the solution you'd like
Fully populated files. For simplicity, there is a "missing translations" section at the bottom of each file indicating all of the strings that need to be translated.

Additional context
Would love PR submissions to flesh any of these out. Thanks!

Hi!

First of all, thanks a lot for creating this module. I have been using it a bit and it's great! However, I was wondering if there is a way to switch between Celsius and Fahrenheit units. There may be an option already, but I have not been able to see it.

Thanks!

I would like support for non Fahrenheit temperature.

Describe the bug
JSON needs fixing for version: 1.13.0 -> 1.13.1

Screenshots

Some weather effects are only visible after closing browser tab and reloading foundry

Solution:

Did not wait long enough (took over 3 minutes to change the weather fx) and didn't read the manual beforehand. Sorry! :(

Is your feature request related to a problem? Please describe.
If you close the window (with the "X" button), you currently need to have a bound key to bring it back. That's not really obvious and/or convenient.

Describe the solution you'd like
Instead, have a button on the left side of foundry that reopens the box.

Additional context
Anyone have an opinion on the value here?

When using the new experimental feature to attach SImple Weather to the Simple Calendar window, the following exception is thrown when trying to display the Simple Weather window from the Simple Calendar window.

To Reproduce
Steps to reproduce the behavior:

1. Update to Simple Weather 1.9.0.
2. Activate the "Attach to Simple Calendar" option in the Simple Weather options.
3. Restart Foundry.
4. Open the Simple Calendar window and click on the Simple Weather button.

Expected behavior
No exception should be thrown; the Simple Weather window should appear.

Screenshots
(above)

System info (please complete the following information):

• macos 14.4.1
• Arc 1.37.0 and Edge 121.0.2277.128
• As GM

Foundry Virtual Tabletop: Version 11 Stable, 11.315
Game System: rqg, 3.4.2
Active Modules: 41
Performance Mode: 2

OS: Unknown
Client: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36 Edg/121.0.0.0
GPU: ANGLE (ATI Technologies Inc., AMD Radeon Pro Vega 64 OpenGL Engine, OpenGL 4.1)
Max Texture Size: 16384

Scene: 3000 x 3000 | Grid Size: 100 | Padding Percentage: 0.25
Walls: 42 | Ambient Lights: 6 | Ambient Sounds: 1 | Tiles: 4 | Tokens: 19

Actors: 43 | Items: 24 | Journal Entries: 190 | Rollable Tables: 0 |
Playlists: 8 | Compendium Packs: 84 | Chat Messages: 0

Describe the solution you'd like
It would be helpful in certain systems if the weather could be tied to relevant rules, to automatically bring up rules when the associated weather comes up.

Additional context
Perhaps something like: https://github.com/orangetruth/weather-effects-5e but it should be designed in a modular way (likely using an API, but perhaps it's sufficient to specify a compendium) so that we can support multiple systems and 3rd parties can add support for other systems without needing to bloat this package.

Using either Foundry or Forge to update modules Simple Weather keeps saying it needs to update to 1.13.1, but still installs 1.13.0. At least according to the reported version number.

After experimenting a few times and Simple Weather working great, the dialogue box to generate weather disappeared. I tried uninstalling/reinstalling Simple Weather, toggling Simple Calander, and reloading Foundry (Forge).

Describe the bug
The Grey dialogue box appears as a big rectangle in the upper left corner while Foundry is loading everything, but then it vanishes. It shows no info except for 27C, and then it disappears. (this is on the most recent Foundry V.11/PF2e)

To Reproduce
Steps to reproduce the behavior:

1. Don't know how it started. I was working and then just suddenly disappared.
2. Reload Foundry in Browser
3. See Simple Weather control panel as Foundry is loading assets.
4. Simple Weather disappears when everything else loads

Expected behavior
I was hoping I'm just stupid and there is a button somewhere to turn it back on (like Simple Calander has the toggle for it under Journal Entries/Map Notes)

Screenshots
Can provide if needed, but since there's nothing there, I didn't bother

Desktop (please complete the following information):

• OS: windows 11
• Browser Vivaldi
• Version 6.2.3105.58

Smartphone (please complete the following information):

• N/A

Additional context
Add any other context about the problem here.

In settings the name, description, sub menu button, and climate descriptors are not localized.

Weather descriptions can't be localized as they are hardcoded in /src/weather/climateData.ts

Describe the bug
As the title says by mistake i closed the SW menu on the canvas and now i cant open it on my world, i tried to use different keybinds but nothing worked, no console errors or something like that.

To Reproduce
Steps to reproduce the behavior:

1. Close the SW menu on the canvas
2. Try to open it using a keybind
3. Nothing Happens
4. Disabling and enabling the module does not fix the issue

Foundry Version: 11.315
DnD5e version: 2.3.1
Simple Weather Module Version: 1.7.0

SW is only in English (Window, settings, and chat output). While the rest of the UI is in German.
Tested with no other modules and a new world.

SW 1.11.0 (I think it was already with the previous version, but don't know when it happened).
FoundryVTT 11.315

Describe the bug
The "Sync with Simple Calendar" selection doesn't save between sessions.

To Reproduce
Steps to reproduce the behavior:

1. Choose "Sync with Simple Calendar" option. Assume it is Summer in Simple Calendar
2. F5 your browser or log-out of Foundry Session.
3. Log into a new foundry session - same world.
4. Season symbols are still the same but the dialog box now reads "Summer" rather than Sync with Calendar
5. Advance Simple Calendar to a new season and notice that the season does not change in Simple Weather as it should

Screenshots
Before Refresh or log out-in.

After Refresh or log out-in

Foundry V11 Build 315
The One Ring 2nd edition 3.3.7
I have reproduced the issue in a no-other-module environment, but have not tried with any other game systems.

I appreciate your time and efforts!

It would be nice if weather could be logged in simple calendar (create a note daily for weather).

Describe the bug
Whenever a non-GM joins the game the error notification of incompatible versions with Simple Calendar shows up.

To Reproduce
Steps to reproduce the behavior:

1. Login as non-GM or non-assistant-GM into any foundry game with simple calendar ahead of simple weather

Expected behavior
Only the GM or assistant GM should see system/module errors and or version incompatible warnings.

System info (please complete the following information):

• OS: Windows 10
• Browser: Opera
• Foundry version: 11.315
• Logging in as GM or player?: Player

That can generate the weather linked to custom tables.

Describe the bug
When using core foundry weather effects, if the same weather repeats on consecutive days, it appears to toggle the weather FX rather than leaving them on.

To Reproduce
Steps to reproduce the behavior:

1. Use regenerate button to cycle through weather (I used Spring, Temperate, Verdant)

Expected behavior
FX should stay on until getting to a weather type that requires a change.

Updated SImple Calendar wit hthe new version and getting this message.

Together with Simple Calendar (and eventually Small Time), the screen gets extremely cluttered, especially using Foundry on a small Notebook.

It would be a nice feature to just have a weather icon next to Simple Weather's season and moon-phase icons, that would open the weather configuration. This way you won't need to have two calender apps opened.

Example Screenshot:

There are situations when your player characters need some special treatment like a Snowstorm in summer because there is a ice witch, or a sunny day when the table expects rain. But the players shouldn't see thousands of chat outputs till you get the result you want.

Is your feature request related to a problem? Please describe.
Want to be able to quickly open/close Simple Weather when only displayed UI is Simple Time

Describe the solution you'd like
A new button on ST that toggles a SW panel

I want to open the discussion on seasons.
a) Simple Calendar has Icons for different seasons: You could bind Simple Weather seasons to that icons. That way the GM has only to set it up in SC how they want it. No need to change anything in SW. If you switch your calendar, your seasons switch accordingly if it is setup there.
b) The issue you are describing is already an issue in SC. So if you consider that, you have to change it in SC and SW. If SW is just taking the info from SC, it is one module less to maintain as a GM and you just setup a copy of the calendar with opposite seasons.
c) Maybe adding the option of switching between northern and southern hemisphere?

Simple Weather fails to show configuration options inside of FoundryVTT Application interface.
Also does not show configuration item on main Simple Calendar toolbar (non-compact)

Application:

Chrome WebBrowser:

Desktop (please complete the following information):

• OS: Windows 11
• Browser Chrome Version 118.0.5993.118
• Foundry Version 11 Build 313
• Simple Weather version 1.5.2

Additional context
Add any other context about the problem here.

When resetting for a new session, I like to clear out the chat and archive it, and do other housekeeping to keep the world from getting too bloated. I'd like a way to remind players at the start of a new session what the current day's weather is.

Describe the solution you'd like

A button to re-send the chat card to chat without changing the weather would work. An API call available to macros would be even better.

Describe alternatives you've considered

Current alternatives include just changing the current weather at the start of the new session or whenever we need to be reminded of the weather.

Describe the bug
In certain conditions when going from a weather condition with FX to one without, the weather doesn't properly turn off. This is caused by improper handling of the async deactivateFX()

Expected behavior
Whenever you go from weather with FX to weather without, they FX should turn off.

Sometimes you just need the screen space, so being able to toggle Simple Weather on and off, and set a key binding in Configure Controls would be wonderful.