draco9990 / eso-launcher-closer

Closes the eso launcher lol

ESO-Launcher-Closer

Closes the eso launcher lol

eso-launcher-closer's Issues

"Launcher" is no unique name, why not use the exe filename as unqiue identifier?

Hey there, I'm no C coder but maybe this link here helps you to detect the running processe of eso64.exe and bethesda_Launcher.exe by their filenames instead of the window titles which might change (to e.g. "The Elder Scrolls Online (Not responding)" )

https://stackoverflow.com/questions/20874381/get-a-process-id-in-c-by-name

The solution is to simply set the pe32.dwSize after getting the process snapshot. Complete fixed code here:

DWORD FindProcessId(const char *processname)
{
    HANDLE hProcessSnap;
    PROCESSENTRY32 pe32;
    DWORD result = NULL;

    // Take a snapshot of all processes in the system.
    hProcessSnap = CreateToolhelp32Snapshot(TH32CS_SNAPPROCESS, 0);
    if (INVALID_HANDLE_VALUE == hProcessSnap) return(FALSE);

    pe32.dwSize = sizeof(PROCESSENTRY32); // <----- IMPORTANT

    // Retrieve information about the first process,
    // and exit if unsuccessful
    if (!Process32First(hProcessSnap, &pe32))
    {
        CloseHandle(hProcessSnap);          // clean the snapshot object
        printf("!!! Failed to gather information on system processes! \n");
        return(NULL);
    }

    do
    {
        printf("Checking process %ls\n", pe32.szExeFile);
        if (0 == strcmp(processname, pe32.szExeFile))
        {
            result = pe32.th32ProcessID;
            break;
        }
    } while (Process32Next(hProcessSnap, &pe32));

    CloseHandle(hProcessSnap);

    return result;
}

Maybe more performant than iterating all processes in the system and checking for their window names.