draftcreate / draft-pack-repo Goto Github PK

The Draft pack repository plugin.

License: MIT License

Makefile 11.56% Go 52.89% Shell 30.81% PowerShell 4.73%

draft-pack-repo's Issues

switch to dep

As per the latest release of glide, it would seem that it'd make sense to migrate over to dep as that is starting to be absorbed into the core Go toolchain according to their roadmap.

upload assets to blob store when pushing a tag

See https://github.com/Azure/draft/tree/master/.circleci for an example on how to fix this

get.sh fails on Windows if draft is not in PATH

Due to the lack of error checking, if draft cannot be found, get.sh will try to install the plugin in /plugins/draft-pack-repo, causing draft init to fail:

${DRAFT_PLUGIN_PATH:="$(draft home)/plugins/draft-pack-repo"}

See: https://github.com/Azure/draft-pack-repo/blob/master/scripts/get.sh#L28

caching strategy

Currently we're pulling down and storing the whole git repo. We should consider only pulling down the contents of the packs/ dir of the repository to save some bits.

pack-repo -h output should be redirected

The get.sh script's testVersion function calls pack-repo -h, which writes its usage info to stdout.
While this is definitely not a big issue, it generates some unnecessary noise in the draft init output that could be avoided by redirecting it:

https://github.com/Azure/draft-pack-repo/blob/3425e8855d5ec61cdaa938a92d74d92a35346b10/scripts/get.sh#L125

draft.exe init
Creating C:\Users\Administrator\.draft
Creating C:\Users\Administrator\.draft\plugins
Creating C:\Users\Administrator\.draft\packs
Creating C:\Users\Administrator\.draft\logs
Creating C:\Users\Administrator\.draft\config.toml
Installing default plugins...
Downloading https://azuredraft.blob.core.windows.net/draft/pack-repo-canary-windows-amd64.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 3008k  100 3008k    0     0   667k      0  0:00:04  0:00:04 --:--:--  728k
Preparing to install into C:\Users\Administrator\.draft/plugins/draft-pack-repo
draft-pack-repo installed into C:\Users\Administrator\.draft/plugins/draft-pack-repo/draft-pack-repo
The Draft pack repository plugin.

Usage:
  pack-repo [command]

Available Commands:
  add         add a pack repository
  help        Help about any command
  list        list all installed pack repositories
  remove      remove a pack repository
  update      fetch the newest version of all pack repositories using git.
  version     display version information

Flags:
      --debug   enable verbose output
  -h, --help    help for pack-repo

Use "pack-repo [command] --help" for more information about a command.
Installed plugin: pack-repo
Installation of default plugins complete
Installing default pack repositories...
Installing pack repo from https://github.com/Azure/draft
Installed pack repository C:\Users\Administrator\.draft\packs\github.com\Azure\draft
Installation of default pack repositories complete
$DRAFT_HOME has been configured at C:\Users\Administrator\.draft.
Happy Sailing!

fix `pack-repo add`

currently pack-repo add installs a pack repository from github.com/myorg/myrepo to ~/.draft/packs/myrepo. The pack repository should really be installed at ~/.draft/packs/github.com/myorg/myrepo.

draftcreate / draft-pack-repo Goto Github PK

draft-pack-repo's People

Contributors

Stargazers

Watchers

Forkers

draft-pack-repo's Issues

switch to dep

upload assets to blob store when pushing a tag

get.sh fails on Windows if draft is not in PATH

caching strategy

pack-repo -h output should be redirected

fix `pack-repo add`

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

Jobs