dragon66 / java-image-scaling Goto Github PK

Hi,

Is there a android version for this? nice to have it for android.

Thanks.
Eman

What steps will reproduce the problem?
1. Get to doFilter method ResampleOp - This method calls waitForAllThreads
2. Interrupt the threads

What is the expected output? What do you see instead?
I would expect to only get a RuntimeException. Instead there's also a 
e.printStackTrace() call. This is written outside of the regular log-flow and 
causing the ".out" file (the one I'm using for printing stdout) to fill up 
quickly.

What version of the product are you using? On what operating system?
java-image-scaling-0.85. OS does not seem relevant - I'm running on different 
OSs (linux and mac mostly)

Please provide any additional information below.
All that needs to be done is to delete line 199 in ResampleOp.java. The caller 
is supposed to handle the exception anyway so there's no behavioural change in 
the flow.

What steps will reproduce the problem?
1. Call the getPoint2D or getBounds2D of the ResampleOp

What is the expected output? What do you see instead?
The expected output is the new size of the image and the new location of the 
point

What I see is the size of the source image and the location of the source point

What version of the product are you using? On what operating system?
0.8.5

Here is the fix for AdvancedResizeOp.java

public final Rectangle2D getBounds2D(BufferedImage src) {
    Dimension dstDimension = dimensionConstrain.getDimension(new  Dimension(src.getWidth(),src.getHeight()));
    return new Rectangle(0, 0, dstDimension.width, dstDimension.height);
}

public final Point2D getPoint2D(Point2D srcPt, Point2D dstPt) {
    if (dstPt != null) {
        return dstPt;
    } else {
        Dimension dstDimension = dimensionConstrain.getDimension(new  Dimension(srcPt.x, srcPt.y));
        return new Point2D.Double(dstDimension.width, dstDimension.height);
    }
}

In the maven pom file the link of the LGPL License is pointing to the GPL 
license. This is a MAJOR difference.
The correct link should be:
http://www.gnu.org/licenses/lgpl-3.0.txt

What steps will reproduce the problem?
1.Using photo attached
2.Creating a image using: DimensionConstrain dc
=DimensionConstrain.createMaxDimension(604,604, true);
3.Run test program

What is the expected output? What do you see instead?
expected resized photo but get Exception in thread "main"
java.lang.ArrayIndexOutOfBoundsException: 1924

What version of the product are you using? On what operating system?
0.8.2

Please provide any additional information below.

Request for enhancement.

Product java-image-scaling-0.8.6.jar
Java 7 update 60
OS Ubuntu 14.04 64bits

Hello, did you plan to add the method:
ResampleFilters.valueOf(String name)

and another one to enumerate all the filters

It will be useful for a config panel with some dynamic combos.

Thanks a lot !

Sincerely,
Stéphane.

Using the 0.7.2 release:

java.lang.ArrayIndexOutOfBoundsException: 5
at
com.mortennobel.imagescaling.ResampleOp.verticalFromWorkToDst(ResampleOp.java:31
6)
at com.mortennobel.imagescaling.ResampleOp.doFilter(ResampleOp.java:163)
at
com.mortennobel.imagescaling.AdvancedResizeOp.filter(AdvancedResizeOp.java:81)
at
com.psibt.plantmonitor.graphic.widgets.AnimatedPicture.paintComponent(AnimatedPi
cture.java:180)
at javax.swing.JComponent.paint(JComponent.java:1027)
at javax.swing.JComponent.paintChildren(JComponent.java:864)
at javax.swing.JComponent.paint(JComponent.java:1036)
at javax.swing.JComponent.paintChildren(JComponent.java:864)
at javax.swing.JComponent.paint(JComponent.java:1036)
at javax.swing.JLayeredPane.paint(JLayeredPane.java:564)
at javax.swing.JComponent.paintChildren(JComponent.java:864)
at javax.swing.JComponent.paint(JComponent.java:1036)
at javax.swing.JComponent.paintChildren(JComponent.java:864)
at javax.swing.JComponent.paint(JComponent.java:1036)
at javax.swing.JLayeredPane.paint(JLayeredPane.java:564)
at
net.sourceforge.jruntimedesigner.JRuntimeDesigner.paint(JRuntimeDesigner.java:49
4)
at javax.swing.JComponent.paintChildren(JComponent.java:864)
at javax.swing.JComponent.paint(JComponent.java:1036)
at javax.swing.JViewport.paint(JViewport.java:747)
at javax.swing.JComponent.paintChildren(JComponent.java:864)
at javax.swing.JComponent.paint(JComponent.java:1036)
at javax.swing.JComponent.paintChildren(JComponent.java:864)
at javax.swing.JComponent.paint(JComponent.java:1036)
at javax.swing.JComponent.paintChildren(JComponent.java:864)
at javax.swing.JComponent.paint(JComponent.java:1036)
at javax.swing.JComponent.paintChildren(JComponent.java:864)
at javax.swing.JSplitPane.paintChildren(JSplitPane.java:1030)
at javax.swing.JComponent.paint(JComponent.java:1036)
at javax.swing.JComponent.paintChildren(JComponent.java:864)
at javax.swing.JComponent.paint(JComponent.java:1036)
at javax.swing.JComponent.paintChildren(JComponent.java:864)
at javax.swing.JComponent.paint(JComponent.java:1036)
at javax.swing.JLayeredPane.paint(JLayeredPane.java:564)
at javax.swing.JComponent.paintChildren(JComponent.java:864)
at javax.swing.JComponent.paintToOffscreen(JComponent.java:5129)
at
javax.swing.BufferStrategyPaintManager.paint(BufferStrategyPaintManager.java:277
)
at javax.swing.RepaintManager.paint(RepaintManager.java:1217)
at javax.swing.JComponent.paint(JComponent.java:1013)
at java.awt.GraphicsCallback$PaintCallback.run(GraphicsCallback.java:21)
at sun.awt.SunGraphicsCallback.runOneComponent(SunGraphicsCallback.java:60)
at sun.awt.SunGraphicsCallback.runComponents(SunGraphicsCallback.java:97)
at java.awt.Container.paint(Container.java:1780)
at javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:814)
at javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:714)
at javax.swing.RepaintManager.seqPaintDirtyRegions(RepaintManager.java:694)
at
javax.swing.SystemEventQueueUtilities$ComponentWorkRequest.run(SystemEventQueueU
tilities.java:128)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:597)
at
java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269
)
at
java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
at
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174
)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

The layout I am scaling has about 50 pictures. Its size is 1920 x 1200.
When zooming out under 60%, this exception is thrown. The code I use is:

private BufferedImage originalImage;
private ResampleOp resampleOp; 

resampleOp = new ResampleOp(scaledImageWidth, scaledImageHeight);
resampleOp.setUnsharpenMask(AdvancedResizeOp.UnsharpenMask.Normal);
rescaledImage = resampleOp.filter(originalImage, null);
g.drawImage(rescaledImage, 0, 0, null);
g.dispose();

The toByte(float f) method chops off the fractional part of the float,
rather than rounding, which leads to slight color discrepancies. Rescaling
a pure white image with lanczos or bicubic hi freq results in slightly off
white colors, due to (for instance) 254.999997 becoming 254 rather than 255.

What steps will reproduce the problem?
1. Just implement a ProgressListener and print out the values of fraction

What is the expected output? What do you see instead?
Expected Output: 0.0 to 1.0, I see values up to about 191.

What version of the product are you using? On what operating system?
Version 0.8.1 (jar), resizing Images of about 4000x2500

Please provide any additional information below.
Code:
BufferedImage img = ImageIO.read(file);
ResampleOp resizeOp = new
ResampleOp(DimensionConstrain.createMaxDimension(300, 300, true));
if (pl != null) resizeOp.addProgressListener(pl);
BufferedImage thumb = resizeOp.filter(img, null);

And in the ProgressListener implementation:
public void notifyProgress(float progress) {
      System.out.println("Progress: " + progress);
}

What steps will reproduce the problem?
1. Take image of size 6000x4000.
2. Create thumbnail of size 704x397.

What is the expected output? What do you see instead?
Based on aspect ratio, it should create 596x397, instead it stretches the image 
and create image of sizw 704x397

What version of the product are you using? On what operating system?
Windows 8, JDK 1.7.0_40-b43, java-image-scaling 0.8.5

Please provide any additional information below.
-

error scale or png format

[deleted issue]

I forked the project worked a little on the code, specifically:

* The ant task is now extended to automatically download the depending library 
and offer a unit test task

* The RescaleOP operation got refactored/cleaned up: method&variable names that 
are easier to understand, reduced the total LoC and applying some techniques 
for better readability.

* The Progress system in the main task should be less error prone and easier to 
read.

* I clean out some code quality problems (like mixed indentation and unused 
imports)

Maybe you are interested to take over some of the changes?

https://github.com/martinheidegger/java-image-scaling

Below is the code that i use:

Double rescaledWidth = 400.00;
Double rescaledHeight= 450.00;

File scaledFile = new File(path + "/" + fileNamePrefix +"_"+ key);
ResampleOp resampleOp = new ResampleOp (rescaledWidth,rescaledHeight);
resampleOp.setUnsharpenMask(UnsharpenMask.Normal);
BufferedImage rescaledImage = resampleOp.filter(origBufferedImage, null);
ImageIO.write(rescaledImage, fileExt, scaledFile);

and i have attached an image which comes out as negetive, let me know if it is 
a problem with the way i use your api or it is a bug in the api.

Thanks for the quick response earlier.

Pratap

What steps will reproduce the problem?
1. Create a Maven project in Netbeans or Eclipse
2. Attempt to find this library in Maven repos

What is the expected output? What do you see instead?
Given that Maven is gaining in popularity, and its support is quite mature
in all major IDEs by now, it would be nice if this library was available there.

What version of the product are you using? On what operating system?
I'm using Mac OS X Leopard

Please provide any additional information below.

Hi,

I am currently using the api to resize the images. It doesn't work well for
only one type of image(Images goes black). I am attaching the resize code
and image. 

Can anyone let me know if i miss something.

Image URL 

http://picasaweb.google.com/lh/photo/Yq3xmQM4PjDqzQUocwI43A?feat=directlink

What steps will reproduce the problem?
1. Make a grayscale image called test.png with dimensions 160x120
2. Run the following code:

public static void main(String[] args) throws IOException {
    final int scale = 2;
    final String testFile = "test.png";

    BufferedImage srcImg = ImageIO.read(new File(testFile));

    final int SRC_W = srcImg.getWidth();
    final int SRC_H = srcImg.getHeight();

    final int DST_W = SRC_W * scale;
    final int DST_H = SRC_H * scale;

    ResampleOp box = new ResampleOp(SRC_W, SRC_H);
    box.setFilter(ResampleFilters.getBoxFilter());
    box.setNumberOfThreads(1);

    ResampleOp tri = new ResampleOp(SRC_W, SRC_H);
    tri.setFilter(ResampleFilters.getTriangleFilter());
    tri.setNumberOfThreads(1);

    BufferedImage boxImg = box.doFilter(srcImg, null, DST_W, DST_H);
    BufferedImage triImg = tri.doFilter(srcImg, null, DST_W, DST_H);

    ImageIO.write(boxImg, "png", new File("boxImg.png"));
    ImageIO.write(triImg, "png", new File("triImg.png"));
}

3. Compare the boxImg.png and triImg.png images in an editor

_Additional test_
1. Open test.png in Gimp image editor
2. Under Image menu, select Scale Image
3. Set Width and Height percent to 200%
4. Set Interpolation to Linear
5. Finish scaling
6. Compare the Gimp scaled image to triImg.png

What is the expected output? What do you see instead?
Expected to see interpolated pixels centered where original pixels were 
located, like Gimp does.
Instead it appears the image is shifted to the top left a fraction of a pixel.

What version of the product are you using? On what operating system?
Java Image Scaling 0.8.5

Windows XP SP 3
Java 1.6.0_12; Java HotSpot(TM) Client VM 11.2-b01

Please provide any additional information below.
Changing ResampleOp.java line 225 from
    float center= i / scale;
to 
    float center= i / scale - 0.25;
seems to fix the offset when scaled at 2x.

— What steps will reproduce the problem?
1. Load the image attached to this issue to BufferedImage object 'bi'.
2. Create ResampleOp 'resampleOp' instance with 120x90 dimensions
3. Invoke resampleOp.filter(bi, null);


— What is the expected output? What do you see instead?
I expect to get a reference to another BufferedImage. Instead I'm getting an 
error:
java.lang.ArrayIndexOutOfBoundsException: 851
    at com.mortennobel.imagescaling.ImageUtils.ints2bytes(ImageUtils.java:177)
    at com.mortennobel.imagescaling.ImageUtils.getPixelsBGR(ImageUtils.java:121)
    at com.mortennobel.imagescaling.ResampleOp.horizontallyFromSrcToWorkGray(ResampleOp.java:456)
    at com.mortennobel.imagescaling.ResampleOp.horizontallyFromSrcToWork(ResampleOp.java:396)
    at com.mortennobel.imagescaling.ResampleOp.doFilter(ResampleOp.java:152)
    at com.mortennobel.imagescaling.AdvancedResizeOp.filter(AdvancedResizeOp.java:81)
    at com.farpost.imagestorage.processing.functions.ImageResizerTest.test(ImageResizerTest.java:106)
(comment: the width of the image is 850)

Here is a detailed test I used to reproduce the problem: 
https://gist.github.com/antonlogvinenko/33f567656ff18abf4b49#file-gistfile1-java
-L14
The error is on line 19.  Line 14 is where I'm trying to change the color model 
to make this test pass (this helps).

I did a bit of debugging: ResampleOp.horizontallyFromSrcToWorkGray method 
allocates the byte[] array of the same size as the int[], but then it invokes 
ImageUtils.getPixelsBGR where the type of image is determined as 
TYPE_USHORT_GRAY, then ints2bytes is invoked (default branch of case) and it 
treats byte[] array as if it was 4 times bigger than it is — mapping each one 
int to 4 bytes, but the arrays have same size, 850, which obviously leads to an 
error.

What version of the product are you using? On what operating system?
0.8.5, test running on OS X, server running same code on Cent OS

What steps will reproduce the problem?
1.I want to rescale icon with rounded corners (with alpha chanel). This 
rescaled image will be placed on some bacground with the same color as image 
(sse screen shots). Problem is that after rescaling I can see some corners. How 
to avoid it?

What is the expected output? What do you see instead?
I want to see rescaled image with rounded corners with constant color.

What version of the product are you using? On what operating system?
Latest jar. Windows 7.

I have a question about image scaling which I hope is easy to answer... I think 
I am missing an obvious detail.

If I have an image of size 850x1100 pixels, and want to scale it to 136x176 -- 
no problem, just .16 of the original size in both dimensions.  The downscaled 
image fits nicely in its new dimensions.

But if I scale my 850x1100 image so that the downscaled width is 186, then I am 
downscaling by .218823529, and the height should be 240.705882px.  If I round 
up to 241 or down to 240 to do my scaling with ResampleOp, I will slightly 
distort my image.

If I could use the float value for scaling, there will be a frayed edge along 
the bottom, but I could choose to trim those if I wanted -- this is a trade-off.

Can I do proportional scaling with your library?

Hi,

first of all, I would like to thank you for the effort you have done to
create a library which, in my eyes, is missing within Java: resizing images
and having a decent result as outcome. Great work!

However, when trying the library, I get messages saying that the resize is
still working and that it is over 100%. This seems a bit odd :-) If I don't
terminate the program myself, it keeps on running. My code is attached.

I'm using Linux Ubuntu (although this should not matter) and Suns JDK
1.6.0.16. Version of java-image-scaling is 0.8.1.

Getting messages like:
Still working - 450,250580 percent 
Still working - 450,278381 percent 
Still working - 450,306213 percent 
Still working - 450,334076 percent 
Still working - 450,361908 percent 

Kind regards,

Frederik

What steps will reproduce the problem?
1. Download the following image and try resizing it:
http://www.dirnat.no/multimedia.ap?id=718
The result can be seen here:
http://www.dirnat.no/multimedia.ap?id=718&width=590&height=590

What is the expected output? What do you see instead?
Should be a normal scaled image, but the colors get all twisted and weird
like the previous png bug you fixed on Dec 27 2009

What version of the product are you using? On what operating system?
Using version 0.8.4 on windows (all platforms)

Please provide any additional information below.
Tested the resizing in the online version
(http://www.nobel-joergensen.com/java/projects/easizer/) and it fails to
resize the image. Nothing is produced

Only a small part of all jhlabs filters and supporting classes is used in
this project. Why not integrate it directly instead of having to include
another large jar? Additionally this will open the door for further
refinement of the existing code in terms of performance.

What steps will reproduce the problem?
1.Use resampleOp.setUnsharpenMask(AdvancedResizeOp.UnsharpenMask.Normal);

What is the expected output? What do you see instead?
I see: java.lang.NoClassDefFoundError: com/jhlabs/image/UnsharpFilter

What version of the product are you using? On what operating system?
0.8.3

Please provide any additional information below.

Hi,

Would it be possible to deploy the latest 0.8.6 towards mvn central?
http://mvnrepository.com/artifact/com.mortennobel/java-image-scaling

Kindly,
Bart

Maybe i missed something but shouldnt the "Thump" be "Thumb" :)

What steps will reproduce the problem?
1. Scale a image less than 3 pixels in any direction

What is the expected output? What do you see instead?
Throws a ArrayIndexOutOfBounds

Please use labels and text to provide additional information.

Using the 0.7 release,

java.lang.ArrayIndexOutOfBoundsException: 8436
  at
com.mortennobel.imagescaling.ResampleOp.createSubSampling(ResampleOp.java:240)
  at com.mortennobel.imagescaling.ResampleOp.doFilter(ResampleOp.java:133)
  at
com.mortennobel.imagescaling.AdvancedResizeOp.filter(AdvancedResizeOp.java:69)

The image I'm scaling is 1367x888.  The code I'm using is roughly,

  int WIDTH_THUMBNAIL = 57;
  DimensionConstrain dimThumb
    = DimensionConstrain.createMaxDimension(WIDTH_THUMBNAIL,
                                            (int)(WIDTH_THUMBNAIL/1.5));
  BufferedImage image = ImageIO.read(data);
  ResampleOp resampleOp = new ResampleOp(dimThumb);
  resampleOp.setFilter(ResampleFilters.getLanczos3Filter());
  BufferedImage rescaled = resampleOp.filter(image, null);

What steps will reproduce the problem?
1. Using a box filter should only read every channel value once for. But
there exist some cases where the value if read 0 or 2 times.
This may improve the quality of the scaling slightly.

Please can you let me know the maven repository URL for this?

Thanks
C 

What steps will reproduce the problem?
1. not depending if a pic is 300x100px or 100x300px
2. I want to create a pic with eg. 300x300px or 60x60px
3. filling the rest of the background with white (or transparent) color

What is the expected output? What do you see instead?

I expect the output to be a square pic. what I get is a pic with the format of 
a pic that I input (input300x100px output: 150x50px expected 150x150px)

What version of the product are you using? On what operating system?

0.8.5

Please provide any additional information below.

There is a private default constructor and no other protected or public 
constructors. If I wanted to design another DimensionConstrain I have to edit 
the library source.

Attached is a draft of a servlet implementation that can handle image 
resizing. It is working but I'm still working on a caching mechanism that 
would prevent the recreation of the thumbnails

I've used the latest svn version

What steps will reproduce the problem?
1. Scale image (See attached image)
2. Image is rotated 90 degrees after rescaling

What is the expected output? What do you see instead?
Not rotated

I assume that it is related to some exif information that contains rotation - 
which is not being copied.

What steps will reproduce the problem?
1. scale the attached file to any size (e.g. 50x50), using ResampleOp

What is the expected output? What do you see instead?

I always get the following exception with this particular file, other files
work perfectly:

java.lang.ArrayIndexOutOfBoundsException: 150
    at
com.mortennobel.imagescaling.ResampleOp.horizontallyFromSrcToWork(ResampleOp.jav
a:380)
    at com.mortennobel.imagescaling.ResampleOp.doFilter(ResampleOp.java:144)
    at
com.mortennobel.imagescaling.AdvancedResizeOp.filter(AdvancedResizeOp.java:81)

What version of the product are you using? On what operating system?

latest 0.8.1, on both Windows & Linux.

Please provide any additional information below.

I think it has got something to do with the number of channels and this
particular image, but I cannot figure out what the problem is.

Please help me with this one!

What steps will reproduce the problem?
1. resampleOp.setUnsharpenMask(AdvancedResizeOp.UnsharpenMask...
2. resampleOp.filter...


What is the expected output? What do you see instead?

Expected: No Expection. Instead: java.lang.NoClassDefFoundError: 
com/jhlabs/image/UnsharpFilter


What version of the product are you using? On what operating system?

0.8.5, Windows 7

Please provide any additional information below.

Apparently the UnsharpFilter is missing in the java-image-scaling-0.8.5.jar

When upscaling a very small image an ArrayIndexOutOfBoundsException is thrown:

Exception in thread "Thread-7" java.lang.ArrayIndexOutOfBoundsException: 2
    at com.mortennobel.imagescaling.ResampleOp.verticalFromWorkToDst(ResampleOp.java:335)
    at com.mortennobel.imagescaling.ResampleOp.access$2(ResampleOp.java:311)
    at com.mortennobel.imagescaling.ResampleOp$2.run(ResampleOp.java:164)
    at java.lang.Thread.run(Thread.java:680)