GithubHelp home page GithubHelp logo

freshsales's People

Contributors

lacostej avatar nfedyashev avatar

Stargazers

avatar avatar avatar avatar avatar

Watchers

avatar avatar

Forkers

lacostej nfedyashev tscung brunto

freshsales's Issues

Add rspecs

Look at the Pending tests to implement. Currently

Pending:
  Freshsales::Client making requests GETs hashes with symbolized keys
    # Not yet implemented
    # ./spec/freshsales/client_spec.rb:52
  Freshsales::Client making requests GETs hashes with non symbolized keys
    # Not yet implemented
    # ./spec/freshsales/client_spec.rb:53
  Freshsales::Client making requests POSTs string body
    # Not yet implemented
    # ./spec/freshsales/client_spec.rb:55
  Freshsales::Client making requests POSTs Hash body
    # Not yet implemented
    # ./spec/freshsales/client_spec.rb:56
  Freshsales::Client making requests PUTs string body
    # Not yet implemented
    # ./spec/freshsales/client_spec.rb:58
  Freshsales::Client making requests PUTs Hash body
    # Not yet implemented
    # ./spec/freshsales/client_spec.rb:59
  Freshsales::Client making requests DELETEs
    # Not yet implemented
    # ./spec/freshsales/client_spec.rb:61
  Freshsales::Client making requests converts errors
    # Not yet implemented
    # ./spec/freshsales/client_spec.rb:63
  Freshsales::Cursor#each enumerates when no block given
    # Not yet implemented
    # ./spec/freshsales/cursor_spec.rb:27
  Freshsales::Cursor#each enumerates with blocks
    # Not yet implemented
    # ./spec/freshsales/cursor_spec.rb:28
  Freshsales::RequestBuilder pagination enumerates pages with #get_all_pages
    # Not yet implemented
    # ./spec/freshsales/request_builder_spec.rb:40
  Freshsales::RequestBuilder pagination enumerates elements with #get_all
    # Not yet implemented
    # ./spec/freshsales/request_builder_spec.rb:41

Clean pagination API

I am not very fond of the names for the two methods.
Also I would like to make sure they can support more features such as from / to page numbers

Increase compatibility with newer ruby version

Issue Description

/Users/lacostej/Code/WWTK/Backend/freshsales_mailchimp_syncer/.bundle/ruby/3.2.0/gems/freshsales-0.0.6/lib/freshsales/client.rb:45:in `freshsales_request': wrong number of arguments (given 3, expected 2) (ArgumentError)
	from /Users/lacostej/Code/WWTK/Backend/freshsales_mailchimp_syncer/.bundle/ruby/3.2.0/gems/freshsales-0.0.6/lib/freshsales/client.rb:10:in `httprequest'
	from /Users/lacostej/Code/WWTK/Backend/freshsales_mailchimp_syncer/.bundle/ruby/3.2.0/gems/freshsales-0.0.6/lib/freshsales/request_builder.rb:23:in `method_missing'
	from freshsales_dump_data.rb:32:in `dump_entities_from_view'
	from freshsales_dump_data.rb:67:in `<main>'

/Users/lacostej/Code/WWTK/Backend/freshsales_mailchimp_syncer/.bundle/ruby/3.2.0/gems/freshsales-0.0.6/lib/freshsales/cursor.rb:35:in `new': tried to create Proc object without a block (ArgumentError)
	from /Users/lacostej/Code/WWTK/Backend/freshsales_mailchimp_syncer/.bundle/ruby/3.2.0/gems/freshsales-0.0.6/lib/freshsales/cursor.rb:35:in `each'
	from freshsales_dump_data.rb:36:in `dump_entities_from_view'
	from freshsales_dump_data.rb:67:in `<main>'

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.