draylar / go-fish

Fishing enhancement mod with new equipment, fish, and special loot!

Go Fish 🎣

Go Fish is a fishing enhancement mod for Fabric. It takes inspiration from Stardew Valley and Terraria to create a rewarding fishing experience with exciting new loot, creative aquatic creatures, and an incentive to enjoy fishing.

Feature Overview

---

🐟 New fun Fish variants - find themed aquatic creatures in all biomes while fishing! 🦈

🎣 New Fishing Rods and fishing trinkets ⌚

🥔 Creative food options based around aquatic ingredients 🧂

💎 Rare loot crates with exciting loot 🔮

🔥 Nether and End fishing, with dimension-specific fishing mechanics 🐠

---

Go Fish can be found on CurseForge here, and is currently available for versions 1.16.2+. Forge is not supported, and will not be supported in the future.

For more information about the mod, visit the wiki.

go-fish's Issues

missing items: charfish, seaweed eel, matrix rod, and eye of fishing

Hi,

I got everything except charfish, seaweed eel, matrix rod, and eye of fishing. Can someone clarify if they are attainable and give a little clue how?

Thanks!

UDP russian translation 1.18

go-fish-1.4.0-1.18.zip

Go-Fish conflicts with Polymorph, causing crash on startup.

Here's the crash report.
crash-2021-05-09_23.03.11-client.txt

Latest log file:
latest.log

[suggestion] Wiki/Information about the mod

so... i know your stance on fishing, i know im supposed to be able to fish in the nether and the end and it has unique mechanics...
but thats about it.
what do the different rods do? blaze rod is presumably the only one that can fish in lava, and diamond presumably just has higher durability, but what about the matrix? the eye of fishing? any of the others?
how do i fish in the end? water doesnt seem to work with any of the rods.
what drops can i even get aside from the fish i can see in rei? i havent really gotten much of note in my creative testing.

Config to change crate's drop rates and item drops

There isn't a lot of config and some things are not compatible with other mods and some could benefit from other mods.

We could begin with crates by a kind-of in-depth config on each crate and what they can drop, the chances of each item, and what can come out of the crates.

do the rods have better shances

Do different rods have better chances at stuff

Rods dont support Rod enchantments

none of the fishing rods from the mod seem to support enchantments other than unbreaking and mending, even the mods own enchantment, deepfry.

End fishing

is end fishing implemented yet if so how do i do it?

Fish Entity Enhancement

Could you add fish entities to the Overworld and End? (not against adding them to the Nether but it's not as necessary since you can't really see through lava like water anyways) I think having them visible in the water would help people know if they are fishing in the right place and would help immersion.

Advancements

Potential advancements for Go Fish:

• Getting new rods
• Catching all Nether Fish
• Catching ALL Fish
• Fishing in Lava
• Catching 10/100/1000 fish
• Breaking a fishing line
• Finding any lure
• Opening a crate
• Making a Go Fish food item out of a fish

Fish mobs?

Does this mod add any fish mobs? I can't find any new fish swimming around and I'm not sure if it's a conflict with one of my many other mods or if they just don't exist.

Differences between Golden and Simple Lure

The difference between the Golden Lure and Simple Lure?
I'm not great at reading Java and searching through the Source.
Is there a difference between the Lure and the Golden Lure?

Can't open crates

The tooltip says to shift-click to open a crate. I've tried the following with wooden crates and iron crates to no avail:

• Left Click in inventory.
• Right Click in inventory.
• Shift + Left Click in inventory.
• Shift + Right Click in inventory.
• Left Click placed block.
• Right Click placed block.
• Shift + Left Click placed block.
• Shift + Right Click placed block.
• Left Click from belt.
• Right Click from belt.
• Shift + Left Click from belt.
• Shift + Right Click from belt.
• Mine placed block with pickaxe.
• Mine placed block with axe.

Config to change where fish are fished

Simple, some mods add new biomes and you cant catch the new fish in those biomes.

deep fry enchantment doesnt work

title has problem in it

Cant fish any biome specific mobs in the nether

We have just started using this fishing mod on a server and we cant find anything like soul crates or soul salmon even though we are in the correct biome, /fish works but why would we use that? whats the point of even getting fishing rods? We have the better nether mod so that could be the case, we also havent tried fishing for any biome specific items in the overworld yet so that may not work either.

Levelz incompatability?

https://paste.ee/p/O4rSW

Shifft + click on crate is broken

1.17.1
Latest GoFish
Fabric

Shift + clicking on a crate does not do anything. I've tried with crate on hotbar, in inventory (it adds the item to inventory from hot/action bar, and visa versa)

Maybe due to incompatibility with inventory sort or Item Scroller?

Snowball Fish should be throwable

Frosted rod and celestial rod are held backwards

The player holds the frosted rod and the celestial rod backwards when compared to the vanilla fishing rod and all of the other fishing rods in the mod. The line and hook face the wrong way.

Expected behaviour: They would face the same way as the vanilla fishing rod.

Crate

I can't open the crate i've try shift+click but nothing happen

Switching between fishing rods doesn't reel in the line

You can cast the line with one fishing line, then switch to another one in the hotbar, and the line stays cast. One would expect that fishing rods wouldn't share a line in this manner. This applies to all nine Go Fish fishing rods and the vanilla one.

Cry, pain and fishburger without fish ;c

Referring to #30

Crash at launch reports:
Fabric API 0.34.2 + CC 2.8.2 = https://pastebin.com/fU4YUeSJ
Fabric API 0.34.2 + CC 2.8.0 = https://pastebin.pl/view/709e71ec
Fabric API 0.34.1 + CC 2.8.2 = https://pastebin.com/SSVe47tN
Fabric API 0.34.0 + CC 2.8.2 = https://pastebin.com/AU74EcBJ
Fabric API 0.33.1 + CC 2.8.2 = https://pastebin.com/MN2tzK2W
Fabric API 0.33.1 + CC 2.8.1 = https://pastebin.com/E8tCE8Vj
Fabric API 0.33.1 + CC 2.8.0 = https://pastebin.com/MVMC3XFN

How to build?

I have forked this project and introduced some additions, however I am unable to compile using "./gradlew build", neither my fork nor your original source code compile. Because of this i am unable to test my additions.

Can’t fish ahy

Crates

I’ve pulled two crates from fishing and can’t figure out how to open them. It says shift right click but it just doesn’t do anything.

Go fish don't work

I have a fabric modpack for minecraft 1.16.5, and this mod crashes, please help
Link: https://gist.githubusercontent.com/natanfudge/f1c83503a55fd7ac58da4ec339138007/raw/1102befe5054c753a6f5346a6aaa52b88507c089/crash.txt

Mod Compatibility?

does this mod work with oh the biomes with youll go?

I can't fish in the nether anymore

when i try to fish in the nether with the blaze rod it doesn't i have been waiting for a few minutes and nothing is getting the rod and i have lure 3 and luck of the sea 3 on it and when i use it in the overworld it works almost as soon as i use it

Biome gotcha

This is probably more of something to document than to fix.

I was trying to fish in a plains biome to check out the Supply Crates and there was a river nearby, so I started fishing but got no Plains specific fish and also no supply crates.
So I swam to where the bobber was and using F3 saw that it was actually in a river biome and looking into the code, it seems the origin position used to determine the biome is where the bobber is.

In other words: It doesn't seem to matter where you/the player is located at, only where the bobber is and rivers seem like an easy trap to walk into when using this mod, as you won't be able to catch what you might expect.

It might be possible to 'fix' (if you can call it that) the code by considering the player position as well (maybe by combining the loot pools if that's possible?) or using it instead of the bobber position, which would it consistent with what the F3 screen tells you (and it's also how Terraria works).

But again, maybe documenting this is enough?
I do wonder though if I ever saw a pond in a plains biome big enough for fishing treasures - if not that'd mean the player is forced to create open water (5x4x5) by themselves.

Deepfry enchant doesn't work?

Fish still come raw from what I can tell

Astral Crate and Shaders

Is there a way to make Go Fish compatible with shaders? Apparently when enabling shaders they conflict with the Astral Crate rendering it invisible (I guess because they change the End portal texture).

Crates do not drop items on mining anymore

Discord/Wiki

The wiki leaves much to be desired by way of learning or understanding the mod and what it adds to the game. (For instance it doesn't even mention how to fish in lava, or any quirks/features of items.)

My suggestion is to have a community discord, even if it's for all your mods in one place, or have someone update the wiki properly.
Very much similar to the request below for another mod of yours.
Draylar/identity/issues/219

How can I open crates? Because shift click doesn't work

Or there is something wrong with my files or I misunderstood how to open them?

Fish do not give saturation

Fishing rods not working

When im on a server using this mod, everytime i try use a fishing rod the lure gets launched but then disappears instantly, why is this happening as it works fine on singleplayer until i put this mod on my multiplayer world.

Need to correct the description in CurseForge, about Lure.

How to use lure?
There isn't a correct description in CurseForge or in-game item tooltip. "+1 Lure(or Luck if Soul Lure) When kept in inventory" is completely MISLEADING. I saw your source code. It should be like the following:

int lure = EnchantmentHelper.getLure(heldStack) + bonusLuck + bonusLure; int lots = EnchantmentHelper.getLuckOfTheSea(heldStack) + bonusLuck + bonusLuck;

and the "heldStack" is:

ItemStack heldStack = user.getStackInHand(hand);
Therefore, you must hold it in off-hand or main-hand to let this function realize because "inventory" includes armor slots, Hotbar slots, and off-hand slot.

Server (GoFish 1.4.1 for MC 1.18.1) - ClassNotFoundException

Hi,

I installed the Go Fish mod on my server and encountered two errors. They don't crash the server as far as I know but not sure if it can come to that at a later point. I am a bit rusty on my programming and I have no experience with modding via fabric.

These errors are from the logs when I start the server
[main/WARN]: Error loading class: net/minecraft/class_906 (java.lang.ClassNotFoundException: net/minecraft/class_906) [main/WARN]: @Mixin target net.minecraft.class_906 was not found go-fish.mixins.json:FishingBobberEntityRendererMixin [main/WARN]: Error loading class: net/minecraft/class_702 (java.lang.ClassNotFoundException: net/minecraft/class_702) [main/WARN]: @Mixin target net.minecraft.class_702 was not found go-fish.mixins.json:ParticleManagerMixin

From what I gather there just seems to be a problem that the server is trying to load two classes that should only be loaded on the client for rendering purposes. Just a guess from me.

Whats the minimum to catch rare fish and whats the difference between each of the rods

i just wanna know because i can only seem to catch cod even with a diamond rod

Update To 1.17

Any further plans to update to 1.17? Or will the mod still function on 1.17 and work the same?

Can I add into existing saves?

(asking because there are no cuseforge comments or a discord to ask in)

Chance to get crates and or fish?

The wiki and just overall things about this mod doesn't really say much at all, I have a room under my house where I built a pond with fish and a dock. I've stood and casted line after line over and over again and haven't gotten a single crate or new fish.
Does it have to be open water/lava/void or how does it work?

No chance on receiving Gilded Blackstone Crate.

Been Fishing for around an hour and cannot obtain the Gilded Blackstone Crate.
I've been fishing in the Basalt Deltas Biome in the Nether and been using a Luck of the Sea 3 Diamond rod and still have not received the crate despite meeting the requirements.
I believe there's a compatibility issue with Biome Makeover.

I placed a crate and can't pick it back up or open it.

I placed a crate and can't pick it back up or open it. It's on the ground, just a block, on the ground. I've tried a diamond pickaxe and when it broke, nothing dropped. What do I do?

no guide or anything

there is no guide to the go fish mod and the only way I have gotten any modded was either nether fishing or the /fish command.
please make a guide book or actually make a wiki or just a small guide

Added items from the mod dont show up. (Mod is installed on a Server)

Not sure if this mod is able to be run on a server. But It does register the catch. As I received the achievement for catching an iron crate. Although the achievement did lack the image of the crate and everything was in command brackets. The thing is, Although I got the achievement I did not get the item in question. So that makes be believe its missing in the server item library.

It could be the fact that I miss a certain mod that helps new items to get correctly implemented on the server. If that is the issue of the problem I would like to know what mod helps to have new items from other mods get correctly implemented.

If its not the case I hope that this mod would be soon made compatible with servers. Because its a really fun fishing mod.

Questions about Vanilla Enchantments + Suggestion

Hello there! I was using your mod for the past 2 weeks and I enjoyed it a lot, but I have a question: Why doesn't the enchantments "Luck of the sea" and "Lure" apply on the mod fishing rods? Is it because of the items that already give those stats?

Biome specific fish and crates unable to be obtained without /fish command?

I've been using the mod on a server with friends and I have been unable to obtain the biome specific crates/fish without using the /fish command. Everything else works fine, it's only the swamp, ice, and soul sand valley fish/crates (which I think are the only biome specific ones) that seem to be unobtainable.

Fishing rod texture doesn't change when line is cast

The vanilla fishing rod uses a different texture when the fishing line is cast that lacks the line. Go Fish fishing rods do not do this, and so they have two visible lines, one on the texture and one in the world, when used. This applies to all nine Go Fish fishing rods.