GithubHelp home page GithubHelp logo

drdesten / drdestens_mcshader Goto Github PK

View Code? Open in Web Editor NEW
36.0 2.0 3.0 8.93 MB

A high performace gameplay-oriented shader. Very configurable.

GLSL 100.00%
minecraft minecraft-shaders minecraft-shaderspack glsl-shader opengl

drdestens_mcshader's Introduction

DrDestens MinecraftShaders

Supports versions 1.8.x to 1.18.x (I usually develop on 1.8.9 and 1.16.5)

labPBR and OldPBR/SeusPBR support

  • Supports Normals, Roughness, Reflectance, Emission, AO, Hardcoded Metals, Subsurface Scattering, Height (LabPBR)
  • Supports Normals, Roughness, Emission, Metalness, Height (OldPBR/SeusPBR)

Images:

Full Feature List:

  • Screen Space Reflections
  • Depth of Field
    • Chromatic Aberration
  • Screen Space Ambient Occlusion
  • Temporal Anti-Aliasing
  • Parallax Occlusion Mapping
  • Physically Based Rendering
    • Normals
    • Roughness
    • Reflectance
    • Emission
    • Ambient Occlusion
    • Metals
    • Subsurface Scattering
    • Height
  • Various Water Effects
    • Waves and Bump
    • Refraction
    • Absorption
  • Godrays
  • Bloom
  • Waving Blocks
  • Motion Blur
  • Chromatic Aberration
  • World Curvature
  • Custom Sky
  • Outline
  • Custom Fog
  • White World
  • Saturation and Contrast
  • Multiple Tonemapping operators

drdestens_mcshader's People

Contributors

drdesten avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

drdestens_mcshader's Issues

water buggy & end sky buggy

You've probably seen much of this water issue and you've addressed it as a mac/intel issue, but I have an AMD Radeon RX 6600M graphics card. I have the latest optifine (1.18.2) and the latest shaderpack installed.

Second, I haven't seen other people bring up this one- my end sky is completely blown out. When I try to adjust the sky color settings in "atmospheric" settings, the sky gets buggy.

2022-03-24_23 46 18
2022-03-24_23 47 46

I really love everything about this shaderpack and these two bugs are really the only things holding me back from using it. I hope you can figure them out!

This isn't an issue, i just didn't know how to contact you lol.

Hi, so this isn't a report of an issue or anything like that, i just didn't know how to contact you.

I would like to use your chromatic aberration for one of my projects.
Also, i love your shaders, it's incredible how your shader improved so much with the time.

Anyways, bye :)

TAA breaks the render of transparent blocks

Hey again,
i was expirementing on removing the "black dotted grid effect" of AO shadows, and found out that TAA does just the right work.
but after some time - about 1-3 min, it broke the render, it seems it breaks the render of transparent blocks that has smaller hit box then soild block (beds, pots, chest, water, etc..)
adding a video with & without TAA: https://youtu.be/mdRi-Lz4FXk
This render issue come and goes randomly.. (it doesnt happends in 1.4 tho)

Once again I'm using MC 1.17 Fabric client, using OptiFine_1.17.1_HD_U_G9_1 (with optifabric-1.12.6).
Version: 1.5.3.
CPU: ryzen 2700X.
GPU: RTX 2060.
Adding my current settings of the shaders:

#Mon Dec 13 12:35:20 IST 2021
SSAO_QUALITY=3
WATER_TEXTURE_VISIBLE=true
DIRECTIONAL_LIGHTMAP=true
WORLD_CURVE=true
PBR_BLEND=0.65
SUNSET_FOG_AMOUNT=10.0
TORCHLIGHT_EXTRA_BRIGHTNESS=1.75
WATER_NORMALS_AMOUNT=0.9
BLOOM_AMOUNT=0.10
HARDCODED_METALS=false
DOF_STRENGTH=0.5
SSAO_STRENGTH=1.00
DOF_DITHER=true
MOTION_BLUR_STRENGTH=0.00
GODRAY_STRENGTH=0.30
CONTRAST=-10
HEIGHT_AO=true
REFRACTION_AMOUNT=0.1
SSR_DEPTH_TOLERANCE=1.5
CHROMATIC_ABERRATION=10
EXPOSURE=0.55
DOF_DOWNSAMPLING=0.2
FOG=2
PHYSICALLY_BASED=true
WATER_NORMALS_SIZE=1.0
BLOOM=false
GODRAY_STEPS=15
DOF_MODE=3
GODRAY_SIZE=0.44
DOF_CHROMATIC_ABERRATION=4
PBR_FORMAT=2
TAA=true
WORLD_CURVE_RADIUS=2048
DOF_MAXSIZE=0.005
FOG_AMOUNT=0.2
MOTION_BLUR_SAMPLES=1
SATURATION=68

TAA possibly causing multiple issues.

I have this issue where my blocks on screen kind of moves side to side along with mobs appearing and disappearing, after resetting my optifine and shader settings then reenabling TAA the issue persists but only sometimes. Another issue I have is that rainbow lines appear on obsidian type blocks when I turn Tone mapping to unreal while TAA is enabled.

(I can't seem to replicate the first issue after restarting my game so it might have just been a one-off issue with my game)
-Note I have mods installed so they might just be causing rendering issues for this shader specifically, but I had no issue with any other shaders.
2022-11-12_14 30 10

end sky buggy line

I thought it's abnormal that the end's sky looks like this:
2023-04-09_16 55 56
minecraft version is 1.19.4 and I use the latest sodium, iris and this shader.

Water glitching out.

Hi, I just downloaded your shader and I am very impressed with how it looks and performs but for some reason the water is glitching out. Is ther a way to fix this or maybe just turn the water effects off? Thanks, -Rusted_Cognition

2021-09-04_14 24 27
2021-09-04_14 24 04
2021-09-04_14 22 54
2021-09-04_14 23 05
2021-09-04_14 23 51
2021-09-04_14 24 01

[1.12.2] All blocks turn white with this shader

I'm trying to use this shaderpack in a zombie apocalypse modpack but when I apply the shader the world becomes like this even if "white world" is turned off (all settings are the default values)

Here are the mods that I'm using, in case it is a issue with one of them

Water glitches out and renders black surroundings

Whenever i swim in water in the sweet spot where i can swim fast and not consume oxygen, and also when i swim up a water column (like those that you often find in caves) my surroundings render black and i see only a sliver of what i should be able to see...

I'm rocking a r5 5600x and an rx 6600 with 32gb of ram, 8 allocated to mc, drivers are up to date. I'll attach screenshots of the glitch/bug, of the resource packs/mods i'm using and the settings i currently have for ur shader. Have a great day dude!!

P.S.: other than this and the next issue i'll send ur shader pack is awesome! Keep it up man!! :D

2023-03-25_15 31 18_6
swimming in water glitch
2023-03-25_15 27 07
swimming in water column glitch
Screenshot 2023-03-25 152247
resource packs
Screenshot 2023-03-25 152420
mods
DrDestens+MinecraftShaders+v1.5.7.zip.txt
settings

Certain dark red blocks, items and entities render black when using TAA

Some red blocks, items and entities render these black ink-like splotches on them, and this makes the nether unplayable with TAA enabled... Hope u can do sum about that pal! Have a great day!

I'm rocking a r5 5600x and an rx 6600 with 32gb of ram, 8 allocated to mc, drivers are up to date. I'll attach screenshots of the glitch/bug and of the resource packs/mods i'm using, as i did with the other issue (just to be sure yk). These are all the affected items i could find, there could be a couple more that i didn't catch.

Other than this issue ur TAA is amazing bro, so much better than the one many mid-range shaders comparable to yours have!! Keep up the good work fam!

2023-03-25_16 27 58
this is the glitch (more or less evident on certain items)
Screenshot 2023-03-25 162713
these items are glitched whenever placed and walked by, some of them (ex: redstone dust) glitch even while holding em
Screenshot 2023-03-25 162726
these items and their particles get gliched whenever zoomed in with mods (ex: Zoomify) (note: the witch spawn egg ITEM glitches when dropped on the ground, while the spider egg itself doesent glitch: it's the SPAWNED SPIDER'S eyes that render incorrectly when zoomed upon)
Screenshot 2023-03-25 162636
the glitch happened with these items and entities a couple of times but it's been sporadic and hard to replicate so far
Screenshot 2023-03-25 152247
resource packs
Screenshot 2023-03-25 152420
mods
DrDestens+MinecraftShaders+v1.5.7.zip.txt
settings

Add setting for cozier lights

I really like this shader, though I have one feature request. Lights emit large amount of light, to the point where torchlight is visible at noon and even makes this sheep "glow":

With bloom:
Glowing sheep with bloom

Without bloom:
Glowing sheep without bloom

In both cases the intensity remains the same. Could you make a setting to make lights "cozier", where light sources such as torches give off more subtle lighting?

BetterNether mob Firefly not rendering correctly

Fireflies from the BetterNether mod have this "glow" which gets broken by these shaders. The glow becomes a black opaque circle.
It shouldn't be too complicated to fix this type of an issue right? Would be lovely if this could get a fix soon as BetterNether is also such a popular mod. Thanks in advance.

This is what they look with the McShader:
2023-05-31_03 04 08

And this is what they're supposed to look like:
2023-05-31_03 05 38

Support with distance horrizon lod mod

Now with latest iris and distance horrizon the shader pack is indeed working and not glitching horribly (like older iris versions) but the colors of generated chunks is brighter..
I know its not yours to handle as its a mod but i did ask iris and their answer was that it can be fixed in the shaders itself by changing the render to match..

If u can do that i will be glad!

1.5.2 light is overblown?

Hey. im here to report that it seems like the overall light is overblown,
i mean, in old version the lighting seems fine,
while in night it looked fairly dark, and there was a need in tourches to see better:
[1.4 image]
https://prnt.sc/22qfcbl
[1.5.2 image]
https://prnt.sc/22qfhok
well EVRYTHING is bright - even dark areas, it looked like as day - with moon and darker sky?

Some more comparsion: (note - it the same time in both pictures)
1.4 - https://prnt.sc/22qfvhp
1.5.2(HIGH) - https://prnt.sc/22qfxrh
1.5.2(MED) - https://prnt.sc/22qg24a
1.5.2(LOW) - https://prnt.sc/22qg051

For both version(1.4 / 1.5.2) I'm using MC 1.17 Fabric client, using OptiFine_1.17.1_HD_U_G9_1 (with optifabric-1.12.6) with the same optifine settings! (the 1.4 pictures is with the HIGH preset).
CPU: ryzen 2700X.
GPU: RTX 2060.

I really like the shaders as they maintain the "vanilla feel" but with extra fx and lighting improvemnet, and i fell in love with the 1.4 version, but it would be great if it could be fixed as i do want the new features of the 1.5 vesrion.

If you need more data let me know!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.