GithubHelp home page GithubHelp logo

dreamdevil00 / ftp-client Goto Github PK

View Code? Open in Web Editor NEW
3.0 3.0 3.0 2.17 MB

A simple ftp client using Electron CoreUI

TypeScript 74.89% JavaScript 18.43% HTML 5.59% CSS 1.09%
angular electron ftp-client

ftp-client's People

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar

ftp-client's Issues

Optional parameter should behave as if was omitted when supplied with undefined or null

For example, in the method list,
both path and useCompression are optional, but when I invoke the method by
ftp.list(void (0), true, ()=> {}) , it fetches the list of directory 'undefined', instead, I
think that it should fetch the current working directory list.

I met this problem when I use typescript, since the param callback is the last one and is
necessary, I couldn't find a better way to handle it. If I place the callback in the first,
then it breaks the node-style callback
This is my code

readdir(directory?: any, useCompression?: any,
    callback?: (err: Error | null, list?: any[]) => void) {
    this.getConnection((err, ftp) => {
      if (err) {
        return callback && callback(err);
      }
      if (ftp) {
        ftp.listSafe(directory, useCompression, (error: Error, list: Ftp.ListingElement[]) => {
          if (error) {
            return  callback && callback(error);
          }
          if (typeof list === 'undefined') {
            return;
          }
          const files = [];
          for (let i = 0; i < list.length; i++) {
            const file = list[i];
            if (file.name === '.' || file.name === '..') {
              continue;
            }
            let path = directory;
            if (path.substr(-1) !== '/') {
              path += '/';
            }
            files.push({
              size: file.size,
              filename: file.name,
              isDirectory: file.type === 'd',
              path: path + file.name,
            });
          }
          return callback && callback(null, files);
        });
      }
    });
  }

If I invoke it by readdir(true, ()=> {}) It fetched the directory undefined

How can I solve this problem?

Please help me, thanks a lot

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.