dresden-weekly / vagrant-ansible-remote Goto Github PK

I've put some crude changes for working with CentOS and current Ansible to this gist. This should be okay for quick testing here and now. But it's not good enough for a PR. And honestly said I would prefer to drop git-install.sh at all. The EPEL-/ppa-packages seem to be very up-to-date.

The previous way of installing Ansible with git does not work with the current version. Some considerations:

Until Vagrant 1.8.x the content of the VERSION file matched the version number in the respective branch name (1.8.4 -> release1.8.4). Currently (with version 1.9.0) there is only one stable-1.9 branch but several sub-versions. For each of these sub-versions (or sub-sub-versions) there is a tag and the respective commit has a VERSION-file with equivalent content as follows:

So we could replace the --branch release$ANSIBLE_VERSION with something like --branch v$ANSIBLE_VERSION to install that version and at a later run compare it like [ "$(<${ANSIBLE_DIR}/VERSION)" != "${ANSIBLE_VERSION/-/ }" ]. But what really sucks is:

set +e
source ${ANSIBLE_DIR}/hacking/env-setup
set -e

which seems to fail more or less regularly.

With pip installs it would not work to compare a version (or only for minor versions - pip show ansible | grep -E "^Version: " | grep -Eo "[0-9.]+" yields 1.9).

Currently this script only supports Git und Apt installations.

It would be nice to have the option to use PIP. Which should be a bit more platform independent.

See #2 as well.

The git installation uses --branch release$ANSIBLE_VERSION which is not supported by the official ansible repository.

We should make this prefix optional. The VERSION file content and git tags/branches do not fully match.