dropwizard / logback-throttling-appender

Throttling (async) appender for Logback

Dropwizard

Dropwizard is a sneaky way of making fast Java web applications.

It's a little bit of opinionated glue code which bangs together a set of libraries which have historically not sucked:

• Jetty for HTTP servin'.
• Jersey for REST modelin'.
• Jackson for JSON parsin' and generatin'.
• Logback for loggin'.
• Hibernate Validator for validatin'.
• Metrics for figurin' out what your application is doin' in production.
• JDBI and Hibernate for databasin'.
• Liquibase for migratin'.

Read more at dropwizard.io.

Want to contribute to Dropwizard?

Before working on the code, if you plan to contribute changes, please read the following CONTRIBUTING document.

Need help or found an issue?

When reporting an issue through the issue tracker on GitHub or sending an email to the Dropwizard User Google Group mailing list, please use the following guidelines:

• Check existing issues to see if it has been addressed already
• The version of Dropwizard you are using
• A short description of the issue you are experiencing and the expected outcome
• Description of how someone else can reproduce the problem
• Paste error output or logs in your issue or in a Gist. If pasting them in the GitHub issue, wrap it in three backticks: ``` so that it renders nicely
• Write a unit test to show the issue!

Sponsors

Dropwizard is generously supported by some companies with licenses and free accounts for their products.

JetBrains

JetBrains supports our open source project by sponsoring some All Products Packs within their Free Open Source License program.

logback-throttling-appender's Issues

Shading?

Hej Dropwizard team!

I'm currently looking into an issue in our open source project sda-dropwizard-commons. I'm not yet sure what the problem is but would like to understand your component a little better:

I saw that you create an "uber Jar" by shading several dependencies into your artifact. Most dependencies seem to be relocated in this process but not all.

Why did you keep the package "javax.annotation" as it is but relocate the others? The package contains some of the classes of JSR305. Why don't you use Findbugs' JSR305 implementation?

Why do you need shading at all? I couldn't tell exactly why you need the classes since you don't need them in your imports.

For background information:
We use a "duplicate classes" test in our project that detects duplicate classes in different artifacts. It compains about classes like CheckForNull which we pull in from different sources.

Thanks for getting more information!

Cheers,

Christopher

Shade configuration causes issues with other shaded applications

The shade configuration for this library excludes Google's j2objc-annotations from relocations, which causes conflicts when applications that use the shade plugin attempt to include both this library and j2objc-annotations in the uber jar. I'm more than willing to tweak the pom and submit a PR, but I want to understand why this choice was made before I go make any changes.

One possible fix would be to exclude the libraries from the shaded logback-throttling-appender jar that are not relocated and allow normal Maven dependency management to pull in the requisite dependencies. Another would be to only include the things in the shaded jar that absolutely need to be shaded, or if there is no pressing reason to shade at all, to simply build a standard, unshaded library instead.

Thanks!

[WARNING] j2objc-annotations-1.3.jar, logback-throttling-appender-1.1.2.jar define 1 overlapping classes: 
[WARNING]   - com.google.j2objc.annotations.RetainedWith
[WARNING] maven-shade-plugin has detected that some class files are
[WARNING] present in two or more JARs. When this happens, only one
[WARNING] single version of the class is copied to the uber jar.
[WARNING] Usually this is not harmful and you can skip these warnings,
[WARNING] otherwise try to manually exclude artifacts based on
[WARNING] mvn dependency:tree -Ddetail=true and the above output.
[WARNING] See http://maven.apache.org/plugins/maven-shade-plugin/

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• Update logback.version to v1.5.3 (1.2.x) (minor) (ch.qos.logback:logback-classic, ch.qos.logback:logback-core)
• Update logback.version to v1.5.3 (1.3.x) (minor) (ch.qos.logback:logback-classic, ch.qos.logback:logback-core)
• Update logback.version to v1.5.3 (1.4.x) (minor) (ch.qos.logback:logback-classic, ch.qos.logback:logback-core)

Detected dependencies

Branch 1.2.x

github-actions

.github/workflows/build.yml

• actions/checkout v4@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-java v4@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9
• actions/cache v4@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9

.github/workflows/release.yml

• actions/checkout v4@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-java v4@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9

maven

pom.xml

• org.junit:junit-bom 5.10.2
• ch.qos.logback:logback-core 1.2.13
• com.google.guava:guava 33.1.0-jre
• org.assertj:assertj-core 3.25.3
• ch.qos.logback:logback-classic 1.2.13
• org.apache.maven.plugins:maven-compiler-plugin 3.13.0
• org.apache.maven.plugins:maven-surefire-plugin 3.2.5
• org.apache.maven.plugins:maven-enforcer-plugin 3.4.1
• org.apache.maven.plugins:maven-source-plugin 3.3.0
• org.apache.maven.plugins:maven-javadoc-plugin 3.6.3
• org.apache.maven.plugins:maven-release-plugin 3.0.1
• org.apache.maven.plugins:maven-clean-plugin 3.3.2
• org.apache.maven.plugins:maven-install-plugin 3.1.1
• org.apache.maven.plugins:maven-jar-plugin 3.3.0
• org.apache.maven.plugins:maven-shade-plugin 3.5.2
• org.apache.maven.plugins:maven-gpg-plugin 3.2.1
• org.sonatype.plugins:nexus-staging-maven-plugin 1.6.13
• org.jacoco:jacoco-maven-plugin 0.8.11
• org.eluder.coveralls:coveralls-maven-plugin 4.3.0
• org.sonarsource.scanner.maven:sonar-maven-plugin 3.11.0.3922
• com.google.errorprone:error_prone_core 2.26.1
• com.uber.nullaway:nullaway 0.10.24

maven-wrapper

.mvn/wrapper/maven-wrapper.properties

• maven 3.9.6

Branch 1.3.x

github-actions

.github/workflows/build.yml

• actions/checkout v4@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-java v4@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9
• actions/cache v4@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9

.github/workflows/release.yml

• actions/checkout v4@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-java v4@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9

maven

pom.xml

• org.junit:junit-bom 5.10.2
• ch.qos.logback:logback-core 1.3.14
• com.google.guava:guava 33.1.0-jre
• org.assertj:assertj-core 3.25.3
• ch.qos.logback:logback-classic 1.3.14
• org.apache.maven.plugins:maven-compiler-plugin 3.13.0
• org.apache.maven.plugins:maven-surefire-plugin 3.2.5
• org.apache.maven.plugins:maven-enforcer-plugin 3.4.1
• org.apache.maven.plugins:maven-source-plugin 3.3.0
• org.apache.maven.plugins:maven-javadoc-plugin 3.6.3
• org.apache.maven.plugins:maven-release-plugin 3.0.1
• org.apache.maven.plugins:maven-clean-plugin 3.3.2
• org.apache.maven.plugins:maven-install-plugin 3.1.1
• org.apache.maven.plugins:maven-jar-plugin 3.3.0
• org.apache.maven.plugins:maven-shade-plugin 3.5.2
• org.apache.maven.plugins:maven-gpg-plugin 3.2.1
• org.sonatype.plugins:nexus-staging-maven-plugin 1.6.13
• org.jacoco:jacoco-maven-plugin 0.8.11
• org.eluder.coveralls:coveralls-maven-plugin 4.3.0
• org.sonarsource.scanner.maven:sonar-maven-plugin 3.11.0.3922
• com.google.errorprone:error_prone_core 2.26.1
• com.uber.nullaway:nullaway 0.10.24

maven-wrapper

.mvn/wrapper/maven-wrapper.properties

• maven 3.9.6

Branch 1.4.x

github-actions

.github/workflows/build.yml

• actions/checkout v4@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-java v4@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9
• actions/cache v4@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9

.github/workflows/release.yml

• actions/checkout v4@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-java v4@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9

maven

pom.xml

• org.junit:junit-bom 5.10.2
• ch.qos.logback:logback-core 1.4.14
• com.google.guava:guava 33.1.0-jre
• org.assertj:assertj-core 3.25.3
• ch.qos.logback:logback-classic 1.4.14
• org.apache.maven.plugins:maven-compiler-plugin 3.13.0
• org.apache.maven.plugins:maven-surefire-plugin 3.2.5
• org.apache.maven.plugins:maven-enforcer-plugin 3.4.1
• org.apache.maven.plugins:maven-source-plugin 3.3.0
• org.apache.maven.plugins:maven-javadoc-plugin 3.6.3
• org.apache.maven.plugins:maven-release-plugin 3.0.1
• org.apache.maven.plugins:maven-clean-plugin 3.3.2
• org.apache.maven.plugins:maven-install-plugin 3.1.1
• org.apache.maven.plugins:maven-jar-plugin 3.3.0
• org.apache.maven.plugins:maven-shade-plugin 3.5.2
• org.apache.maven.plugins:maven-gpg-plugin 3.2.1
• org.sonatype.plugins:nexus-staging-maven-plugin 1.6.13
• org.jacoco:jacoco-maven-plugin 0.8.11
• org.eluder.coveralls:coveralls-maven-plugin 4.3.0
• org.sonarsource.scanner.maven:sonar-maven-plugin 3.11.0.3922
• com.google.errorprone:error_prone_core 2.26.1
• com.uber.nullaway:nullaway 0.10.24

maven-wrapper

.mvn/wrapper/maven-wrapper.properties

• maven 3.9.6

Branch 1.5.x

github-actions

.github/workflows/build.yml

• actions/checkout v4@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-java v4@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9
• actions/cache v4@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9

.github/workflows/release.yml

• actions/checkout v4@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-java v4@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9

maven

pom.xml

• org.junit:junit-bom 5.10.2
• ch.qos.logback:logback-core 1.5.3
• com.google.guava:guava 33.1.0-jre
• org.assertj:assertj-core 3.25.3
• ch.qos.logback:logback-classic 1.5.3
• org.apache.maven.plugins:maven-compiler-plugin 3.13.0
• org.apache.maven.plugins:maven-surefire-plugin 3.2.5
• org.apache.maven.plugins:maven-enforcer-plugin 3.4.1
• org.apache.maven.plugins:maven-source-plugin 3.3.0
• org.apache.maven.plugins:maven-javadoc-plugin 3.6.3
• org.apache.maven.plugins:maven-release-plugin 3.0.1
• org.apache.maven.plugins:maven-clean-plugin 3.3.2
• org.apache.maven.plugins:maven-install-plugin 3.1.1
• org.apache.maven.plugins:maven-jar-plugin 3.3.0
• org.apache.maven.plugins:maven-shade-plugin 3.5.2
• org.apache.maven.plugins:maven-gpg-plugin 3.2.1
• org.sonatype.plugins:nexus-staging-maven-plugin 1.6.13
• org.jacoco:jacoco-maven-plugin 0.8.11
• org.eluder.coveralls:coveralls-maven-plugin 4.3.0
• org.sonarsource.scanner.maven:sonar-maven-plugin 3.11.0.3922
• com.google.errorprone:error_prone_core 2.26.1
• com.uber.nullaway:nullaway 0.10.24

maven-wrapper

.mvn/wrapper/maven-wrapper.properties

• maven 3.9.6

---

• Check this box to trigger a request for Renovate to run again on this repository