druids / developers-chamber Goto Github PK

This one is wrong

Sometimes it can be helpful if isort QA check does not clean the repo, because often you want to commit these changes. This new option should provide this.

Also change stashing to proper cleaning.

For example, when running Docker Compose, CTRL+C should forward directly to Docker Compose, i.e. first press should initiate soft shutdown and second should do hard shutdown etc..

If, for some reason, translation files are not exposed outside of container, the "missing translations check" passes with OK result, even though changes were introduced into the file (but the file is not visible on a host). Discover a way, how this check can verify if it really can see the newly generated translation file. Suggestion:

• check that modification time of the translation file is newer than command invocation time

Currently, to generate translations, the command must be issued by hand with flags pydev run-dj makemessages -l=cs --no-location. It would be nice if a shorcut command would exist, like pydev makemessages. It would be a nice counterpart to pydev makemigrations imho.

• unsused imports (probably need to check all code, not only changes)
• invalid test method names (test_should_ is forbidden) (implemented in #66)

Different commands don't remove disposable containers (such as pydev run-dj shell)

$ docker ps -a
...
a28805073e5d   73e5e8f8198d                    "wait_for_postgres.s…"   11 days ago      Exited (0) 11 days ago                   core_admin_run_e0ffdfacdd79
70f006d7ff9c   73e5e8f8198d                    "wait_for_postgres.s…"   11 days ago      Exited (0) 11 days ago                   core_admin_run_c3a5ca0c7a2d
19c46e6a21cb   73e5e8f8198d                    "wait_for_postgres.s…"   11 days ago      Exited (0) 11 days ago                   core_admin_run_92dadd520348
d5e7166cedf5   73e5e8f8198d                    "wait_for_postgres.s…"   11 days ago      Exited (137) 11 days ago                 core_admin_run_24d6a480346f
...

Command pydev installation ends with this:

...
$ docker-compose -p core -fdocker/compose/docker-compose.yml -fdocker/compose/docker-compose.local.yml run --use-aliases admin ./manage.py migrate && ./manage.py migrate --database=log && ./manage.py initdata && ./manage.py collectstatic && ./manage.py sync_permissions && ./manage.py sync_validators
Starting core_static_1 ... done
Starting core_base_1   ... done
Creating core_admin_run ... done
postgres:5432 - accepting connections
Operations to perform:
  Apply all migrations: ...
Running migrations:
  ...
  Applying revolving_loan.0017_migration... OK
  Applying revolving_loan.0018_migration... OK
/bin/bash: line 1:    33 Killed                  ./manage.py migrate

It fails in different migration every time.