drummerb / bfcolorpickerpopover Goto Github PK

I'm getting lots of the following errors at runtime while using the extended color well. Running OS X 10.11.3:

: Error: this application, or a library it uses, has passed an invalid numeric value (NaN, or not-a-number) to CoreGraphics API and this value is being ignored.Please fix this problem.

The method

- (BOOL)_delegatePopoverShouldClose:(id)sender

(BFColorPickerPopover:182) is not called in Yosemite when the popover is dismissed by clicking outside, and thus the popover keeps observing changes on the shared color picker, creating some weird behaviour.

BFColorPickerPopover is not disappearing after selecting color.

Hi

I am having an issue where the ColorPicker will not display when clicked inside an NSTableView. From debugging the issue I see that the method:

• (void)_performActivationClickWithShiftDown:(BOOL)shift inside NSColorWell+BFColorPickerPopover.m

Is not being called when the mouseDown event is fired inside BFPopoverColorWell.m.

I have tried changing the mouseDown event to always call:
[self deactivate];
[self activateWithPopover];

This fixed the issue of the Popover not displaying but introduced a different issue that when I clicked onto a another NSColorWell without dismissing the ColorPickerPopover the colour would change both NSColorWells to be the same colour.

Can you please help me to understand how I cold possibly fix this issue ?

Thanks,
Michael

User favorites (the favorite color palette at the bottom) are not loaded when the picker is displayed. These favorites are shared across applications. If you then add favorites through the picker, the user's favorite colors are replaced with the newly-created list (that is, a list of 10 colors is immediately reset to a list with the only first color you add via the picker). Because the list is "empty" when presented, then overwritten when changed, this leads to data loss.

Steps to recreate:

1. Launch another application and create or observe favorite colors in the color picker panel.
2. Launch your picker demo app.
3. Note the empty favorites.
4. Drag a new color into the favorites.
5. Switch back to other app and observe reset favorites with new color only.
6. Quit your demo app and relaunch.
7. Observe once again the most recent favorites are empty.

After spending some time investigating BFColorPicker, I was unable to determine the cause. I have a theory transferring the panel's contents disconnects something that wasn't considered. I welcome a discussion. :-)

I've also added this issue in OskarGroth's ColorPickerPopover (Swift rewrite of this project).