dsample / mobilebarcoder Goto Github PK

I notice that getBarcodeFromSelection/showBarcodeFromSelection and getBarcodeFromLink/showBarcodeFromLink share some code, and that the get* functions don't actually return values but open new tabs instead. Would you be open to a pull request to reduce the duplication for these functions by renaming the get* functions above to open_, then having both call a get_ function (eg. getBarcodeURLFromLink) that returns the appropriate information?

(My apologies if this isn't considered proper etiquette; I'm just starting to branch out on GitHub and don't know if this sort of thing is considered proper etiquette or not yet.)

Report from Mozilla Add-on review process:

There are some variables that are leaking into the global namespace because you've not declared them with var:
link, menu, selection, image, prefix, sizenumber

I thought this was already a feature but it seems to have stopped working.

The preferences now need to be stored under 'extensions.mobilebarcode.'. However, as there are already lots of users with the extension installed it would be good to come up with a migration method, preferably triggered on upgrading of the extension.

I would like to implement local generation of barcodes into the addon. I suspect that the easiest way to do this will be to integrate https://code.google.com/p/bwip-js/ , which is offered under the MIT Licence. Alternatively, QR-only generation can be done with https://davidshimjs.github.io/qrcodejs/ , with is also offered under the MIT Licence.

As I understand it, Mobile Barcoder uses the BSD Licence. I don't know the intricacies of how these licences interact myself, so I don't know if this integration is legally possible without changing Mobile Barcoder's licence. If it's wanted, I can try to take a look to find out.

Do you think this is worth it? I personally do, but this is your addon. :D