GithubHelp home page GithubHelp logo

activatr's Issues

Remove timetk dependency

timetk got archived at one point (though it's back online now), and this package is only using it for slidify. We can change to depend on slider instead, which is what timetk uses under the hood.

Error creating a map with ggmap

Not sure if you the package is still maintained, but in case it is, here's the error is reproduced below with the package's test data:

> library(activatr)
> filename <- system.file(
  "extdata",
  "running_example.gpx.gz",
  package = "activatr")
> df <- parse_gpx(filename)
> df
# A tibble: 4,433 × 4
     lat   lon   ele time               
 * <dbl> <dbl> <dbl> <dttm>             
 1  37.8 -122.  17   2018-11-03 14:24:45
 2  37.8 -122.  16.8 2018-11-03 14:24:46
 3  37.8 -122.  17   2018-11-03 14:24:48
 4  37.8 -122.  17   2018-11-03 14:24:49
 5  37.8 -122.  17.2 2018-11-03 14:24:50
 6  37.8 -122.  17.6 2018-11-03 14:24:51
 7  37.8 -122.  17.4 2018-11-03 14:24:52
 8  37.8 -122.  17.4 2018-11-03 14:24:53
 9  37.8 -122.  17.4 2018-11-03 14:24:54
10  37.8 -122.  17.4 2018-11-03 14:24:55
# … with 4,423 more rows
# ℹ Use `print(n = ...)` to see more rows
> get_ggmap_from_df(df)
Source : https://maps.googleapis.com/maps/api/staticmap?center=37.793041,-122.412645&zoom=14&size=640x640&scale=2&maptype=terrain&key=xxx
Error in aperm.default(map, c(2, 1, 3)) : 
  invalid first argument, must be an array
In addition: Warning message:
In get_googlemap(center = center, zoom = zoom, ...) : HTTP 400 Bad Request

Session information

> sessionInfo()
R version 4.2.1 (2022-06-23)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 22.04.1 LTS

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/atlas/libblas.so.3.10.3
LAPACK: /usr/lib/x86_64-linux-gnu/atlas/liblapack.so.3.10.3

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C              
 [3] LC_TIME=en_GB.UTF-8        LC_COLLATE=en_US.UTF-8    
 [5] LC_MONETARY=en_GB.UTF-8    LC_MESSAGES=en_US.UTF-8   
 [7] LC_PAPER=en_GB.UTF-8       LC_NAME=C                 
 [9] LC_ADDRESS=C               LC_TELEPHONE=C            
[11] LC_MEASUREMENT=en_GB.UTF-8 LC_IDENTIFICATION=C       

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] ggmap_3.0.0    ggplot2_3.3.6  activatr_0.1.0 jsonlite_1.8.0

loaded via a namespace (and not attached):
 [1] Rcpp_1.0.9          lubridate_1.8.0     lattice_0.20-45    
 [4] tidyr_1.2.0         listenv_0.8.0       png_0.1-7          
 [7] class_7.3-20        zoo_1.8-10          assertthat_0.2.1   
[10] digest_0.6.29       ipred_0.9-13        utf8_1.2.2         
[13] parallelly_1.32.1   R6_2.5.1            plyr_1.8.7         
[16] hardhat_1.2.0       httr_1.4.4          pillar_1.8.1       
[19] RgoogleMaps_1.4.5.3 rlang_1.0.4         curl_4.3.2         
[22] geosphere_1.5-14    furrr_0.3.1         rpart_4.1.16       
[25] Matrix_1.4-1        slider_0.2.2        splines_4.2.1      
[28] gower_1.0.0         stringr_1.4.1       timetk_2.8.1       
[31] munsell_0.5.0       compiler_4.2.1      pkgconfig_2.0.3    
[34] globals_0.16.0      nnet_7.3-17         tidyselect_1.1.2   
[37] tibble_3.1.8        prodlim_2019.11.13  codetools_0.2-18   
[40] fansi_1.0.3         future_1.27.0       dplyr_1.0.9        
[43] withr_2.5.0         MASS_7.3-58.1       bitops_1.0-7       
[46] recipes_1.0.1       grid_4.2.1          gtable_0.3.0       
[49] lifecycle_1.0.1     DBI_1.1.3           magrittr_2.0.3     
[52] scales_1.2.1        warp_0.2.0          future.apply_1.9.0 
[55] cli_3.3.0           stringi_1.7.8       rsample_1.1.0      
[58] sp_1.5-0            timeDate_4021.104   xml2_1.3.3         
[61] ellipsis_0.3.2      xts_0.12.1          generics_0.1.3     
[64] vctrs_0.4.1         lava_1.6.10         rjson_0.2.21       
[67] tools_4.2.1         glue_1.6.2          purrr_0.3.4        
[70] jpeg_0.1-9          parallel_4.2.1      survival_3.4-0     
[73] colorspace_2.0-3   

Remove {styler} dependency

Background Information

Hi, author of the formatting package {styler} here. As I judge from a search in your source code, there is no functionality that uses {styler}, in other words {styler} is not a runtime dependency. You may recommend people to format their code when they contribute, so {styler} is a development dependency. Adding {styler} as a dependency (via Imports: or Suggests:) to your package has the following drawbacks:

  • Your user's may install a package they don't need (assuming most people who install your package are useres, not developers). This costs additional bandwith, installation time, disk space etc... If they need it, they can just manually install it.
  • I as a maintainer of {styler} have to run reverse dependency checks (R CMD Check your package with my new version of {styler}) upon submitting to CRAN e.g. with {revdepcheck}. {styler} has more than 40 reverse dependencies, which makes this a long process.

For that reason, I suggest you to drop that dependency from your package. If you want to ensure your code remains styled, I recommend {precommit} to apply {styler} on each commit or other tools described in the third-party integrations website of {styler}.

For the removal to take effect, a CRAN submission of your package is required (but the issue is not urgent). For tracking, this issue is referenced in r-lib/styler#1121.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.