dstmodders / mod-ground-chest Goto Github PK

• I understand that if I ignore these instructions, my issue may be closed without review.
• I have made sure that there are no similar opened issues.
• I have made sure that the mod version matches the latest release.
• I have reproduced this issue when other mods have been disabled.

Describe the bug

When the player changes the Resolution in Settings, the Ground Chest Interface may be off-screen. Additionally, it can be moved off-screen if the Resolution is smaller than the previous one.

Steps to reproduce

1. Have the Resolution set at some reducable value. Eg. 1920x1080
2. Open up the Ground Chest Interface.
3. Move it to the side while all of it is still visible.
4. Go to settings and lower the Resolution in Graphics. Eg. Lower to 1280x720
5. See that the Ground Chest Interface is either not visible or is sticking out from the side.
6. Be able to fully move the Ground Chest Interface off-screen.

Expected behaviour

The Ground Chest Interface doesn't allow the user to fully move it off-screen and it is visible in the same position when changing the Resolution.

Console output

If applicable, replace this line with the console output.

Screenshot

• I understand that if I ignore these instructions, my issue may be closed without review.
• I have made sure that there are no similar opened issues.
• I have made sure that the mod version matches the latest release.
• I have reproduced this issue when other mods have been disabled.

Describe the bug

Some items do not have an image texture in the Ground Chest Interface. For example, Beached Bull Kelp (prefab "bullkelp_beachedroot"), Active Bernie (prefab "bernie_active").

Steps to reproduce

1. Spawn in Beached Bull Kelp via c_spawn("bullkelp_beachedroot") or an Active Bernie via c_spawn("bernie_active")
2. Open up the Ground Chest Interface.
3. Notice how there's a "Question Mark" texture in a tile.
4. Hover over it and see that it's the item that was spawned in.

Expected behaviour

The item has a distinguishable image texture that isn't a "Question Mark".

Console output

If applicable, replace this line with the console output.

Screenshot

• I understand that if I ignore these instructions, my issue may be closed without review.
• I have made sure that there are no similar opened issues.
• I have made sure that the mod version matches the latest release.
• I have reproduced this issue when other mods have been disabled.

Describe the bug

The games crash with a message (see screenshot) after reloading mods. Didn't investigate yet.

Steps to reproduce

1. Enable mods "Ground Chest" and "Dev Tools"
2. Reload: Ctrl + R
3. See error

Expected behaviour

Not crash.

Console output

If applicable, replace this line with the console output.

Screenshot

Verify

• I understand that if I ignore these instructions, my issue may be closed without review.
• I have made sure that there are no similar opened issues.
• I have made sure that the mod version matches the latest release.

Is your feature request related to a problem? Please describe.

Our dstmodders/action branch is stable enough, so we can add the corresponding GitHub Actions workflow to have an automated code linting features. Moreover, it would make sense to add all the required dotfiles as well in the same PR.

Describe the solution you'd like

Add CI GitHub Actions workflow.

Describe alternatives you've considered

If applicable, add a clear and concise description of any alternative solutions or features you've considered.

Additional context

Progress

• Add ci GitHub Actions workflow
• Add dotfiles
  • .editorconfig
  • .luacheckrc
  • .prettierignore
  • .prettierrc
  • .stylua.toml

Got this issue
Tested with other mods, on video link there is no mods at all
imgur