GithubHelp home page GithubHelp logo

screenshot-maker's People

Contributors

duch94 avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar

screenshot-maker's Issues

Move saving images to separate class/module

What:
Move saving and loading images to separate class/module

Why:
If this logic will be described in separate entity, it will be easier to read code and will help to avoid code duplication.

How:
Probably, this entity will have two functions:

  • save image with given name (and create *.SUCCESS file to flag that file saved)
  • load image with given name (if flag file *.SUCCESS exists, otherwise - return message that message doesnt exist by now)

Write more documentation to readme

What:
Add full information about how to use this instrument to README.MD.

Why:
Users cannot try this instrument without reading the code - this is too complicated.

How:
Should be described:

  • every entity of type action
  • endpoints
  • also, examples could be good

Remove installing Poetry from Dockerfile

What:
Remove poetry from Dockerfile.

Why:
Docker image should be as tiny as possible

How:
Using Poetry we can build wheel or sdist and install it into image.

Chrome don't want to start when user is root.

Why:
Chrome don't want to start when user is root. It wants --no-sandbox parameter.

What:
Need to make chrome start correctly.

How:
Run it with --no-sandbox
OR
Change user in container from root to someone else.

The application shall be configurable

Background

It was discovered that there are some hard coded values, like path to folder where images shall be saved to or path to the directory for logs.

Problem

These hardcoded values prevents project from being used by a broader community.

What to do

Make the application configurable.

Definition of done

There are no hardcoded values in the code base of the project.

Save multiple screenshots if there are more than one action like that

What:
Implement saving more than one screenshot - for each “make_screenshot” action.

Why:
Because rewriting screenshot on each action is incorrect and inefficient behavior.

How:
If there is more than one action of making screenshot, app should save it like img_id.png, img_id_1.png, img_id_2.png... img_id_N.png. Also, downloading of screenshots should return all of them.

Write dockerfile

Why:

To deploy easily we need dockerfile with fully configured service

What:

Need to write dockerfile and edit compose, if needed

Add logging

Why:

For more info while debugging

What:

Write logger factory so each module could generate its own logger

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.