duckduckgo / ios-search-and-stories

DuckDuckGo Search & Stories for iOS

DuckDuckGo Search & Stories

Thank you for visiting. This project is no longer maintained, check out our new project at https://github.com/duckduckgo/iOS.

License

DuckDuckGo Search & Stories is distributed under the Apache 2.0 license.

ios-search-and-stories's Issues

ability to save images from stories

visual refresh

Wrong !Bang Favicon used in Menu

@micpringle , looks like the wrong icon was used for the bang icons in the menu. Can you please use this one.

Cancel tap when finger is moved

When tapping a story (from the feed) or search (from favorites or recents), sliding, and then releasing, the item is activated regardless. We should cancel the tap once a finger is moved.

Close drop-down on scroll

When the 3-dot menu is open and you start scrolling the feed, the menu is closed as expected. However, you have to scroll again to make the page actually scroll. I would like to remove one step so that the page scrolls immediately rather than requiring you to lift your finger off the screen to scroll again.

Current:

1. 3-dot menu is open
2. scroll feed, menu is closed
3. scroll feed again to actually scroll feed

Desired:

1. 3-dot menu is open
2. scroll feed, menu closes and feed is scrolled

re-attempt icon / images download for source if first time fails.

Move search URL back to https://duckduckgo.com

Reccomendation: Convert to Swift

Last summer Apple unveiled its new programming language Swift to the world. Eventually Obj - C is going to be phased out. Due to the great new features and new syntax it makes coding iPhone apps even easier. I feel that then more people may contribute to this project if we converted to Swift. I want to help do this, but before I wrote some code I figured it should be discussed.

default source list needs to be modifiable both adding and removing

so we should have three lists.
user enabled
user disabled
default source list

if something isn't explicitly in either user list it should follow the default source list behavior.

Remove stories from search, and missing dividers

Recently read stories are appearing within search. We should only have recent searches appear within search. Recent stories should only appear within the recent stories tab (which is already the case).

In addition, I'm missing a lot of dividers throughout the interface, can you add them back in?

More missing dividers:

quack on refresh broken

Flickering error

On the iOS Search and Stories app, after reading a news item and returning to the menu, all the story icons start to flicker, and while the buttons still can be pressed, scrolling doesn't work. The application has to be restarted for it to work.

OS: iOS 7.0–7.0.6, 7.1
Model: iPhone 4s

Fix share topbar and message format

When sharing a story the topbar looks horrible, Can you use the default color and alignment treatment here? That would be white text on a fully red topbar.

Status Bar

On iOS 7 it's clear the status bar needs some attention.

There are three options to resolve this (ordered by amount of time required to implement):

1. Hide the status bar completely
2. Reduce the size of the parent UIWindow by 20pts, and then offset it's x position by the same amount. This would bring the appearance of the status bar in-line with all previous versions of iOS
3. Nudge the content down by 20pts on each view, and take advantage of the newer iOS 7 APIs to handle the status bar appearance. This would also require some new assets, such as a taller navigation bar graphic. Choosing this route would also allow us to manipulate the colour of the text on status bar, meaning we could transition it from black to white when showing the basement view

/cc @nilnilnil

autocomplete acts weird when URL is in the bar.

duck mode

Add a new home view, in addition to {Stories, Recents, Saved}, that is just a search only mode. The app should just feature the DuckDuckGo logo and open the keyboard right when the application opens.

easier way to get back to the home screen

iPad has default iOS icon

"Change Sources" show duplicates on initial launch of iOS DuckDuckGo app

@tommytommytommy @micpringle @infinitekind

iPhone 6 and 6 Plus compatibility

I've reviewed the app using both the 6 and 6 Plus simulators and for the most part it appears to function just fine. However, there is a weird visual anomaly when choosing a menu item from the slide-over menu, as shown in this video.

Would you like us to go ahead and investigate + fix this?

Empty gap where device status bar would be in landscape view

The space is there but we don't show anything in it. Can we just shorten the height of the frame to accommodate only the height of the search field?

periodically clear cookies and cache

Context menu disappears when on an image only story and swift right to left

App icon wasn't updated with the new file

@micpringle Please update the App icon artwork with this file:

Update search URL to use next

next.duckduckgo.com

when searching bangs, the menu icon should be the bang favicon not the search icon

I think this was the original behavior and we changed it to be more generic. I'm not sure though.

Enhance the out-of-box experience for contributors

Silly little things, but it would be nice to make it a no-brainer for people to clone and build.

I did this with master (1de348f) and had the following issues building with Xcode 6.1 (not sure whether or not this is relevant, I don't think so):

1. Document the git submodule update --init command required to pull down the dependencies, to save numpties like me who don't use submodules (cocoapods!) from hunting around
2. The files in the AFNetworking group in the Xcode project appear to be "Relative to Group", rather than "Relative to Project" and as such the files can't be found by Xcode — at least on 6.1
3. Document the need to install mogenerator and download link
4. Look at updating mogenerator build script which uses /usr/local/bin/mogenerator — the latest mogenerator when installed on my disk lives in /usr/bin at least on Yosemite

With these steps I have managed to build and run it under 6.1

!bang causing app to crash during autocomplete

https://twitter.com/jeffpar/status/421836508216053761

thanks to jeffpar for reporting:

"@jeffpar: @duckduckgo In the iOS app, if I begin a search with “!oyez “ the app crashes right after the space."

app sound doesn't work through dock?

No sound coming from the iOS app when using a 3rd party speaker dock but it works fine in iOS Safari using DDG.

smaller text for autocomplete when not bang search

@3x assets for iPhone 6 Plus

@chrismorast

Would you be able to provide @3x versions of all the assets used in the app so we can make sure it looks great on the new iPhone 6 Plus?

all stories not coming through

noticed that I am not seeing all the sources represented by the server on the client

Images don't update when feed images changes on backend.

@micpringle @infinitekind @yegg @kablamo

All text in landscape view goes to title size.

@micpringle @nilnilnil , when I turn my phone to landscape in readability view all text converts to title size. @micpringle please assign to @nilnilnil if this is not something that should be in your court. Thanks.

Added functionality for icons

The tabbar icons (search, stories, favorites, recents, settings) currently open the corresponding page. However, when you tap them again, nothing happens. When you tap the icon of a page you're already on, the page should scroll to the top of the main page (same effect as when you're tapping the statusbar).

Some apps that are doing this right are Instagram, Twitter, Facebook, etc. Scroll down your feed and tap the icon of the page you're already on.

"Recents Cleared" Icon is oval, it should be a circle

Maybe this may be related to the size we specify for "save to favorites" & "Remove from favorites" icons.

iPad Air Concerns

I just went through ~70 issues and some of them were from users experiencing issues on the iPad Air. It's unclear if it's just frustration with the fact it's not a universal applicaiton though.

DDG-iOS user agent for all requests to DDG, not just WatrCoolr.

more saturated icon

ellipsize middle string on autocomplete entries.

Swiping back returns to Home and not Results

clicking a results and then swiping back returns to Home instead of the results page

introduce TLS visual cue

sometimes our custom "layers" are broken

and the user can't go back. This additionally has issues where the wrong icon (back vs. hamburger) is being shown.

IGNORE:::amazon version

update icon

change 'autocomplete' to 'autosuggest' in settings

crazy visual stuff in list view when returning to stories feed

user report:

Incase they have trouble with the bug in their app that I mentioned here is a little more data:

It occurs regularly (but not always)  when returning to the story list after reading a story. 

Here is a screen shot of sort of what it looks like when it happens (all photos go away and the screen flickers) in the 2nd screen you can see  sort of the middle of a flicker. 

Image loading issues

"Hey guys, I've noticed that there are often images in the app that take forever to load. Do we have size restrictions on the images? If so, are they also applied to a requery?

I'm attaching an screenshot with the immigration story image that had this issue. In addition, It didn't completely."

cloud save settings on mobile app

!Bang suggestions not including the associated sites' icon

@nilnilnil

I've noticed this morning that the !bang suggestions returned by DDG don't include the sites' icon (where available) once you get beyond the !bang.

For instance, if I enter !a an image is returned in the JSON:

But if I enter !a headphones or !amazon headphones only suggested phrases are returned in the JSON:

If a sites' image was returned alongside the phrase when using the !bang it'd make for a much richer experience and would also allow us to provide some context with the suggestions.