GithubHelp home page GithubHelp logo

Comments (4)

jeff-dude avatar jeff-dude commented on September 8, 2024

thanks for raising.

looks like we never cleaned up full path for odos, as we had it excluded previously due to incorrect logic and prod failures. see the final dex_aggregator spell here:
https://github.com/duneanalytics/spellbook/blob/main/models/dex/dex_aggregator_trades.sql#L18-L21
and how only optimism is included:
https://github.com/duneanalytics/spellbook/blob/main/models/dex/dex_aggregator_trades.sql#L37

feel free to open PR to clean that up 👍
you can also add base to odos_trades.sql?

from spellbook.

amalashkevich avatar amalashkevich commented on September 8, 2024

@jeff-dude thanks for the info.
I think I did it here #5718
But the test fails, not sure if this is my change, could you take a look?
https://github.com/duneanalytics/spellbook/actions/runs/8526776877/job/23356758978?pr=5718

from spellbook.

amalashkevich avatar amalashkevich commented on September 8, 2024

Hi @jeff-dude
How can I see how the line 420 looks like? It says "Column 'block_month' cannot be resolved", but according to the schema, the column name 'block_month' is there.

13:47:25 Database Error in model dex_aggregator_trades (models/dex/dex_aggregator_trades.sql)
TrinoUserError(type=USER_ERROR, name=COLUMN_NOT_FOUND, message="line 420:7: Column 'block_month' cannot be resolved", query_id=20240404_134621_00008_qupjv)
compiled Code at target/run/spellbook/models/dex/dex_aggregator_trades.sql

from spellbook.

jeff-dude avatar jeff-dude commented on September 8, 2024

let's complete this in your PR

from spellbook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.