Better Transfers/Balances Tables about spellbook

[0xRobin]

I just checked, tokens.transfers only contains native and erc20 data, not NFT?

Balances do include both tokens and erc20s in 1 schema. We had some discussions about splitting them but decided against it to keep it more maintainable (and the performance gain with splitting was negligible due to the low amount of NFT data in those tables)

tokens.transfers should aim to serve whatever you wanted to do with fungible.transfers, so if there are other shortcomings, we definitely want to know!

[aalan3]

Yeah we planned on putting nft transfers in token.transfers but decided never actually did it, and sounds like we shouldn't.

The same can be done with balances tables but i don't use balances tables really anyways since they're more accurate if I make them myself in query (they're missing staking withdrawals, block rewards, uncle rewards, rebase events)

Our balances are not sums of transfers, they are the actual values you'd get from doing eth_call/getBalance against a node. So if there's a value for a block number it should be the correct value. However, there needs to be an event we track so that we can get the value. ETH withdrawals are tracked but not rebase events for specific tokens for example.