dwdkls / pizzamvc Goto Github PK

Currently everywhere is used hardcoded int

These types should wrap currently used types.
This will allow to separate application service layer to other machine or introduce CQRS.
Response should provide some kind of error information for typical error types.

Security associated types are splited across all framework layers and create mess. These classes should be probably redesigned

Occurs only in case of grid filtered by additional parameters like CustomerOrders in Kebab.

Do it after replacing (or not) grid control

Can be seen on Customers screen in Kebab. Probably related to recent ability to define action links columns.

Maybe free version of jqGrid?
Also check DataTables and SlickGrid.

Because JQuery UI datepicker is now replaced by Bootstrap datepicker, jqGrid markup has to be adjusted to pass proper bootstrap configuration.

Use standard .NET mechanism

This need to be considered. Currently conventions exist in framework assembly but this is probably not good.

http://fsharp.github.io/FAKE/assemblyinfo.html

It is related with audit functionality.
This could be hard to implement. Audit needs information about current user, which can be provided by IUserContext interface but it is probably not easy to inject this into NHibernate interceptor.

The Grid class from MvcJqGrid library contains hardcoded text values and does not allow to use additional attributes. This class is also not extensible at all (private fields, private functions, non generic mechanism for attributes, etc.) The MvcJqGrid was abandoned in 2014.
Code probably need to be forked and improved, then used in PizzaMVC.

Action defined as new column. Few types of actions in base version:

1. Redirect to other action
2. Redirect to any URL
3. Open custom dialog

Polish date format in .NET framework is invalid and not compatible with client side libraries. Find a way to fix it.

What I've been drinking when I added this?

These classes are not needed for normal framework usage (during PIzza-based application work). These classes are necessary only for tests and sample data generation, so they not needed to be a part of Framework assembly.

The model item passed into the dictionary is of type 'Pizza.Contracts.Operations.Results.CrudOperationResult`1[KebabManager.Contracts.ViewModels.Orders.OrderDetailsModel]', but this dictionary requires a model item of type 'Pizza.Contracts.IDetailsModelBase'.

WTF?

This is needed for localization purposes.

Calendar for datetime pops up to bottom and sometimes is not visible.
Value in datetime fields are wrong.

Probably all types from IntegrationTests.Base