GithubHelp home page GithubHelp logo

Comments (9)

dwmkerr avatar dwmkerr commented on May 24, 2024

Are you sure this is an issue with the angular modal service and not simply an issue with the bootstrap modal?

from angular-modal-service.

ajoslin103 avatar ajoslin103 commented on May 24, 2024

I went to the bootstrap modal demo and did not see the same problem, theirs is directing the tab keys into the modal

Your demo page has the issue of the tab key cyclng thru items on the page

AngularUI has the same problem, the tab key cycles thru items on the page

Maybe Angular is 'helping' ?

from angular-modal-service.

dwmkerr avatar dwmkerr commented on May 24, 2024

Possibly, although it might be more that the bootstrap documentation page
has a little bit of JavaScript to stop it from happening

On 4 March 2015 at 15:03, allen joslin [email protected] wrote:

I went to the bootstrap modal demo and did not see the same problem,
theirs is directing the tab keys into the modal

Your demo page has the issue of the tab key cyclng thru items on the page

AngularUI has the same problem, the tab key cycles thru items on the page

Maybe Angular is 'helping' ?


Reply to this email directly or view it on GitHub
#45 (comment)
.

from angular-modal-service.

ajoslin103 avatar ajoslin103 commented on May 24, 2024

I just ran thru the 1st 3 pages of google results on: bootstrap modal

they all have the same problem except for this one:

http://codepen.io/SitePoint/pen/KkHyw

I sure hope that you can figure something out and add it to your code, I'm behind the 8-ball on a big project and your modals are otherwise working wonderfully for me...

If I can be of any help let me know!

from angular-modal-service.

dwmkerr avatar dwmkerr commented on May 24, 2024

Just make sure that when you tab past the last focusable element you manually suppress the event and go to the first focusable element in the modal:

http://jsfiddle.net/dwmkerr/5botatz3/

You can probably event generalise to find the last focusable element in a container via a selector.

from angular-modal-service.

ajoslin103 avatar ajoslin103 commented on May 24, 2024

I just went over to the AngularUI project and they have been trying to find the best solution for a while now. [https://github.com/angular-ui/bootstrap/issues/738]

They point out: Modal.prototype.enforceFocus() in Bootstrap 3 (which I found being called inside the Modal.show() ) and claim that it does the trick...

Now why is that not working for everyone who uses Modal ?

from angular-modal-service.

bogomips avatar bogomips commented on May 24, 2024

any news?

from angular-modal-service.

joelcdoyle avatar joelcdoyle commented on May 24, 2024

This was also a problem with Angular UI Bootstrap's modal for a while (angular-ui/bootstrap#738) but some contributers eventually fixed it. It does not appear to be an easy task. I will take stab at it, because I need it for a custom modal that I am making. If I get it working I'll submit a PR.

from angular-modal-service.

dwmkerr avatar dwmkerr commented on May 24, 2024

This is a challenge for many users, I am collecting all of the open issues related to this and closing them in favour of #209

from angular-modal-service.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.