Conflict with specifying custom middleware about dwolla-v2-ruby

[mculpsf]

I just ran into this issue FWIW. The workaround mentioned above got me going again.

    f.response :json, :content_type => /\bjson$/
    f.adapter Faraday.default_adapter

[javierjulio]

I had to change both the Token.conn and Client.conn methods with the following update:

    def conn
      @conn ||= Faraday.new do |f|
        # ...
        client.faraday.call(f) if client.faraday
        f.response :json, :content_type => /\bjson$/
        f.adapter Faraday.default_adapter
      end
    end

The response json middleware needs to come after any custom middleware but before the adapter, that hast to be last. If I remove the unless client.faraday (I realize why it was there hence the suggested solution in the description) then it works as expected, both with custom middleware such as:

dwolla = DwollaV2::Client.new(...) do |config|
  config.faraday do |f|
    f.use UnderscoreResponseBodyKeys
  end
end

Or if just using the client without any customizations the library parses responses successfully.

@sausman would you be open to possibly splitting out the option for setting faraday middleware and adapter? Or some other solution? I suggest the faraday adapter as separate config option as some of the libraries we use have it that way: twilio-ruby and https://github.com/amro/gibbon#other.