Comments (5)
peterb-onramp
commented on July 23, 2024
2
Recreated PR here #68
from dwolla-v2-ruby.
spencerhunter
commented on July 23, 2024
1
Hey @peterb-onramp and @javierjulio , We'll add this to our upcoming sprint for review. Thanks for opening up the PR!
from dwolla-v2-ruby.
javierjulio
commented on July 23, 2024
This is the correct change and is safe for earlier versions (Ruby 2+). For the record, the samples in the README all use keyword arguments for the client initialization. You had an open PR for this, why did you close it? You should reopen and contribute that change! Thank you!
from dwolla-v2-ruby.
javierjulio
commented on July 23, 2024
Thanks! Now we just need to get a maintainer to run the PR checks so hopefully all checks out.
from dwolla-v2-ruby.
ShreyaThapa
commented on July 23, 2024
Thanks for the PR, @peterb-onramp and @javierjulio for the review! The PR has been merged into main, and the changes will be reflected in the next release!
EDIT: Updated gem available on Ruby Gems - https://rubygems.org/gems/dwolla_v2/versions/3.2.0
from dwolla-v2-ruby.
Related Issues (20)
- Faraday Response Middleware - response details missing
- Make Dwolla Client Initialization Arguments Coherent HOT 2
- Add middleware to help with debugging requests
- DateOfBirth value not allowed HOT 2
- error handling in rails
- Method name clash for Funding Source HOT 1
- get customers by email HOT 2
- Converting camel/kebab case to snake case and vice versa
- Conflict with specifying custom middleware HOT 2
- Odd number of arguments for hash HOT 4
- Generating IAV token generates odd number of arguments error HOT 7
- DwollaV2::Response incompatible with awesome_print
- Parse iso8601 values when deserializing response
- Open to PR creating a links method set HOT 1
- Issue with $dwolla.get function and search customer with multiple statuses HOT 1
- Deprecation warning with Faraday v1
- Gem dependencies out of day HOT 4
- testing with rspec
- github.com/Dwolla/dwolla-v2-ruby/tree/44bea580123ad914b184e54c65f80d05600d3d3d#usage doesn't give correct scopes in uat HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dwolla-v2-ruby.