dynajoe / elm-webpack-project-loader Goto Github PK

I'm not sure what's wrong here (and our webpack config is enormous), so I figured I'd just post here in case this is familiar to you. If not, I'll keep tracking it down :)

I'm running elm-webpack-project-loader. On first run, it works great. On any recompile in watch mode, I get:

ERROR in ../media/visualizations/Interactives.elmproj 2:16
Module parse failed: Unexpected token (2:16)
You may need an appropriate loader to handle this file type.
| {
>   "elm-json-dir": "./",
|   "main-modules": [
|     "./GridFill/SolutionMode.elm",

I've got module.noParse set to /.elmproj$/, so I'm not sure why it's all of a sudden struggling to parse this. Any familiarity?

When running webpack --watch and there is an error somewhere in the Elm files the build fails as expected but if I fix the error and save webpack doesn't attempt to re-compile the elm files.

I can trigger the re-build by touching the .elmproj file and all is great, but touching the elm files doesn't seem to trigger the re-build.

This only happens when there is an error though, if there are no errors on the previous build touching the .elm files cause a re-build as expected.

I've had a dig through the plugin but can't see an obvious reason for this, in fact comparing elm-webpack-loader with elm-project-loader I can't see anything major differences between what the two plugins return on error.

It seems to me like when there is an error webpack doesn't realize that the .elm files are dependencies of the .elmproj file so touching them doesn't trigger a rebuild?

I'm happy to look at a solution if you have any ideas to point me in the right direction?

First off, thanks for creating this loader!

It's good practice to include all dependencies locally in a project and call them from there. (In this case, installing Elm as a dependency of the project, and then calling it from project_root/node_modules/.bin/elm-make.

This loader assumes elm-make is installed globally. It would be nice to have a pathToMake option like elm-webpack-loader so this could be achieved.

tldr; We brought 2 different elm Mains together and they both had a port called init and everything complied fine, elm-webpack-project-loader brought them together and then it blew up at run time.

We have just started switching over to using elm-webpack-project-loader and so far it's looking great.

We did run into 1 issue though, and it's totally "work around-able" and probably not even this project's fault, but it still may make sense to try to do something about it at this layer.

It would appear this is not a new issue: elm/compiler#1450

In theory it seems like this is something elm make should catch.

However, maybe it's possible to do something in this loader to check for conflicting port names and stop it at the webpack level?